Re: [Qemu-devel] [PULL 00/20] Net patches

[Jason Wang <jasowang@redhat.com>]

On 2016年05月23日 19:09, Peter Maydell wrote:
> On 23 May 2016 at 03:13, Jason Wang <jasowang@redhat.com> wrote:
>> The following changes since commit 65603e2fc18b48e6e55a3dd693669413141694ec:
>>
>>    tci: do not include exec/exec-all.h (2016-05-20 15:07:46 +0100)
>>
>> are available in the git repository at:
>>
>>    https://github.com/jasowang/qemu.git tags/net-pull-request
>>
>> for you to fetch changes up to c5247aedff1e4580bc3cce86ae53a93571ef9309:
>>
>>    net/net: Add SocketReadState for reuse codes (2016-05-23 09:51:24 +0800)
>>
>> ----------------------------------------------------------------
>>
>> Main changes:
>>
>> - e1000e emulation
>> - convet vmxnet3 to use DMA api
> Hi; I'm afraid this fails to build on 32 bit hosts and OSX,
> because of errors like this:
>
> ./trace/generated-tracers.h: In function 'trace_net_rx_pkt_parsed':
> ./trace/generated-tracers.h:18565:9: error: format '%lu' expects
> argument of type 'long unsigned int', but ar
> gument 9 has type 'size_t' [-Werror=format=]
>           qemu_log_mask(LOG_TRACE, "%d@%zd.%06zd:net_rx_pkt_parsed "
> "RX packet parsed: ip4: %d, ip6: %d, udp:
>   %d, tcp: %d, l3 offset: %lu, l4 offset: %lu, l5 offset: %lu" "\n",
>           ^
> ./trace/generated-tracers.h:18565:9: error: format '%lu' expects
> argument of type 'long unsigned int', but argument 10 has type
> 'size_t' [-Werror=format=]
> ./trace/generated-tracers.h:18565:9: error: format '%lu' expects
> argument of type 'long unsigned int', but argument 11 has type
> 'size_t' [-Werror=format=]
> ./trace/generated-tracers.h: In function 'trace_net_rx_pkt_l4_csum_calc_csum':
> ./trace/generated-tracers.h:18757:9: error: format '%lu' expects
> argument of type 'long unsigned int', but argument 5 has type 'size_t'
> [-Werror=format=]
>           qemu_log_mask(LOG_TRACE,
> "%d@%zd.%06zd:net_rx_pkt_l4_csum_calc_csum " "L4 Checksum: L4 header
> offset: %lu, length: %u, counter: 0x%X, final checksum: 0x%X" "\n",
>           ^
> ./trace/generated-tracers.h: In function
> 'trace_net_rx_pkt_l3_csum_validate_csum':
> ./trace/generated-tracers.h:18877:9: error: format '%lu' expects
> argument of type 'long unsigned int', but argument 5 has type 'size_t'
> [-Werror=format=]
>           qemu_log_mask(LOG_TRACE,
> "%d@%zd.%06zd:net_rx_pkt_l3_csum_validate_csum " "L3 Checksum: L3
> header offset: %lu, length: %u, counter: 0x%X, final checksum: 0x%X,
> valid: %d" "\n",
>           ^
> ./trace/generated-tracers.h: In function 'trace_net_rx_pkt_rss_hash':
> ./trace/generated-tracers.h:18949:9: error: format '%lu' expects
> argument of type 'long unsigned int', but argument 5 has type 'size_t'
> [-Werror=format=]
>           qemu_log_mask(LOG_TRACE, "%d@%zd.%06zd:net_rx_pkt_rss_hash "
> "RSS hash for %lu bytes: 0x%X" "\n",
>           ^
>
> (these aren't the only ones, please check all your trace
> format strings).
>
> thanks
> -- PMM

Sorry for the failure, I tested 32bit cross build on 64bit guest, but 
looks like this is not sufficient.

Will fix and send V2 soon.

Thanks