From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relmlor3.renesas.com ([210.160.252.173]:50779 "EHLO relmlie2.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751937AbcEXH3c (ORCPT ); Tue, 24 May 2016 03:29:32 -0400 Received: from relmlac4.idc.renesas.com (relmlac4.idc.renesas.com [10.200.69.24]) by relmlir3.idc.renesas.com (Postfix) with ESMTP id 1B4364774D for ; Tue, 24 May 2016 16:29:30 +0900 (JST) Received: from relmlac4.idc.renesas.com (localhost [127.0.0.1]) by relmlac4.idc.renesas.com (Postfix) with ESMTP id DECA0480A3 for ; Tue, 24 May 2016 16:29:29 +0900 (JST) Subject: Re: [PATCH v2 1/3] arm64: dts: r8a7796: Add Renesas R8A7796 SoC support To: Geert Uytterhoeven References: <1463966906-15129-1-git-send-email-horms+renesas@verge.net.au> <1463966906-15129-2-git-send-email-horms+renesas@verge.net.au> <5742B66C.7080102@rvc.renesas.com> CC: Simon Horman , "linux-renesas-soc@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Magnus Damm , Toru Oishi , "Khiem Trong. Nguyen" From: Khiem Nguyen Message-ID: <574402D8.6030400@rvc.renesas.com> Date: Tue, 24 May 2016 14:29:28 +0700 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Geert, On 5/24/2016 1:35 PM, Geert Uytterhoeven wrote: > Hi Khiem, > > On Mon, May 23, 2016 at 9:51 AM, Khiem Nguyen > wrote: >> Using 1.0 will open Suspend-to-RAM support if secure firmware supports that >> feature. >> However, we might need additional work in drivers to support suspend/resume >> handlers. >> So, I suggest that we keep using 0.2 until Suspend-to-RAM feature is >> confirmed in r8a7795/r8a7796. > > Note that we do have suspend/resume support on R-Car Gen2, albeit some > drivers may lack code to save/restore state when their devices are powered > down, as R-Car Gen2 doesn't have power domains for devices. > > So I'd expect everything to work fine, as long as no R-Car Gen3-specific > drivers or devices residing in multimedia power domains are involved. In my test environment using latest integration branch in renesas-drivers (v4.6), it failed to resume due to operation inside rcar_du_pm_resume(). Probably, it should be fixed soon. FYI, your secure firmware will have Suspend-to-RAM support if below log is output. psci: PSCIv1.0 detected in firmware. Thanks. Best regards, KHIEM Nguyen From mboxrd@z Thu Jan 1 00:00:00 1970 From: khiem.nguyen.xt@rvc.renesas.com (Khiem Nguyen) Date: Tue, 24 May 2016 14:29:28 +0700 Subject: [PATCH v2 1/3] arm64: dts: r8a7796: Add Renesas R8A7796 SoC support In-Reply-To: References: <1463966906-15129-1-git-send-email-horms+renesas@verge.net.au> <1463966906-15129-2-git-send-email-horms+renesas@verge.net.au> <5742B66C.7080102@rvc.renesas.com> Message-ID: <574402D8.6030400@rvc.renesas.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Geert, On 5/24/2016 1:35 PM, Geert Uytterhoeven wrote: > Hi Khiem, > > On Mon, May 23, 2016 at 9:51 AM, Khiem Nguyen > wrote: >> Using 1.0 will open Suspend-to-RAM support if secure firmware supports that >> feature. >> However, we might need additional work in drivers to support suspend/resume >> handlers. >> So, I suggest that we keep using 0.2 until Suspend-to-RAM feature is >> confirmed in r8a7795/r8a7796. > > Note that we do have suspend/resume support on R-Car Gen2, albeit some > drivers may lack code to save/restore state when their devices are powered > down, as R-Car Gen2 doesn't have power domains for devices. > > So I'd expect everything to work fine, as long as no R-Car Gen3-specific > drivers or devices residing in multimedia power domains are involved. In my test environment using latest integration branch in renesas-drivers (v4.6), it failed to resume due to operation inside rcar_du_pm_resume(). Probably, it should be fixed soon. FYI, your secure firmware will have Suspend-to-RAM support if below log is output. psci: PSCIv1.0 detected in firmware. Thanks. Best regards, KHIEM Nguyen