From: Laxman Dewangan <ldewangan@nvidia.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH V12 2/2] gpio: max77620: add gpio driver for MAX77620/MAX20024
Date: Tue, 24 May 2016 16:37:22 +0530 [thread overview]
Message-ID: <574435EA.5010908@nvidia.com> (raw)
In-Reply-To: <CACRpkdbbij7Vj+5EDdb2E4neoGUr7Bk28jhKfFWvETTvyfYu7g@mail.gmail.com>
On Tuesday 24 May 2016 04:45 PM, Linus Walleij wrote:
> On Fri, May 13, 2016 at 7:19 AM, Laxman Dewangan <ldewangan@nvidia.com> wrote:
>
>> MAXIM Semiconductor's PMIC, MAX77620/MAX20024 has 8 GPIO
>> pins. It also supports interrupts from these pins.
>>
>> Add GPIO driver for these pins to control via GPIO APIs.
>>
>> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
>> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> PS, please add these optional features:
>
>> + mgpio->gpio_chip.direction_input = max77620_gpio_dir_input;
>> + mgpio->gpio_chip.direction_output = max77620_gpio_dir_output;
> Any chance you could send a patch to add a .get_direction() callback?
Sure, I will send the patch for this and also for the set_single_ended().
I will post the patch on top of this patch as a new patch as this is
already applied in your tree.
Later on, it can be squashed or added as new patch.
next prev parent reply other threads:[~2016-05-24 11:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-13 5:19 [PATCH V12 1/2] gpio: add DT binding doc for gpio of PMIC max77620/max20024 Laxman Dewangan
2016-05-13 5:19 ` Laxman Dewangan
2016-05-13 5:19 ` [PATCH V12 1/2] pinctrl: add DT binding doc for pincontrol " Laxman Dewangan
2016-05-13 5:19 ` Laxman Dewangan
2016-05-24 11:17 ` Linus Walleij
2016-05-13 5:19 ` [PATCH V12 2/2] gpio: max77620: add gpio driver for MAX77620/MAX20024 Laxman Dewangan
2016-05-13 5:19 ` Laxman Dewangan
2016-05-24 11:09 ` Linus Walleij
[not found] ` <1463116755-30469-3-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-05-24 11:15 ` Linus Walleij
2016-05-24 11:15 ` Linus Walleij
2016-05-24 11:07 ` Laxman Dewangan [this message]
2016-05-13 5:19 ` [PATCH V12 2/2] pinctrl: max77620: add pincontrol " Laxman Dewangan
2016-05-13 5:19 ` Laxman Dewangan
2016-05-24 11:21 ` Linus Walleij
2016-05-24 11:18 ` Laxman Dewangan
2016-05-24 11:53 ` Linus Walleij
2016-05-24 11:07 ` [PATCH V12 1/2] gpio: add DT binding doc for gpio of PMIC max77620/max20024 Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=574435EA.5010908@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=devicetree@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.