From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53660)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcel@redhat.com>) id 1b5DEn-00014U-5C
	for qemu-devel@nongnu.org; Tue, 24 May 2016 10:23:14 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <marcel@redhat.com>) id 1b5DEj-0005kg-Uo
	for qemu-devel@nongnu.org; Tue, 24 May 2016 10:23:13 -0400
Received: from mx1.redhat.com ([209.132.183.28]:33701)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcel@redhat.com>) id 1b5DEj-0005kU-Oq
	for qemu-devel@nongnu.org; Tue, 24 May 2016 10:23:09 -0400
References: <1463912514-12658-1-git-send-email-davidkiarie4@gmail.com>
	<1463912514-12658-4-git-send-email-davidkiarie4@gmail.com>
	<20160524144906-mutt-send-email-mst@redhat.com>
	<574450C2.2060805@web.de>
From: Marcel Apfelbaum <marcel@redhat.com>
Message-ID: <574463C4.5070905@redhat.com>
Date: Tue, 24 May 2016 17:23:00 +0300
MIME-Version: 1.0
In-Reply-To: <574450C2.2060805@web.de>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [V11 3/4] hw/core: provision for overriding
 emulated IOMMU
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@web.de>, "Michael S. Tsirkin" <mst@redhat.com>, David Kiarie <davidkiarie4@gmail.com>
Cc: qemu-devel@nongnu.org, peterx@redhat.com, valentine.sinitsyn@gmail.com

On 05/24/2016 04:01 PM, Jan Kiszka wrote:
> On 2016-05-24 13:49, Michael S. Tsirkin wrote:
>> On Sun, May 22, 2016 at 01:21:53PM +0300, David Kiarie wrote:
>>> Added an enum, subject to review, to machine properties which
>>> it used to override iommu emulated from Intel to AMD.
>>>
>>> Signed-off-by: David Kiarie <davidkiarie4@gmail.com>
>>
>> Marcel's
>>   "enable iommu with -device"
>> seems like a better alternative.
>
> If that works for both IOMMUs, it would be preferred. But the last time
> I checked (granted: long ago), there were internal ordering issues
> preventing this.
>

It will work for both. The reason is we delay the bus_master_region creation
to machine_done.

Thanks,
Marcel

> Bonus of moving IOMMU machine options over: They are getting more and
> more, and many are now very IOMMU-specific (like the CM control for Intel).
>
> Jan
>
>