From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 90EAEE00BC2; Tue, 24 May 2016 08:34:18 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily * valid * -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature * -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low * trust * [74.125.82.48 listed in list.dnswl.org] Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id D1146E009C3 for ; Tue, 24 May 2016 08:34:15 -0700 (PDT) Received: by mail-wm0-f48.google.com with SMTP id n129so29122445wmn.1 for ; Tue, 24 May 2016 08:34:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding; bh=kZzgSJsmFV2G69mEjMUN7iMYA9xuBK3/SD2defuXaGs=; b=spHuYG4HEGGN87A60/ReelwBmJ7KFniEcbYNcuBXfQJ6EH55NyLE5e+wx/e80caqdC UBSDGdTCpR0B7i73Odp8uicp5AMSRRHqxj03FmcqIDgU257wiomM5r16/30HsUBy3EF6 W/eFjos3yy4EO5YnaPISH6b4uIwkasylYhyLeZAC91YU71u371Wp0YfCiBzq7ViJCb8A GtfUWaA4/81LP0sJUK6LqYE+tUyInenDptHzzaRph0Rb1/5PmuBv+n/Dx+9kN/jT9VUi BmiHYYwKsHyhS0cvuUG0UDUBqntyF9xQ4qvqPgrxCF+TCMQiADa1blAW4ao/BxM2F1CK 9OzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=kZzgSJsmFV2G69mEjMUN7iMYA9xuBK3/SD2defuXaGs=; b=WZ2b8djw4R3AvmJ+mvtEVliYIwAVyAtQfN95mW/ahft/Dkq/3CtLRndgKXKGwCW5Cn 9/5s9gEr5evlVC/SrOU3obh2HHAMm99bP7ve1rRRPYLgw139dlFkWcbxDzxoYlOMt1zM yL4g1zbf3gKmLAzY58uJfMRLRhO2Fmp4iK+wNhA5pxD7pnRLngENqaqQqQKXEzHR0wrC 2n7Nz1bIjFNec5PqXhGBR0XmjIH0BlSZIotW/4YYjBkzCTME0LyDAP1+OEwI+KoSHmsa VK3Xe9T2OkESgyLEjYRaPB5e4byhldgtbTtaM48vI5KsGUNYERys1By0IFWs+34oUWGi j7vw== X-Gm-Message-State: ALyK8tJgOi6yYEAn+D6/LUkdt2koF+B2cr4mDY8hqukYIJadYxw/8Ow2WlCYTYmy7K0rpMcI X-Received: by 10.194.242.167 with SMTP id wr7mr4939289wjc.145.1464104054518; Tue, 24 May 2016 08:34:14 -0700 (PDT) Received: from [192.168.0.78] (host31-48-249-108.range31-48.btcentralplus.com. [31.48.249.108]) by smtp.googlemail.com with ESMTPSA id n66sm4314939wmn.7.2016.05.24.08.34.13 for (version=TLSv1/SSLv3 cipher=OTHER); Tue, 24 May 2016 08:34:13 -0700 (PDT) To: toaster@yoctoproject.org References: <1464090003-23469-1-git-send-email-belen.barros.pena@linux.intel.com> <1464090003-23469-107-git-send-email-belen.barros.pena@linux.intel.com> From: Michael Wood Message-ID: <57447474.4010301@intel.com> Date: Tue, 24 May 2016 16:34:12 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <1464090003-23469-107-git-send-email-belen.barros.pena@linux.intel.com> Subject: Re: [PATCH 106/106] toaster: Unique project names to Boostrap 3 X-BeenThere: toaster@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Web based interface for BitBake List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 May 2016 15:34:18 -0000 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Phew! great work, thank you!! So on my TODO list the next steps are - Fix the indentation of patches #77, #80 , #81, 82, #91. #92, #93, #94, #96, #98, #102 - Drop #59 - Fixup/squash patches which rewrite the same parts. - Fix the authorship of the typeahead patch - somehow it's been attributed to me - Revert the bootstrap-toaster theme related stuff - Fix the tests which probably will have broken Then we'll merge it into toaster-next, get the build analysis stuff done, let it settle for a bit and then submit it upstream. Michael On 24/05/16 12:40, Belen Barros Pena wrote: > We recently added functionality to enforce unique project names. Such > functionality was marked up for Boostrap 2, and some changes are > required to ensure it works with Bootstrap 3. > > Signed-off-by: Belen Barros Pena > --- > bitbake/lib/toaster/toastergui/static/js/libtoaster.js | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/bitbake/lib/toaster/toastergui/static/js/libtoaster.js b/bitbake/lib/toaster/toastergui/static/js/libtoaster.js > index a56e84a..e4e4f6c 100644 > --- a/bitbake/lib/toaster/toastergui/static/js/libtoaster.js > +++ b/bitbake/lib/toaster/toastergui/static/js/libtoaster.js > @@ -393,11 +393,11 @@ var libtoaster = (function () { > data.results[0].name === projectName) { > // This project name exists hence show the error and disable > // the save button > - ctrlGrpValidateProjectName.addClass('control-group error'); > + ctrlGrpValidateProjectName.addClass('has-error'); > hintError.show(); > enableOrDisableBtn.attr('disabled', 'disabled'); > } else { > - ctrlGrpValidateProjectName.removeClass('control-group error'); > + ctrlGrpValidateProjectName.removeClass('has-error'); > hintError.hide(); > enableOrDisableBtn.removeAttr('disabled'); > }