All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Daney <ddaney.cavm@gmail.com>
To: Anna-Maria Gleixner <anna-maria@linutronix.de>
Cc: linux-kernel@vger.kernel.org, rt@linutronix.de,
	Ralf Baechle <ralf@linux-mips.org>,
	linux-mips@linux-mips.org
Subject: Re: [PATCH] MIPS: Add missing FROZEN hotplug notifier transitions
Date: Tue, 24 May 2016 11:15:04 -0700	[thread overview]
Message-ID: <57449A28.3020901@gmail.com> (raw)
In-Reply-To: <1464095327-55194-1-git-send-email-anna-maria@linutronix.de>

On 05/24/2016 06:08 AM, Anna-Maria Gleixner wrote:
> The corresponding FROZEN hotplug notifier transitions used on
> suspend/resume are ignored. Therefore the switch case action argument
> is masked with the frozen hotplug notifier transition mask.
>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> Cc: linux-mips@linux-mips.org
> Signed-off-by: Anna-Maria Gleixner <anna-maria@linutronix.de>

This seems sane, and I don't object, but can you tell us how this was 
tested?

Thanks,
David Daney


> ---
>   arch/mips/cavium-octeon/smp.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/arch/mips/cavium-octeon/smp.c
> +++ b/arch/mips/cavium-octeon/smp.c
> @@ -384,7 +384,7 @@ static int octeon_cpu_callback(struct no
>   {
>   	unsigned int cpu = (unsigned long)hcpu;
>
> -	switch (action) {
> +	switch (action & ~CPU_TASKS_FROZEN) {
>   	case CPU_UP_PREPARE:
>   		octeon_update_boot_vector(cpu);
>   		break;
>
>

  reply	other threads:[~2016-05-24 18:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-24 13:08 [PATCH] MIPS: Add missing FROZEN hotplug notifier transitions Anna-Maria Gleixner
2016-05-24 18:15 ` David Daney [this message]
2016-05-25  9:51   ` Anna-Maria Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57449A28.3020901@gmail.com \
    --to=ddaney.cavm@gmail.com \
    --cc=anna-maria@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=ralf@linux-mips.org \
    --cc=rt@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.