All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mario Kleiner <mario.kleiner.de@gmail.com>
To: Matthew Auld <matthew.william.auld@gmail.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
	intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	Matthew Auld <matthew.auld@intel.com>
Subject: Re: [PATCH] drm: use seqlocks for vblank time/count
Date: Tue, 24 May 2016 23:17:01 +0200	[thread overview]
Message-ID: <5744C4CD.306@gmail.com> (raw)
In-Reply-To: <CAM0jSHPEi1uoCbNyavUnvjBPBFSK9mj8hLd4z7NCHwoRFrsnSA@mail.gmail.com>

On 05/18/2016 05:10 PM, Matthew Auld wrote:
> There's an updated version of this patch already on the ml [1], which
> I Cc'd you in on. I take it that your @tuebingen.mpg.de is in fact an
> old email address?
>
> [1] https://patchwork.freedesktop.org/patch/86354/
>

Your patch looks good to me. I'd only keep that one dropped comment line 
in drmP.h about the vblank counter and ts also needing to be protected 
by the vblank_timelock in addition to the seqlock, as this is still 
needed, especially to get _irqsave part of spin_lock_irqsave, as the 
write seqlocks in don't do the local irq disable. I'll give it a test 
later this week.

Reviewed-by: Mario Kleiner <mario.kleiner.de@gmail.com>

Indeed the old inactive @tuebingen.mpg.de is only a forward to the gmail 
address, probably with some botched mail filter rules, so they can go 
unnoticed quite a while.

thanks,
-mario
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

      reply	other threads:[~2016-05-24 21:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-09 16:08 [PATCH] drm: use seqlocks for vblank time/count Matthew Auld
2016-05-09 17:16 ` Ville Syrjälä
2016-05-09 18:11   ` Daniel Vetter
2016-05-18 13:54     ` Mario Kleiner
2016-05-18 15:10       ` Matthew Auld
2016-05-24 21:17         ` Mario Kleiner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5744C4CD.306@gmail.com \
    --to=mario.kleiner.de@gmail.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=matthew.auld@intel.com \
    --cc=matthew.william.auld@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.