From mboxrd@z Thu Jan 1 00:00:00 1970 From: Caesar Wang Subject: Re: [PATCH v2 4/5] thermal: bang-bang governor: act on lower trip boundary Date: Wed, 25 May 2016 11:30:32 +0800 Message-ID: <57451C58.6090808@rock-chips.com> References: <20160524130610.GC8979@e104805> <1462268013-14992-1-git-send-email-wxt@rock-chips.com> <1462268013-14992-5-git-send-email-wxt@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Peter Feuerer Cc: huangtao-TNX95d0MmH7DzftRWevZcw@public.gmane.org, Javi Merino , Heiko Stuebner , linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Sascha Hauer , dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, edubezval-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, smbarber-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, cf-TNX95d0MmH7DzftRWevZcw@public.gmane.org, briannorris-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, Zhang Rui List-Id: linux-pm@vger.kernel.org Ck9uIDIwMTblubQwNeaciDI15pelIDAxOjM0LCBQZXRlciBGZXVlcmVyIHdyb3RlOgo+IEhpLAo+ Cj4gMjQuIE1haSAyMDE2IDE1OjA2IFVociwgIkphdmkgTWVyaW5vIiA8amF2aS5tZXJpbm9AYXJt LmNvbT4gc2NocmllYjoKPj4gQ2NpbmcgUGV0ZXIgRmV1ZXJlciwgYXV0aG9yIG9mIHRoZSBiYW5n IGJhbmcgZ292ZXJub3IuCj4+Cj4+IE9uIFR1ZSwgTWF5IDAzLCAyMDE2IGF0IDA1OjMzOjMyUE0g KzA4MDAsIENhZXNhciBXYW5nIHdyb3RlOgo+Pgo+Pj4gRnJvbTogU2FzY2hhIEhhdWVyIDxzLmhh dWVyQHBlbmd1dHJvbml4LmRlPgo+Pj4KPj4+IFdpdGggaW50ZXJydXB0IGRyaXZlbiB0aGVybWFs IHpvbmVzIHdlIHBhc3MgdGhlIGxvd2VyIGFuZCB1cHBlcgo+Pj4gdGVtcGVyYXR1cmUgb24gd2hp Y2ggc2hhbGwgYmUgYWN0ZWQsIHNvIGluIHRoZSBnb3Zlcm5vciB3ZSBoYXZlIHRvIGFjdCBvbgo+ Pj4gdGhlIGV4YWN0IGxvd2VyIHRlbXBlcmF0dXJlIHRvIGJlIGNvbnNpc3RlbnQuIE90aGVyd2lz ZSBhbiBpbnRlcnJ1cHQgbWF5YmUKPj4+IGdlbmVyYXRlZCBvbiB0aGUgZXhhY3QgbG93ZXIgdGVt cGVyYXR1cmUsIGJ1dCB0aGUgYmFuZyBiYW5nIGdvdmVybm9yIGRvZXMKPj4+IG5vdCByZWFjdCBz aW5jZSBUaGUgcG9sbGluZyBkcml2ZW4gem9uZXMgaGF2ZSB0byBiZSBvbmUgc3RlcCBjb29sZXIg YmVmb3JlCj4+PiB0aGUgZ292ZXJub3IgcmVhY3RzLgo+Pj4KPj4+IFNpZ25lZC1vZmYtYnk6IFNh c2NoYSBIYXVlciA8cy5oYXVlckBwZW5ndXRyb25peC5kZT4KPj4+IFNpZ25lZC1vZmYtYnk6IENh ZXNhciBXYW5nIDx3eHRAcm9jay1jaGlwcy5jb20+Cj4+PiBDYzogWmhhbmcgUnVpIDxydWkuemhh bmdAaW50ZWwuY29tPgo+Pj4gQ2M6IEVkdWFyZG8gVmFsZW50aW4gPGVkdWJlenZhbEBnbWFpbC5j b20+Cj4+PiBDYzogbGludXgtcG1Admdlci5rZXJuZWwub3JnCj4gQWNrZWQtYnk6IFBldGVyIEZl dWVyZXIgPHBldGVyQHBpaWUubmV0PgoKT2theSwgdGhhbmtzIHlvdXIgcmV2aWV3aW5nLiA6KQoK Pgo+Cj4+PiAtLS0KPj4+Cj4+PiBDaGFuZ2VzIGluIHYyOgo+Pj4gLSBVcGRhdGUgdGhlIGNvbW1p dCBmb3IgcGF0Y2hbdjIgNC81XS4KPj4+Cj4+PiBkcml2ZXJzL3RoZXJtYWwvZ292X2JhbmdfYmFu Zy5jIHwgMiArLQo+Pj4gMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9u KC0pCj4+Pgo+Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvdGhlcm1hbC9nb3ZfYmFuZ19iYW5nLmMg Yi9kcml2ZXJzL3RoZXJtYWwvZ292X2JhbmdfYmFuZy5jCj4+PiBpbmRleCA3MDgzNmM1Li45ZDFk ZmVhIDEwMDY0NAo+Pj4gLS0tIGEvZHJpdmVycy90aGVybWFsL2dvdl9iYW5nX2JhbmcuYwo+Pj4g KysrIGIvZHJpdmVycy90aGVybWFsL2dvdl9iYW5nX2JhbmcuYwo+Pj4gQEAgLTU5LDcgKzU5LDcg QEAgc3RhdGljIHZvaWQgdGhlcm1hbF96b25lX3RyaXBfdXBkYXRlKHN0cnVjdCB0aGVybWFsX3pv bmVfZGV2aWNlICp0eiwgaW50IHRyaXApCj4+PiBpZiAoaW5zdGFuY2UtPnRhcmdldCA9PSAwICYm IHR6LT50ZW1wZXJhdHVyZSA+PSB0cmlwX3RlbXApCj4+PiBpbnN0YW5jZS0+dGFyZ2V0ID0gMTsK Pj4+IGVsc2UgaWYgKGluc3RhbmNlLT50YXJnZXQgPT0gMSAmJgo+Pj4gLSB0ei0+dGVtcGVyYXR1 cmUgPCB0cmlwX3RlbXAgLSB0cmlwX2h5c3QpCj4+PiArIHR6LT50ZW1wZXJhdHVyZSA8PSB0cmlw X3RlbXAgLSB0cmlwX2h5c3QpCj4+PiBpbnN0YW5jZS0+dGFyZ2V0ID0gMDsKPj4+Cj4+PiBkZXZf ZGJnKCZpbnN0YW5jZS0+Y2Rldi0+ZGV2aWNlLCAidGFyZ2V0PSVkXG4iLAo+Pj4gLS0KPj4+IDEu OS4xCj4+Pgo+Pj4gLS0KPj4+IFRvIHVuc3Vic2NyaWJlIGZyb20gdGhpcyBsaXN0OiBzZW5kIHRo ZSBsaW5lICJ1bnN1YnNjcmliZSBsaW51eC1wbSIgaW4KPj4+IHRoZSBib2R5IG9mIGEgbWVzc2Fn ZSB0byBtYWpvcmRvbW9Admdlci5rZXJuZWwub3JnCj4+PiBNb3JlIG1ham9yZG9tbyBpbmZvIGF0 IGh0dHA6Ly92Z2VyLmtlcm5lbC5vcmcvbWFqb3Jkb21vLWluZm8uaHRtbAo+Cj4KCi0tIApjYWVz YXIgd2FuZyB8IHNvZnR3YXJlIGVuZ2luZWVyIHwgd3h0QHJvY2stY2hpcC5jb20KCgoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXgtcm9ja2NoaXAg bWFpbGluZyBsaXN0CkxpbnV4LXJvY2tjaGlwQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xp c3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1yb2NrY2hpcAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754745AbcEYDhw (ORCPT ); Tue, 24 May 2016 23:37:52 -0400 Received: from regular1.263xmail.com ([211.150.99.133]:48861 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754653AbcEYDhk (ORCPT ); Tue, 24 May 2016 23:37:40 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: wxt@rock-chips.com X-FST-TO: peter@piie.net X-SENDER-IP: 103.29.142.67 X-LOGIN-NAME: wxt@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <57451C58.6090808@rock-chips.com> Date: Wed, 25 May 2016 11:30:32 +0800 From: Caesar Wang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Peter Feuerer CC: Javi Merino , edubezval@gmail.com, Heiko Stuebner , dianders@chromium.org, briannorris@google.com, smbarber@google.com, linux-rockchip@lists.infradead.org, cf@rock-chips.com, huangtao@rock-chips.com, dmitry.torokhov@gmail.com, Sascha Hauer , Zhang Rui , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 4/5] thermal: bang-bang governor: act on lower trip boundary References: <20160524130610.GC8979@e104805> <1462268013-14992-1-git-send-email-wxt@rock-chips.com> <1462268013-14992-5-git-send-email-wxt@rock-chips.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016年05月25日 01:34, Peter Feuerer wrote: > Hi, > > 24. Mai 2016 15:06 Uhr, "Javi Merino" schrieb: >> Ccing Peter Feuerer, author of the bang bang governor. >> >> On Tue, May 03, 2016 at 05:33:32PM +0800, Caesar Wang wrote: >> >>> From: Sascha Hauer >>> >>> With interrupt driven thermal zones we pass the lower and upper >>> temperature on which shall be acted, so in the governor we have to act on >>> the exact lower temperature to be consistent. Otherwise an interrupt maybe >>> generated on the exact lower temperature, but the bang bang governor does >>> not react since The polling driven zones have to be one step cooler before >>> the governor reacts. >>> >>> Signed-off-by: Sascha Hauer >>> Signed-off-by: Caesar Wang >>> Cc: Zhang Rui >>> Cc: Eduardo Valentin >>> Cc: linux-pm@vger.kernel.org > Acked-by: Peter Feuerer Okay, thanks your reviewing. :) > > >>> --- >>> >>> Changes in v2: >>> - Update the commit for patch[v2 4/5]. >>> >>> drivers/thermal/gov_bang_bang.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/thermal/gov_bang_bang.c b/drivers/thermal/gov_bang_bang.c >>> index 70836c5..9d1dfea 100644 >>> --- a/drivers/thermal/gov_bang_bang.c >>> +++ b/drivers/thermal/gov_bang_bang.c >>> @@ -59,7 +59,7 @@ static void thermal_zone_trip_update(struct thermal_zone_device *tz, int trip) >>> if (instance->target == 0 && tz->temperature >= trip_temp) >>> instance->target = 1; >>> else if (instance->target == 1 && >>> - tz->temperature < trip_temp - trip_hyst) >>> + tz->temperature <= trip_temp - trip_hyst) >>> instance->target = 0; >>> >>> dev_dbg(&instance->cdev->device, "target=%d\n", >>> -- >>> 1.9.1 >>> >>> -- >>> To unsubscribe from this list: send the line "unsubscribe linux-pm" in >>> the body of a message to majordomo@vger.kernel.org >>> More majordomo info at http://vger.kernel.org/majordomo-info.html > > -- caesar wang | software engineer | wxt@rock-chip.com