From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49135) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b5Q1H-0000ci-43 for qemu-devel@nongnu.org; Wed, 25 May 2016 00:02:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b5Q1F-0000bA-4x for qemu-devel@nongnu.org; Wed, 25 May 2016 00:02:06 -0400 References: <1464097654-12977-1-git-send-email-kwolf@redhat.com> <1464097654-12977-9-git-send-email-kwolf@redhat.com> <57452141.2060001@cn.fujitsu.com> From: Eric Blake Message-ID: <574523B4.3010305@redhat.com> Date: Tue, 24 May 2016 22:01:56 -0600 MIME-Version: 1.0 In-Reply-To: <57452141.2060001@cn.fujitsu.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="oIpNLhWFfpgUQPV8aP7Fa2CDfPELD7oad" Subject: Re: [Qemu-devel] [PATCH v2 08/14] mirror: Use BlockBackend for I/O List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Changlong Xie , Kevin Wolf , qemu-block@nongnu.org Cc: jsnow@redhat.com, jcody@redhat.com, berto@igalia.com, qemu-devel@nongnu.org, mreitz@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --oIpNLhWFfpgUQPV8aP7Fa2CDfPELD7oad Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/24/2016 09:51 PM, Changlong Xie wrote: > On 05/24/2016 09:47 PM, Kevin Wolf wrote: >> + s->target =3D blk_new(); > blk_new(errp); Depends on Kevin's block/next branch, which currently includes: commit 5d7dd50566a4f9786b95f49448f48fead0bb34d8 Author: Max Reitz Date: Tue May 17 16:41:34 2016 +0200 block: Drop errp parameter from blk_new() blk_new() cannot fail so its Error ** parameter has become superfluou= s. Signed-off-by: Max Reitz Signed-off-by: Kevin Wolf So the patch builds as written when applied to the correct branch. http://repo.or.cz/qemu/kevin.git --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --oIpNLhWFfpgUQPV8aP7Fa2CDfPELD7oad Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXRSO0AAoJEKeha0olJ0Nq5h4IAK9+Cg4uVt3X3cmCAQ6gS4ou mVqpllYmDVU94+5WIA/kMg8C4LA6HHD3oL9oWqz4Qz3gKKO1PcWzwoFnD/pQm11m Nah8/ZTaCduyFWX786CVg8EV4r8gJC4goeeRlEUYEU16Mn5jXvz2tcv14V126atb DRXggnc+b7xw9cQYKwRHcG0tAfp7wdvTjFADc6iEd5YVhXkk1JxVw7mMziohdoID IuguSq+8iPhhrgfzHM1HEwDGh91parHA6OvE6TvGFTIsLGE5FSiUfGv1jQFoZX65 46WkRpZ0IrJO5Txh2BB3nAdFwNs3ubEx7ReQPsKCAQ0W9LVNGWQkASaXWPPPezY= =6QUL -----END PGP SIGNATURE----- --oIpNLhWFfpgUQPV8aP7Fa2CDfPELD7oad--