From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yakir Yang Subject: Re: [PATCH v2 05/10] drm/rockchip: analogix_dp: add rk3399 eDP support Date: Wed, 25 May 2016 13:54:30 +0800 Message-ID: <57453E16.4060805@rock-chips.com> References: <1464066147-22734-1-git-send-email-ykk@rock-chips.com> <6183955.XzKjc41sjW@phil> <8988677.GHLC4rSfsM@phil> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <8988677.GHLC4rSfsM@phil> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Heiko Stuebner , Doug Anderson Cc: Krzysztof Kozlowski , linux-samsung-soc , Javier Martinez Canillas , Jingoo Han , Emil Velikov , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , Mark Yao , Rob Herring , Daniel Vetter , "open list:ARM/Rockchip SoC..." , Thierry Reding , Dan Carpenter List-Id: linux-rockchip.vger.kernel.org Ck9uIDA1LzI1LzIwMTYgMDI6MjMgQU0sIEhlaWtvIFN0dWVibmVyIHdyb3RlOgo+IEFtIERpZW5z dGFnLCAyNC4gTWFpIDIwMTYsIDExOjEyOjIwIHNjaHJpZWIgRG91ZyBBbmRlcnNvbjoKPj4gSGks Cj4+Cj4+IE9uIFR1ZSwgTWF5IDI0LCAyMDE2IGF0IDM6MTcgQU0sIEhlaWtvIFN0dWVibmVyIDxo ZWlrb0BzbnRlY2guZGU+IHdyb3RlOgo+Pj4+IC0tLSBhL0RvY3VtZW50YXRpb24vZGV2aWNldHJl ZS9iaW5kaW5ncy9kaXNwbGF5L2JyaWRnZS9hbmFsb2dpeF9kcC50eHQKPj4+PiArKysgYi9Eb2N1 bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvZGlzcGxheS9icmlkZ2UvYW5hbG9naXhfZHAu dHh0Cj4+Pj4KPj4+PiBAQCAtNSw2ICs1LDcgQEAgUmVxdWlyZWQgcHJvcGVydGllcyBmb3IgZHAt Y29udHJvbGxlcjoKPj4+PiAgICAgICAgICAgICAgICBwbGF0Zm9ybSBzcGVjaWZpYyBzdWNoIGFz Ogo+Pj4+ICAgICAgICAgICAgICAgICAqICJzYW1zdW5nLGV4eW5vczUtZHAiCj4+Pj4gICAgICAg ICAgICAgICAgICogInJvY2tjaGlwLHJrMzI4OC1kcCIKPj4+Pgo+Pj4+ICsgICAgICAgICAgICAg ICogInJvY2tjaGlwLHJrMzM5OS1lZHAiCj4+PiB0aGUgY2xlYW5saW5lcy1mcmVhayBpbiBteSBs aWtlcyB0byBrbm93IGlmIHRoZXJlIGlzIGEgZGlmZmVyZW5jZQo+Pj4gYmV0d2Vlbgo+Pj4gdGhl IHJrMzM5OSBiZWluZyBjYWxsZWQgLWVkcCBoZXJlIGFuZCAtZHAgb24gdGhlIHJrMzI4OCA6LSkK Pj4+Cj4+PiBbLi4uXQo+PiBJZiBJIHdhcyBhIGd1ZXNzaW5nIG1hbiAod2hpY2ggSSdtIG5vdCwg YnV0IGlmIEkgd2FzKSwgSSdkIGd1ZXNzIHRoYXQKPj4gdGhpcyBpcyBiZWNhdXNlIG9uIHJrMzI4 OCB0aGVyZSB3YXMgb25seSBvbmUgRFAgcG9ydCBhbmQgaXQgd2FzIGFuIEVEUAo+PiBwb3J0LiAg Li4uYnV0IHNpbmNlIHRoZXJlIHdhcyBvbmx5IG9uZSBwZW9wbGUganVzdCByZWZlcnJlZCB0byBp dCBhcwo+PiB0aGUgIkRQIiBwb3J0IGFuZCB0aGF0IHdhcyBjb2RpZmllZCBpbiB0aGUgYmluZGlu Z3MuICBPbiByazMzOTkgdGhlcmUKPj4gYXJlIHR3byBwb3J0czogb25lIEVEUCBhbmQgb25lIERQ LiAgQWxsIG9mIGEgc3VkZGVuIHdlIG5lZWQgdG8KPj4gZGlmZmVyZW50aWF0ZS4KPj4KPj4gQW55 IGJldHRlciBzdWdnZXN0aW9ucyBmb3IgaG93IHRvIGRlYWwgd2l0aCB0aGF0Pwo+IG5vcGUgLSBl dmVyeXRoaW5nIGFzIGl0IHNob3VsZCBiZSBpbiB0aGF0IHJlZ2FyZCB0aGVuIC0gdGhlIHJrMzI4 OC1kcCBpcwo+IHBlcm1hbmVudCBub3cgYW55d2F5Lgo+Cj4gQnV0IGl0IGxvb2tzIGxpa2UgSSdt IHNvcnQgb2YgYmxpbmQgYmxpbmQgYW5kIG9ubHkgbm93IGhhdmUgc2VlbiB0aGUKPiBzZXBhcmF0 ZSBEUCBjb250cm9sbGVyIGNoYXB0ZXIgaW4gdGhlIFRSTSAocHJvYmFibHkgYmVjYXVzZSBJIHNv bWVob3cgZGlkbid0Cj4gZXhwZWN0IGEgc2Vjb25kIGNvbnRyb2xsZXIpLgpSSzMzOTkgZURQIGNv bnRyb2xsZXIgaGF2ZSBjdXQgb2ZmIHRoZSBEUC1BdWRpbyBmdW5jdGlvbiBhbmQgRFAtSERDUCAK ZnVuY3Rpb24sIHNvIGl0IGNhbid0IGJlIHRyZWF0ZWQgYXMgRFAgaW50ZXJmYWNlcyBhbnkgbW9y ZSwgdGhhdCdzIHdoeSBJIApjYWxsIGl0ICJlRFAiLgo+Cj4KCgpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1k ZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv bWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932246AbcEYFyz (ORCPT ); Wed, 25 May 2016 01:54:55 -0400 Received: from lucky1.263xmail.com ([211.157.147.135]:58633 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932126AbcEYFyx (ORCPT ); Wed, 25 May 2016 01:54:53 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: ykk@rock-chips.com X-FST-TO: linux-rockchip@lists.infradead.org X-SENDER-IP: 103.29.142.67 X-LOGIN-NAME: ykk@rock-chips.com X-UNIQUE-TAG: <12e829238c76cabe8e032bf1c99a8d21> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH v2 05/10] drm/rockchip: analogix_dp: add rk3399 eDP support To: Heiko Stuebner , Doug Anderson References: <1464066147-22734-1-git-send-email-ykk@rock-chips.com> <6183955.XzKjc41sjW@phil> <8988677.GHLC4rSfsM@phil> Cc: David Airlie , Inki Dae , Mark Yao , Thierry Reding , Jingoo Han , Rob Herring , Krzysztof Kozlowski , Daniel Vetter , Javier Martinez Canillas , Emil Velikov , Dan Carpenter , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , linux-samsung-soc , "open list:ARM/Rockchip SoC..." From: Yakir Yang Message-ID: <57453E16.4060805@rock-chips.com> Date: Wed, 25 May 2016 13:54:30 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <8988677.GHLC4rSfsM@phil> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/25/2016 02:23 AM, Heiko Stuebner wrote: > Am Dienstag, 24. Mai 2016, 11:12:20 schrieb Doug Anderson: >> Hi, >> >> On Tue, May 24, 2016 at 3:17 AM, Heiko Stuebner wrote: >>>> --- a/Documentation/devicetree/bindings/display/bridge/analogix_dp.txt >>>> +++ b/Documentation/devicetree/bindings/display/bridge/analogix_dp.txt >>>> >>>> @@ -5,6 +5,7 @@ Required properties for dp-controller: >>>> platform specific such as: >>>> * "samsung,exynos5-dp" >>>> * "rockchip,rk3288-dp" >>>> >>>> + * "rockchip,rk3399-edp" >>> the cleanlines-freak in my likes to know if there is a difference >>> between >>> the rk3399 being called -edp here and -dp on the rk3288 :-) >>> >>> [...] >> If I was a guessing man (which I'm not, but if I was), I'd guess that >> this is because on rk3288 there was only one DP port and it was an EDP >> port. ...but since there was only one people just referred to it as >> the "DP" port and that was codified in the bindings. On rk3399 there >> are two ports: one EDP and one DP. All of a sudden we need to >> differentiate. >> >> Any better suggestions for how to deal with that? > nope - everything as it should be in that regard then - the rk3288-dp is > permanent now anyway. > > But it looks like I'm sort of blind blind and only now have seen the > separate DP controller chapter in the TRM (probably because I somehow didn't > expect a second controller). RK3399 eDP controller have cut off the DP-Audio function and DP-HDCP function, so it can't be treated as DP interfaces any more, that's why I call it "eDP". > >