From: Julien Grall <julien.grall@arm.com>
To: Wei Chen <wei.chen@linaro.org>, xen-devel@lists.xen.org
Cc: sstabellini@kernel.org, steve.capper@arm.com
Subject: Re: [PATCH 1/4] xen/arm: Change the variable type of cpu_logical_map to register_t
Date: Wed, 25 May 2016 14:52:47 +0100 [thread overview]
Message-ID: <5745AE2F.7020102@arm.com> (raw)
In-Reply-To: <1464142148-32678-1-git-send-email-Wei.Chen@linaro.org>
Hi Wei,
On 25/05/16 03:09, Wei Chen wrote:
> The cpu_logical_map is used to store CPU hardware ID from MPIDR_EL1 or
> from CPU node of DT. Currently, the cpu_logical_map is using the u32 as
> its variable type. It can work properly while Xen is running on ARM32,
> because the hardware ID is 32-bits. While Xen is running on ARM64, the
> hardware ID expands to 64-bits and then the cpu_logical_map will overflow.
>
> Change the the variable type of cpu_logical_map to register_t will make
NIT: s/the the/the/
> cpu_logical_map to store hardware ID correctly on ARM32 and ARM64.
s/ID/IDs/
>
> Signed-off-by: Wei Chen <Wei.Chen@linaro.org>
The code looks good to me. With the typos fixed:
Acked-by: Julien Grall <julien.grall@arm.com>
Regards,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
prev parent reply other threads:[~2016-05-25 13:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-25 2:09 [PATCH 1/4] xen/arm: Change the variable type of cpu_logical_map to register_t Wei Chen
2016-05-25 13:52 ` Julien Grall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5745AE2F.7020102@arm.com \
--to=julien.grall@arm.com \
--cc=sstabellini@kernel.org \
--cc=steve.capper@arm.com \
--cc=wei.chen@linaro.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.