All of lore.kernel.org
 help / color / mirror / Atom feed
From: York Sun <york.sun@nxp.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] driver/ddr/fsl: Add workaround for erratum A-010165
Date: Wed, 25 May 2016 09:51:30 -0700	[thread overview]
Message-ID: <5745D812.4000309@nxp.com> (raw)
In-Reply-To: <1462867427-34031-1-git-send-email-Shengzhou.Liu@nxp.com>

On 05/10/2016 01:13 AM, Shengzhou Liu wrote:
> During DDR-2133 operation, the transmit data eye margins determined
> during the memory controller initialization may be sub-optimal, set
> DEBUG_29[12] and DEBUG_29[13:16] = 4'b0100 before MEM_EN is set.
> 
> Signed-off-by: Shengzhou Liu <Shengzhou.Liu@nxp.com>
> ---
> v2: rebase
> 
>  arch/arm/include/asm/arch-fsl-layerscape/config.h |  1 +
>  drivers/ddr/fsl/fsl_ddr_gen4.c                    | 10 +++++++++-
>  2 files changed, 10 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/include/asm/arch-fsl-layerscape/config.h b/arch/arm/include/asm/arch-fsl-layerscape/config.h
> index 10d17b2..5b0b4ad 100644
> --- a/arch/arm/include/asm/arch-fsl-layerscape/config.h
> +++ b/arch/arm/include/asm/arch-fsl-layerscape/config.h
> @@ -136,6 +136,7 @@
>  #define CONFIG_SYS_FSL_ERRATUM_A009663
>  #define CONFIG_SYS_FSL_ERRATUM_A009803
>  #define CONFIG_SYS_FSL_ERRATUM_A009942
> +#define CONFIG_SYS_FSL_ERRATUM_A010165
>  
>  /* ARM A57 CORE ERRATA */
>  #define CONFIG_ARM_ERRATA_826974
> diff --git a/drivers/ddr/fsl/fsl_ddr_gen4.c b/drivers/ddr/fsl/fsl_ddr_gen4.c
> index 608810d..4a647b0 100644
> --- a/drivers/ddr/fsl/fsl_ddr_gen4.c
> +++ b/drivers/ddr/fsl/fsl_ddr_gen4.c
> @@ -56,7 +56,8 @@ void fsl_ddr_set_memctl_regs(const fsl_ddr_cfg_regs_t *regs,
>  	u32 vref_seq2[3] = {0xc0, 0xf0, 0x70};	/* for range 2 */
>  	u32 *vref_seq = vref_seq1;
>  #endif
> -#ifdef CONFIG_SYS_FSL_ERRATUM_A009942
> +#if defined(CONFIG_SYS_FSL_ERRATUM_A009942) | \
> +	defined(CONFIG_SYS_FSL_ERRATUM_A010165)

Shengzhou,

This "or" is also wrong. It should be "||".

York

      parent reply	other threads:[~2016-05-25 16:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-10  8:03 [U-Boot] [PATCH v2] driver/ddr/fsl: Add workaround for erratum A-010165 Shengzhou Liu
2016-05-24 17:19 ` York Sun
2016-05-25 16:51 ` York Sun [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5745D812.4000309@nxp.com \
    --to=york.sun@nxp.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.