From: Robert Foss <robert.foss@collabora.com>
To: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Fwd: Re: [RFC i-g-t 4/7] tools/Makefile: Don't build tools that depend on libdrm_intel.
Date: Wed, 25 May 2016 18:06:43 -0400 [thread overview]
Message-ID: <574621F3.5090907@collabora.com> (raw)
In-Reply-To: <2b8f-57460480-1-7d43af80@249225109>
> From: Robert Foss <robert.foss@collabora.com>
>
> Use the HAS_INTEL automake flag to avoid building tools that won't
> compile unless libdrm_intel is available in the build system.
>
> Signed-off-by: Robert Foss <robert.foss@collabora.com>
> ---
> tools/Android.mk | 8 ++++++++
> tools/Makefile.am | 8 ++++++++
> tools/Makefile.sources | 16 ++++++----------
> 3 files changed, 22 insertions(+), 10 deletions(-)
>
> diff --git a/tools/Android.mk b/tools/Android.mk
> index 5f64184..7c99432 100644
> --- a/tools/Android.mk
> +++ b/tools/Android.mk
> @@ -67,6 +67,14 @@ ifneq ("${ANDROID_HAS_CAIRO}", "1")
> skip_tools_list += intel_residency
> endif
>
> +ifeq ($(HAVE_LIBDRM_INTEL),true)
> + bin_PROGRAMS += $(LIBDRM_INTEL_BIN)
> +
> + intel_dump_decode_SOURCES = intel_dump_decode.c
> + intel_error_decode_SOURCES = intel_error_decode.c
Drop these two lines all together. The default extension for autoconf is
.c, thus just mentionoing the program name will automatically pick the
above sources respectively. On the Android build the function add_tool
(a few lines above) already does it for us.
> + intel_error_decode_LDFLAGS = -lz
Seems like I was wrong about this one... Android does use it (despite
that it looks a bit ugly). Thus one can keep it where it was.
-Emil
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
parent reply other threads:[~2016-05-25 22:06 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <2b8f-57460480-1-7d43af80@249225109>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=574621F3.5090907@collabora.com \
--to=robert.foss@collabora.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.