From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [PATCH v4 5/7] drm/omapdrm: Use drm_crtc_enable_color_mgmt() to enable gamma properties Date: Thu, 26 May 2016 09:33:18 +0300 Message-ID: <574698AE.2090203@ti.com> References: <36a2ba961f97c1a05daeea05a0b8dd63469fa628.1464207811.git.jsarha@ti.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0828506778==" Return-path: Received: from devils.ext.ti.com (devils.ext.ti.com [198.47.26.153]) by gabe.freedesktop.org (Postfix) with ESMTPS id 08AF96E224 for ; Thu, 26 May 2016 06:33:28 +0000 (UTC) In-Reply-To: <36a2ba961f97c1a05daeea05a0b8dd63469fa628.1464207811.git.jsarha@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jyri Sarha , dri-devel@lists.freedesktop.org Cc: peter.ujfalusi@ti.com, laurent.pinchart@ideasonboard.com List-Id: dri-devel@lists.freedesktop.org --===============0828506778== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="r9hxFejKGqJ7mssVV26nnjAgwvGpUpU9X" --r9hxFejKGqJ7mssVV26nnjAgwvGpUpU9X Content-Type: multipart/mixed; boundary="XatpRfetOG3c2TCLo64qJJjLjL5nkg5CS" From: Tomi Valkeinen To: Jyri Sarha , dri-devel@lists.freedesktop.org Cc: airlied@linux.ie, daniel@ffwll.ch, peter.ujfalusi@ti.com, bparrot@ti.com, laurent.pinchart@ideasonboard.com, lionel.g.landwerlin@intel.com Message-ID: <574698AE.2090203@ti.com> Subject: Re: [PATCH v4 5/7] drm/omapdrm: Use drm_crtc_enable_color_mgmt() to enable gamma properties References: <36a2ba961f97c1a05daeea05a0b8dd63469fa628.1464207811.git.jsarha@ti.com> In-Reply-To: <36a2ba961f97c1a05daeea05a0b8dd63469fa628.1464207811.git.jsarha@ti.com> --XatpRfetOG3c2TCLo64qJJjLjL5nkg5CS Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 25/05/16 23:43, Jyri Sarha wrote: > Use new drm_crtc_enable_color_mgmt() to enable gamma lut properties. You could move the color-mgmt patches to the beginning of the series, and add the omapdrm ones on top of those. > Signed-off-by: Jyri Sarha > --- > drivers/gpu/drm/omapdrm/omap_crtc.c | 12 +++--------- > 1 file changed, 3 insertions(+), 9 deletions(-) >=20 > diff --git a/drivers/gpu/drm/omapdrm/omap_crtc.c b/drivers/gpu/drm/omap= drm/omap_crtc.c > index 5b7f6f5..e03b349 100644 > --- a/drivers/gpu/drm/omapdrm/omap_crtc.c > +++ b/drivers/gpu/drm/omapdrm/omap_crtc.c > @@ -556,16 +556,10 @@ struct drm_crtc *omap_crtc_init(struct drm_device= *dev, > * gamma table is not supprted. > */ > if (dispc_mgr_gamma_size(channel)) { > - struct drm_mode_config *config =3D &dev->mode_config; > - uint gamma_size =3D 256; > + uint gamma_lut_size =3D 256; > =20 > - drm_mode_crtc_set_gamma_size(crtc, gamma_size); > - > - drm_object_attach_property(&crtc->base, > - config->gamma_lut_property, 0); > - drm_object_attach_property(&crtc->base, > - config->gamma_lut_size_property, > - gamma_size); > + drm_crtc_enable_color_mgmt(crtc, 0, false, gamma_lut_size); > + drm_mode_crtc_set_gamma_size(crtc, gamma_lut_size); Any reason drm_crtc_enable_color_mgmt() couldn't also call drm_mode_crtc_set_gamma_size()? Tomi --XatpRfetOG3c2TCLo64qJJjLjL5nkg5CS-- --r9hxFejKGqJ7mssVV26nnjAgwvGpUpU9X Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXRpiuAAoJEPo9qoy8lh71A8YP/Rt+JVbqoyZDgA0ohEW2pbJy bUTnmnW8GOPWTz7SQ0DuPnarRfYTNMSg9N6t+gp0E+eLBRfX8T0eUwUse/O5Fk1q dDIWyMNqYQ973lSBKP64BxYuvaRZqNHE/VdU+iLhQaBZNXtQ366Hpw+fnqrwNuNU 3qCGltduBsIsKODWgJsU27muu+P74xz7IufPzatb5hAy4+GpWAaorYFd40nw+Fmb 74taVsD4bPMrYXxjjBuicPZs7s6ZKiJol/ZsQbqupfMg4WFopwVZrWILGCJ7lx+u J9Uky6Dg7gif1WB3vid3Cyhx+9yHllEExOAuRcA/9yGptKuWveJL+j41HiJFBKPx jzylznb3RERC9OE5mCnvoEYR7WWls4qeUiC0vaEqKukV2o7v1CUobmDKXhxfgd1I Yi5hgsQjIIvd6+rFET6K+WAnU6g5Gu8xHYoo6JRqMwsa2pI7Pneb0xT8s6dRFOOB z2XnPClTJcSASN25E4vJEykc9O4G8Z8cfPFYF86Vr/oeMrkIbpVyx6fnmCjoHH7y SSU7hVwuEg1AVXWUDw2rkTy2MG3cL0AAeQxiQt88hKAUJqskDYsp1BP9UZ8VHLBP 38QW+vYgMSIPqE7iGFaqQ/yiA+HBb2OCks/lVDKVzGwuJad+IjOZ0ICnw+q9hbRd JwwCMZL5aKZYJV4Lu3WY =h151 -----END PGP SIGNATURE----- --r9hxFejKGqJ7mssVV26nnjAgwvGpUpU9X-- --===============0828506778== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0828506778==--