From: David Vrabel <david.vrabel@citrix.com>
To: Arnd Bergmann <arnd@arndb.de>, David Vrabel <david.vrabel@citrix.com>
Cc: Juergen Gross <jgross@suse.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Daniel Kiper <daniel.kiper@oracle.com>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
<linux-kernel@vger.kernel.org>, <stable@vger.kernel.org>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Julien Grall <julien.grall@citrix.com>,
Ross Lagerwall <ross.lagerwall@citrix.com>,
<xen-devel@lists.xenproject.org>,
"Boris Ostrovsky" <boris.ostrovsky@oracle.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [Xen-devel] [PATCH] xen: remove incorrect forward declaration
Date: Thu, 26 May 2016 11:32:40 +0100 [thread overview]
Message-ID: <5746D0C8.7000801@citrix.com> (raw)
In-Reply-To: <1462972075-918938-1-git-send-email-arnd@arndb.de>
On 11/05/16 14:07, Arnd Bergmann wrote:
> A bugfix patch for the xen balloon driver introduced a forward
> declaration for a static function that is conditionally compiled,
> causing a warning if only the declaration but not the definition
> are there:
>
> drivers/xen/balloon.c:154:13: error: 'release_memory_resource' declared 'static' but never defined [-Werror=unused-function]
> static void release_memory_resource(struct resource *resource);
>
> This removes the declaration again and instead moves the function
> definition to the right place, before its first caller and inside
> of the #ifdef protecting both.
I've applied the equivalent patch from Ross, instead.
> The patch that introduced the warning is marked for stable
> backports, so if that gets applied to 4.4, so should this one.
Fixes for compiler warnings are not sufficiently important to be
backported to stable.
David
next prev parent reply other threads:[~2016-05-26 10:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-11 13:07 [PATCH] xen: remove incorrect forward declaration Arnd Bergmann
2016-05-11 14:05 ` Juergen Gross
2016-05-11 15:19 ` Ross Lagerwall
2016-05-11 15:19 ` Ross Lagerwall
2016-05-11 14:05 ` Juergen Gross
2016-05-16 11:11 ` Stefano Stabellini
2016-05-16 11:11 ` Stefano Stabellini
2016-05-26 10:14 ` [Xen-devel] " Julien Grall
2016-05-26 10:18 ` Stefano Stabellini
2016-05-26 10:18 ` [Xen-devel] " Stefano Stabellini
2016-05-26 10:14 ` Julien Grall
2016-05-26 10:32 ` David Vrabel [this message]
2016-05-27 21:55 ` Arnd Bergmann
2016-05-27 21:55 ` [Xen-devel] " Arnd Bergmann
2016-05-26 10:32 ` David Vrabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5746D0C8.7000801@citrix.com \
--to=david.vrabel@citrix.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=boris.ostrovsky@oracle.com \
--cc=daniel.kiper@oracle.com \
--cc=jgross@suse.com \
--cc=julien.grall@citrix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=ross.lagerwall@citrix.com \
--cc=stable@vger.kernel.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=vkuznets@redhat.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.