From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [PATCH v5 0/4] drm/omapdrm: gamma table support + drm_crtc_enable_color_mgmt() Date: Thu, 26 May 2016 15:18:11 +0300 Message-ID: <5746E983.7040608@ti.com> References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1415202733==" Return-path: Received: from bear.ext.ti.com (bear.ext.ti.com [198.47.19.11]) by gabe.freedesktop.org (Postfix) with ESMTPS id B57AA6E266 for ; Thu, 26 May 2016 12:18:25 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter , Jyri Sarha Cc: Tomeu Vizoso , dri-devel , peter.ujfalusi@ti.com, Robert Foss , Laurent Pinchart List-Id: dri-devel@lists.freedesktop.org --===============1415202733== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="HHX16OUVkjK0com496171qkGPNqA1gRoV" --HHX16OUVkjK0com496171qkGPNqA1gRoV Content-Type: multipart/mixed; boundary="NCefdlh0trj97X7hKvpMQRgXJBn3pqRmB" From: Tomi Valkeinen To: Daniel Vetter , Jyri Sarha Cc: dri-devel , Dave Airlie , peter.ujfalusi@ti.com, bparrot@ti.com, Laurent Pinchart , Lionel G Landwerlin , Tomeu Vizoso , Robert Foss , Daniel Stone Message-ID: <5746E983.7040608@ti.com> Subject: Re: [PATCH v5 0/4] drm/omapdrm: gamma table support + drm_crtc_enable_color_mgmt() References: In-Reply-To: --NCefdlh0trj97X7hKvpMQRgXJBn3pqRmB Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 26/05/16 13:17, Daniel Vetter wrote: > On Thu, May 26, 2016 at 11:35:44AM +0300, Jyri Sarha wrote: >> Implements gamma tables for OMAP4, OMAP5, and dra7xx SoCs and adds a >> workaround for errata that may break LCD1 channel if gamma tables >> are in use. >> >> Also adds new drm_crtc_enable_color_mgmt() as suggested[1] by Daniel >> Vetter and get rid of the old drm_helper_crtc_enable_color_mgmt(). I >> have not tested the change to i915 driver, only compiled it, but >> functionally it should be exactly the same. >> >> [1] http://www.spinics.net/lists/dri-devel/msg108092.html >=20 > Btw for testing it would be awesome if you could take the color manager= > igt testcase we have, and make it generic. Probably needs some > adjustments like skip tests when not all properties which are needed ar= e > there. We should already auto-skip crc-based tests when that's not ther= e, > so hopefully not too much work. >=20 > This way we could start to have something like real validation tests fo= r > all these atomic extensions and make sure things do work across drivers= in > a uniform way. Tomeu and Robert have done this conversion work thus far= , > with Daniel leading the effort (all cc'ed). Lionel has done the color m= gmt > test. I agree. And I have on my todo to have a look again at igt. Last time I looked there were really no tests that could be ran on our platforms, and I didn't have time to look at it further. And for those interested, I added a simple py script to kmsxx for hacking with gamma: https://github.com/tomba/kmsxx/blob/master/py/gamma.py Tomi --NCefdlh0trj97X7hKvpMQRgXJBn3pqRmB-- --HHX16OUVkjK0com496171qkGPNqA1gRoV Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXRumDAAoJEPo9qoy8lh71Pi4P/iHeh9iLquYYX/g7T3Nd3Wrs ms4IxuWIqqXiOlKTOleRg1awfqyzDNZHJ+r2xsMln7UDNn1nZ30TheKliU/J4h6d jjoD4bgeXoj2lk/mW/7A5Hsbdu3eeFJhdb7uEpBImtvjKpnS6HxrD2J9ENh7FLyW ocAaZbBZ1XfXOTJd16896QNc3OZcyqP7mbMUfzR+AyjbSArChML13j/az7wIdVYy 0VnLETmAsZidW+gJqsc/EuxA8W/Oe+LjhEvGyqaTOOlULPf3vTAhin+utk+zo+cW a5yqxYhG3kwdYqyYnWX8kE1bGbpJ3j8p67YH1NQQunRahUzFB2bvbj6QjASrhXMA TnCltdUPjDvdQ+c8ztW+TgCzoIcpxRDfyMPRuhtt2OPhOvrKBDgpa6L7EavP/EWZ d0LLM9Joe4h8hSQrZeQop8DyZSb69V5lA2QpEe5v8hR8eL5SXCJh7moRuPq2shm2 RF5C2vD8mj5WEaMo1v/RnDXJrMP43zma/yR7wRxlLxGNjmwxMoEsX9BdEtAEc5hw 8G34hECPae60vFW0YdEC6paYl//8I2/rxeKiGsDGNrSv4v83yh5/sUJQSKbwvfsn gpv1EAWQbpXP6KcKgAAdKtNDXLjCCj578B2n5tJo6CuE6aTUnxkvwCtL1zdBTQmO sLM9muHeRPLm+bGGFQ/O =pcq0 -----END PGP SIGNATURE----- --HHX16OUVkjK0com496171qkGPNqA1gRoV-- --===============1415202733== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1415202733==--