From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jaehoon Chung Subject: Re: [RFC PATCH 1/2] mmc: dw_mmc: remove redundant of set_bit and clear_bit Date: Fri, 27 May 2016 09:53:18 +0900 Message-ID: <57479A7E.3050103@samsung.com> References: <1464232063-24841-1-git-send-email-shawn.lin@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: Received: from mailout4.samsung.com ([203.254.224.34]:56405 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755561AbcE0AxU (ORCPT ); Thu, 26 May 2016 20:53:20 -0400 In-reply-to: <1464232063-24841-1-git-send-email-shawn.lin@rock-chips.com> Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Shawn Lin , Ulf Hansson Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, Doug Anderson , linux-rockchip@lists.infradead.org Hi Shawn, On 05/26/2016 12:07 PM, Shawn Lin wrote: > dw_mci_get_cd have already dealed with these for > both of internal card-detect and gpio card-detect. s/dealed/dealt This patch looks good to me. Could you resend the patch? not RFC. Best Regards, Jaehoon Chung > > Signed-off-by: Shawn Lin > > --- > > drivers/mmc/host/dw_mmc.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c > index 829a6ee..cb30e91 100644 > --- a/drivers/mmc/host/dw_mmc.c > +++ b/drivers/mmc/host/dw_mmc.c > @@ -2616,10 +2616,7 @@ static int dw_mci_init_slot(struct dw_mci *host, unsigned int id) > mmc->max_seg_size = mmc->max_req_size; > } > > - if (dw_mci_get_cd(mmc)) > - set_bit(DW_MMC_CARD_PRESENT, &slot->flags); > - else > - clear_bit(DW_MMC_CARD_PRESENT, &slot->flags); > + dw_mci_get_cd(mmc); > > ret = mmc_add_host(mmc); > if (ret) >