From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Marius Vlad <marius.c.vlad@intel.com>,
intel-gfx@lists.freedesktop.org, joonas.lahtinen@linux.intel.com,
mika.kuoppala@linux.intel.com, daniel@ffwll.ch,
daniela.doras-prodan@intel.com
Subject: Re: [PATCH i-g-t 4/8] tests/gem_close_race: Tune down for BAT ~1s.
Date: Fri, 27 May 2016 13:31:10 +0100 [thread overview]
Message-ID: <57483E0E.7060904@linux.intel.com> (raw)
In-Reply-To: <20160527121606.GK31124@nuc-i3427.alporthouse.com>
On 27/05/16 13:16, Chris Wilson wrote:
> On Fri, May 27, 2016 at 01:10:07PM +0100, Tvrtko Ursulin wrote:
>>
>> On 27/05/16 12:58, Chris Wilson wrote:
>>> On Fri, May 27, 2016 at 02:50:34PM +0300, Marius Vlad wrote:
>>>> Signed-off-by: Marius Vlad <marius.c.vlad@intel.com>
>>>
>>> Nak. It's a race detector. Please suggest how to increase detection
>>> rates.
>>
>> As a more or less well know TV personality would say - "it's better
>> than nothing"! :))
>>
>> Seriously, under the new rules this is all we can do. Full
>> gem-close-race will (will it?) run in the nightly run so a little
>> bit more pain while bisecting breakages but those are the rules. We
>> can give them a go and see how it works out.
>
> Wrong approach. Right approach would be to add a new test that reliably
> detected a checklist of the most common races in under 1s. Nerfing a
> test to make it useless makes BAT equally useless.
>
> So we are giving up on BAT?
If it is not possible to stuff everything into the allocated budget, and
in cases where it may not be possible to come up with a 1s race
detector, it makes sense to move the test out of BAT and into the
nightly runs.
Agreement was that the time limits are hard limits so thats pretty much
it. We can do this now and hit the targets and them add more tests if
and when someone manages to implement them.
I don't have a problem with that, B in BAT stands for basic anyway.
We just adjust the model that when nightly test run fails someone from
QA gets tasked with bisection etc as a top priority.
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-05-27 12:31 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-27 11:50 [PATCH i-g-t 1/8] tests/gem_exec_flush: Tune down BAT timeout to ~1sec Marius Vlad
2016-05-27 11:50 ` [PATCH i-g-t 2/8] tests/gem_ctx_switch: Tune down for BAT ~1s Marius Vlad
2016-05-27 12:00 ` Chris Wilson
2016-05-27 11:50 ` [PATCH i-g-t 3/8] tests/gem_exec_nop: Tune down timeout " Marius Vlad
2016-05-27 12:06 ` Chris Wilson
2016-05-27 11:50 ` [PATCH i-g-t 4/8] tests/gem_close_race: Tune down " Marius Vlad
2016-05-27 11:58 ` Chris Wilson
2016-05-27 12:10 ` Tvrtko Ursulin
2016-05-27 12:16 ` Chris Wilson
2016-05-27 12:31 ` Tvrtko Ursulin [this message]
2016-05-27 12:44 ` Chris Wilson
2016-05-27 12:44 ` Mika Kuoppala
2016-05-27 14:28 ` Marius Vlad
2016-05-27 14:26 ` Marius Vlad
2016-05-27 14:25 ` Marius Vlad
2016-05-27 11:50 ` [PATCH i-g-t 5/8] tests/gem_sync: Tune down for BAT to ~1s for basic-each and ~2s for basic-all Marius Vlad
2016-05-27 11:59 ` Chris Wilson
2016-05-27 11:50 ` [PATCH i-g-t 6/8] tests/gem_exec_fault: Decrease the counts to lower the time for BAT Marius Vlad
2016-05-27 12:01 ` Chris Wilson
2016-05-27 11:50 ` [PATCH i-g-t 7/8] tests/gem_tiled_pread_basic: Rename test and BATify Marius Vlad
2016-05-27 12:03 ` Chris Wilson
2016-05-27 11:50 ` [PATCH i-g-t 8/8] tests/gem_exec_suspend: Remove hibernate test from BAT Marius Vlad
2016-05-27 12:00 ` Chris Wilson
2016-05-27 11:58 ` [PATCH i-g-t 1/8] tests/gem_exec_flush: Tune down BAT timeout to ~1sec Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57483E0E.7060904@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=daniel@ffwll.ch \
--cc=daniela.doras-prodan@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=joonas.lahtinen@linux.intel.com \
--cc=marius.c.vlad@intel.com \
--cc=mika.kuoppala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.