From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52905)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <serge.fdrv@gmail.com>) id 1b6JLz-00061i-Bx
	for qemu-devel@nongnu.org; Fri, 27 May 2016 11:07:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <serge.fdrv@gmail.com>) id 1b6JLu-0001i1-FN
	for qemu-devel@nongnu.org; Fri, 27 May 2016 11:07:10 -0400
Received: from mail-lf0-x244.google.com ([2a00:1450:4010:c07::244]:33999)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <serge.fdrv@gmail.com>) id 1b6JLu-0001hc-7c
	for qemu-devel@nongnu.org; Fri, 27 May 2016 11:07:06 -0400
Received: by mail-lf0-x244.google.com with SMTP id 65so8771619lfq.1
	for <qemu-devel@nongnu.org>; Fri, 27 May 2016 08:07:06 -0700 (PDT)
References: <1459870344-16773-1-git-send-email-alex.bennee@linaro.org>
	<1459870344-16773-12-git-send-email-alex.bennee@linaro.org>
	<57485238.1020406@gmail.com>
	<9ac0359b-6c90-4933-ccb9-9f4b6aadf5f9@redhat.com>
From: Sergey Fedorov <serge.fdrv@gmail.com>
Message-ID: <57486297.6070509@gmail.com>
Date: Fri, 27 May 2016 18:07:03 +0300
MIME-Version: 1.0
In-Reply-To: <9ac0359b-6c90-4933-ccb9-9f4b6aadf5f9@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC v2 11/11] tcg: enable thread-per-vCPU
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, =?UTF-8?Q?Alex_Benn=c3=a9e?= <alex.bennee@linaro.org>, mttcg@greensocs.com, fred.konrad@greensocs.com, a.rigo@virtualopensystems.com, cota@braap.org
Cc: qemu-devel@nongnu.org, mark.burton@greensocs.com, jan.kiszka@siemens.com, rth@twiddle.net, peter.maydell@linaro.org, claudio.fontana@huawei.com, Peter Crosthwaite <crosthwaite.peter@gmail.com>

On 27/05/16 17:55, Paolo Bonzini wrote:
>
> On 27/05/2016 15:57, Sergey Fedorov wrote:
>>  1. Make 'cpu->thread_kicked' access atomic
>>  2. Remove global 'exit_request' and use per-CPU 'exit_request'
>>  3. Change how 'current_cpu' is set
>>  4. Reorganize round-robin CPU TCG thread function
>>  5. Enable 'mmap_lock' for system mode emulation (do we really want this?)
> No, I don't think so.
>
>>  6. Enable 'tb_lock' for system mode emulation
>>  7. Introduce per-CPU TCG thread function
> At least 2/3/7 must be done at the same time, but I agree that this
> patch could use some splitting. :)

Hmm, 2/3 do also change single-threaded CPU loop. I think they should
apply separately from 7.

Thanks,
Sergey