From: "Matias Bjørling" <m@bjorling.me>
To: Dan Williams <dan.j.williams@gmail.com>
Cc: Jens Axboe <axboe@kernel.dk>,
Christoph Hellwig <hch@infradead.org>,
Keith Busch <keith.busch@intel.com>,
Simon Lund <slund@cnexlabs.com>,
linux-block@vger.kernel.org
Subject: Re: gendisk and lightnvm
Date: Fri, 27 May 2016 19:25:59 +0200 [thread overview]
Message-ID: <57488327.8080104@bjorling.me> (raw)
In-Reply-To: <CAA9_cmczkSBgLj5BwjVRVAq5b3SYGHbNSyu2qO1_TRguYRQ1pg@mail.gmail.com>
On 05/27/2016 12:06 AM, Dan Williams wrote:
> On Thu, May 26, 2016 at 2:50 PM, Matias Bjørling <m@bjorling.me> wrote:
>> On 05/26/2016 09:05 PM, Dan Williams wrote:
> [..]
>> In that case, the holder kobject is maintained by the request queue. That
>> moves the block device naming earlier in the initialization process, and the
>> request queue would properly need to hold the (struct gendisk)->diskname. I
>> wonder if there is a better way.
>
> I don't see why it is necessary to move the block device naming
> earlier. The block device kobject can link to the mq/ kobject created
> by lightnvm rather than include it as a child of the gendisk.
>
You're right. I'll cook up some RFC patches with the changes. Thanks.
prev parent reply other threads:[~2016-05-27 17:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-23 7:24 gendisk and lightnvm Matias Bjørling
2016-05-26 17:40 ` Dan Williams
2016-05-26 18:10 ` Matias Bjørling
2016-05-26 19:05 ` Dan Williams
2016-05-26 21:50 ` Matias Bjørling
2016-05-26 22:06 ` Dan Williams
2016-05-27 17:25 ` Matias Bjørling [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57488327.8080104@bjorling.me \
--to=m@bjorling.me \
--cc=axboe@kernel.dk \
--cc=dan.j.williams@gmail.com \
--cc=hch@infradead.org \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=slund@cnexlabs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.