From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vladimir Zapolskiy Subject: Re: [PATCH] crypto: s5p-sss - Use consistent indentation for variables and members Date: Sat, 28 May 2016 22:33:36 +0300 Message-ID: <5749F290.1010205@mleia.com> References: <1464349780-27674-1-git-send-email-k.kozlowski@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: Bartlomiej Zolnierkiewicz To: Krzysztof Kozlowski , Herbert Xu , davem@davemloft.net, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org Return-path: In-Reply-To: <1464349780-27674-1-git-send-email-k.kozlowski@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-crypto.vger.kernel.org Hi Krzysztof, On 27.05.2016 14:49, Krzysztof Kozlowski wrote: > Bring some consistency by: > 1. Replacing fixed-space indentation of structure members with just > tabs. > 2. Remove indentation in declaration of local variable between type and > name. Driver was mixing usage of such indentation and lack of it. > When removing indentation, reorder variables in > reversed-christmas-tree order with first variables being initialized > ones. > > Signed-off-by: Krzysztof Kozlowski it looks like a trivial and nice change, thank you. Acked-by: Vladimir Zapolskiy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751164AbcE1Tdm (ORCPT ); Sat, 28 May 2016 15:33:42 -0400 Received: from mleia.com ([178.79.152.223]:50808 "EHLO mail.mleia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750717AbcE1Tdl (ORCPT ); Sat, 28 May 2016 15:33:41 -0400 Subject: Re: [PATCH] crypto: s5p-sss - Use consistent indentation for variables and members To: Krzysztof Kozlowski , Herbert Xu , davem@davemloft.net, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org References: <1464349780-27674-1-git-send-email-k.kozlowski@samsung.com> Cc: Bartlomiej Zolnierkiewicz From: Vladimir Zapolskiy Message-ID: <5749F290.1010205@mleia.com> Date: Sat, 28 May 2016 22:33:36 +0300 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:38.0) Gecko/20100101 Icedove/38.5.0 MIME-Version: 1.0 In-Reply-To: <1464349780-27674-1-git-send-email-k.kozlowski@samsung.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-49551924 X-CRM114-CacheID: sfid-20160528_204042_105610_EA2CE60D X-CRM114-Status: UNSURE ( 9.83 ) X-CRM114-Notice: Please train this message. Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Krzysztof, On 27.05.2016 14:49, Krzysztof Kozlowski wrote: > Bring some consistency by: > 1. Replacing fixed-space indentation of structure members with just > tabs. > 2. Remove indentation in declaration of local variable between type and > name. Driver was mixing usage of such indentation and lack of it. > When removing indentation, reorder variables in > reversed-christmas-tree order with first variables being initialized > ones. > > Signed-off-by: Krzysztof Kozlowski it looks like a trivial and nice change, thank you. Acked-by: Vladimir Zapolskiy -- With best wishes, Vladimir