From: Jaehoon Chung <jh80.chung@samsung.com>
To: Shawn Lin <shawn.lin@rock-chips.com>,
Ulf Hansson <ulf.hansson@linaro.org>
Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
Doug Anderson <dianders@chromium.org>,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH v2 1/2] mmc: dw_mmc: remove redundant of set_bit and clear_bit
Date: Mon, 30 May 2016 08:18:20 +0900 [thread overview]
Message-ID: <574B78BC.10700@samsung.com> (raw)
In-Reply-To: <1464331000-16230-1-git-send-email-shawn.lin@rock-chips.com>
Hi Shawn,
Applied on my repository.
Thanks!
Best Regards,
Jaehoon Chung
On 05/27/2016 03:36 PM, Shawn Lin wrote:
> dw_mci_get_cd have already dealt with these for
> both of internal card-detect and gpio card-detect.
>
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
>
> ---
>
> Changes in v2: None
>
> drivers/mmc/host/dw_mmc.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
> index 829a6ee..cb30e91 100644
> --- a/drivers/mmc/host/dw_mmc.c
> +++ b/drivers/mmc/host/dw_mmc.c
> @@ -2616,10 +2616,7 @@ static int dw_mci_init_slot(struct dw_mci *host, unsigned int id)
> mmc->max_seg_size = mmc->max_req_size;
> }
>
> - if (dw_mci_get_cd(mmc))
> - set_bit(DW_MMC_CARD_PRESENT, &slot->flags);
> - else
> - clear_bit(DW_MMC_CARD_PRESENT, &slot->flags);
> + dw_mci_get_cd(mmc);
>
> ret = mmc_add_host(mmc);
> if (ret)
>
prev parent reply other threads:[~2016-05-29 23:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20160527063715epcas1p1584a3a6340d55ca1d912dc93f2d89bab@epcas1p1.samsung.com>
2016-05-27 6:36 ` [PATCH v2 1/2] mmc: dw_mmc: remove redundant of set_bit and clear_bit Shawn Lin
2016-05-29 23:18 ` Jaehoon Chung [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=574B78BC.10700@samsung.com \
--to=jh80.chung@samsung.com \
--cc=dianders@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=shawn.lin@rock-chips.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.