From: Laxman Dewangan <ldewangan@nvidia.com>
To: Axel Lin <axel.lin@ingics.com>, Mark Brown <broonie@kernel.org>
Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Mikko Perttunen <mperttunen@nvidia.com>,
Liam Girdwood <lgirdwood@gmail.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [RFT][PATCH v2] regulator: max8973: Fix setting ramp delay
Date: Mon, 30 May 2016 15:58:24 +0530 [thread overview]
Message-ID: <574C15C8.7050008@nvidia.com> (raw)
In-Reply-To: <1464599360.12124.0.camel@ingics.com>
On Monday 30 May 2016 02:39 PM, Axel Lin wrote:
> Current code for .set_ramp_delay() rounds down the value written to
> register, while the implementation of .set_voltage_time_sel() works on
> original constraints (not rounded down).
> Fix the logic in .set_ramp_delay and also remove unused ret_val variable.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
>
Reviewed-by: Laxman Dewangan <ldewangan@nvidia.com>
prev parent reply other threads:[~2016-05-30 10:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-30 9:09 [RFT][PATCH v2] regulator: max8973: Fix setting ramp delay Axel Lin
2016-05-30 9:22 ` Krzysztof Kozlowski
2016-05-30 10:28 ` Laxman Dewangan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=574C15C8.7050008@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=axel.lin@ingics.com \
--cc=broonie@kernel.org \
--cc=k.kozlowski@samsung.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mperttunen@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.