From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161396AbcE3OMA (ORCPT ); Mon, 30 May 2016 10:12:00 -0400 Received: from lists.s-osg.org ([54.187.51.154]:44288 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161301AbcE3OL6 (ORCPT ); Mon, 30 May 2016 10:11:58 -0400 Message-ID: <574C4A29.5020906@osg.samsung.com> Date: Mon, 30 May 2016 15:11:53 +0100 From: Luis de Bethencourt User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.8.0 MIME-Version: 1.0 To: Ravishankar Karkala Mallikarjunayya , abbotti@mev.co.uk, hsweeten@visionengravers.com, gregkh@linuxfoundation.org CC: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/4] Staging: comedi: Fix WARNING issue in s626.c References: <1464413211-7947-1-git-send-email-ravishankarkm32@gmail.com> <1464413211-7947-2-git-send-email-ravishankarkm32@gmail.com> In-Reply-To: <1464413211-7947-2-git-send-email-ravishankarkm32@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28/05/16 06:26, Ravishankar Karkala Mallikarjunayya wrote: > This is a patch to the s626.c file that fixes up a Block comments > issues found by the checkpatch.pl tool. > > i.e. Block comments use a trailing */ on a separate line > > Signed-off-by: Ravishankar Karkala Mallikarjunayya We can see in the diff this is making changes in s626.c :) no need to mention that in the commit message. Not sure moving the opening and closing of comments (/* and */) to a new line makes things more readable. checkpatch is a great tool but it gives suggestions, not hard rules. Just a comment since I've seen multiple people follow checkpatch blindly, and it is best to use your discretion. Maintainer of this code will probably have a preference. Thank you for your patches Ravishankar. Luis