From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755039AbcE3OPJ (ORCPT ); Mon, 30 May 2016 10:15:09 -0400 Received: from lists.s-osg.org ([54.187.51.154]:44306 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754815AbcE3OPH (ORCPT ); Mon, 30 May 2016 10:15:07 -0400 Message-ID: <574C4AE6.2010804@osg.samsung.com> Date: Mon, 30 May 2016 15:15:02 +0100 From: Luis de Bethencourt User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.8.0 MIME-Version: 1.0 To: Ravishankar Karkala Mallikarjunayya , abbotti@mev.co.uk, hsweeten@visionengravers.com, gregkh@linuxfoundation.org CC: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/4] Staging: comedi:Fix unsigned int to bare use of unsigned issue in s626.c References: <1464413211-7947-1-git-send-email-ravishankarkm32@gmail.com> <1464413211-7947-3-git-send-email-ravishankarkm32@gmail.com> In-Reply-To: <1464413211-7947-3-git-send-email-ravishankarkm32@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28/05/16 06:26, Ravishankar Karkala Mallikarjunayya wrote: > This is a patch to the s626.c file that fixes up a > WARNING: Prefer 'unsigned int' to bare use of 'unsigned' > found by the checkpatch.pl tool > > Signed-off-by: Ravishankar Karkala Mallikarjunayya The patch looks good :) adding the int makes it more verbose. Just the same comment as the previous patch, we can see in the diff which file is affected by this. You can just say: "This fixes a WARNING: Prefer 'unsigned int' ..." Thanks, Luis