From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751005AbcEaK3c (ORCPT ); Tue, 31 May 2016 06:29:32 -0400 Received: from smtp145.dfw.emailsrvr.com ([67.192.241.145]:37226 "EHLO smtp145.dfw.emailsrvr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750740AbcEaK3a (ORCPT ); Tue, 31 May 2016 06:29:30 -0400 X-Auth-ID: abbotti@mev.co.uk X-Sender-Id: abbotti@mev.co.uk Subject: Re: [PATCH v2 1/4] staging : comedi : fix type issues in s626.c To: Ravishankar Karkala Mallikarjunayya , hsweeten@visionengravers.com, gregkh@linuxfoundation.org References: <1464413211-7947-1-git-send-email-ravishankarkm32@gmail.com> Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org From: Ian Abbott Message-ID: <574D6786.6040500@mev.co.uk> Date: Tue, 31 May 2016 11:29:26 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.6.0 MIME-Version: 1.0 In-Reply-To: <1464413211-7947-1-git-send-email-ravishankarkm32@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28/05/16 06:26, Ravishankar Karkala Mallikarjunayya wrote: > This is a patch to the s626.c file that fixes up a type issues like > i.e Prefer kernel type 'u8' over 'uint8_t' > Prefer kernel type 'u16' over 'uint16_t' > Prefer kernel type 'u32' over 'uint32_t' > Prefer kernel type 's16' over 'int16_t' > Prefer kernel type 's32' over 'int32_t' > found by the checkpatch.pl tool. > > Signed-off-by: Ravishankar Karkala Mallikarjunayya > --- > changes since v1: Rework > --- > drivers/staging/comedi/drivers/s626.c | 212 +++++++++++++++++----------------- > 1 file changed, 106 insertions(+), 106 deletions(-) > Thanks. It would have been nice if the checkpatch.pl tool detected _all_ the instances of these types. As a result of this patch, s626.c contains a mixture of the different integer type styles. I guess we can fix that up later though. Reviewed-by: Ian Abbott -- -=( Ian Abbott @ MEV Ltd. E-mail: )=- -=( Web: http://www.mev.co.uk/ )=-