From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============4465577580490044223==" MIME-Version: 1.0 From: Hanjun Guo Subject: Re: [Devel] [PATCH v7 07/15] arm64, numa: Cleanup NUMA disabled messages. Date: Tue, 31 May 2016 12:28:51 +0000 Message-ID: <574D836A.2090905@linaro.org> In-Reply-To: 1464129345-18985-8-git-send-email-ddaney.cavm@gmail.com List-ID: To: devel@acpica.org --===============4465577580490044223== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On 2016/5/25 6:35, David Daney wrote: > From: David Daney > > As noted by Dennis Chen, we don't want to print "No NUMA configuration > found" if NUMA was forced off from the command line. > > Change the type of numa_off to bool, and clean up printing code. > Print "NUMA disabled" if forced off on command line and "No NUMA > configuration found" if there was no firmware NUMA information. > > Signed-off-by: David Daney > Acked-by: Catalin Marinas > --- > arch/arm64/mm/numa.c | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/mm/numa.c b/arch/arm64/mm/numa.c > index 6cb03f9..1def1de 100644 > --- a/arch/arm64/mm/numa.c > +++ b/arch/arm64/mm/numa.c > @@ -29,7 +29,7 @@ static int cpu_to_node_map[NR_CPUS] =3D { [0 ... NR_CPU= S-1] =3D NUMA_NO_NODE }; > > static int numa_distance_cnt; > static u8 *numa_distance; > -static int numa_off; > +static bool numa_off; > > static __init int numa_parse_early_param(char *opt) > { > @@ -37,7 +37,7 @@ static __init int numa_parse_early_param(char *opt) > return -EINVAL; > if (!strncmp(opt, "off", 3)) { > pr_info("%s\n", "NUMA turned off"); > - numa_off =3D 1; > + numa_off =3D true; > } > return 0; > } > @@ -362,7 +362,10 @@ static int __init dummy_numa_init(void) > int ret; > struct memblock_region *mblk; > > - pr_info("%s\n", "No NUMA configuration found"); > + if (numa_off) > + pr_info("NUMA disabled\n"); /* Forced off on command line. */ > + else > + pr_info("No NUMA configuration found\n"); > pr_info("NUMA: Faking a node at [mem %#018Lx-%#018Lx]\n", > 0LLU, PFN_PHYS(max_pfn) - 1); > > @@ -375,7 +378,7 @@ static int __init dummy_numa_init(void) > return ret; > } > > - numa_off =3D 1; > + numa_off =3D true; > return 0; > } Reviewed-by: Hanjun Guo > > --===============4465577580490044223==-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hanjun Guo Subject: Re: [PATCH v7 07/15] arm64, numa: Cleanup NUMA disabled messages. Date: Tue, 31 May 2016 20:28:26 +0800 Message-ID: <574D836A.2090905@linaro.org> References: <1464129345-18985-1-git-send-email-ddaney.cavm@gmail.com> <1464129345-18985-8-git-send-email-ddaney.cavm@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1464129345-18985-8-git-send-email-ddaney.cavm@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: David Daney , Will Deacon , linux-arm-kernel@lists.infradead.org, Mark Rutland , Catalin Marinas , Tony Luck , Fenghua Yu , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, "Rafael J. Wysocki" , Len Brown , Rob Herring , Frank Rowand , Grant Likely , Robert Moore , Lv Zheng , Marc Zyngier , linux-ia64@vger.kernel.org, linux-acpi@vger.kernel.org, devel@acpica.org Cc: linux-kernel@vger.kernel.org, Robert Richter , David Daney List-Id: linux-acpi@vger.kernel.org On 2016/5/25 6:35, David Daney wrote: > From: David Daney > > As noted by Dennis Chen, we don't want to print "No NUMA configuration > found" if NUMA was forced off from the command line. > > Change the type of numa_off to bool, and clean up printing code. > Print "NUMA disabled" if forced off on command line and "No NUMA > configuration found" if there was no firmware NUMA information. > > Signed-off-by: David Daney > Acked-by: Catalin Marinas > --- > arch/arm64/mm/numa.c | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/mm/numa.c b/arch/arm64/mm/numa.c > index 6cb03f9..1def1de 100644 > --- a/arch/arm64/mm/numa.c > +++ b/arch/arm64/mm/numa.c > @@ -29,7 +29,7 @@ static int cpu_to_node_map[NR_CPUS] = { [0 ... NR_CPUS-1] = NUMA_NO_NODE }; > > static int numa_distance_cnt; > static u8 *numa_distance; > -static int numa_off; > +static bool numa_off; > > static __init int numa_parse_early_param(char *opt) > { > @@ -37,7 +37,7 @@ static __init int numa_parse_early_param(char *opt) > return -EINVAL; > if (!strncmp(opt, "off", 3)) { > pr_info("%s\n", "NUMA turned off"); > - numa_off = 1; > + numa_off = true; > } > return 0; > } > @@ -362,7 +362,10 @@ static int __init dummy_numa_init(void) > int ret; > struct memblock_region *mblk; > > - pr_info("%s\n", "No NUMA configuration found"); > + if (numa_off) > + pr_info("NUMA disabled\n"); /* Forced off on command line. */ > + else > + pr_info("No NUMA configuration found\n"); > pr_info("NUMA: Faking a node at [mem %#018Lx-%#018Lx]\n", > 0LLU, PFN_PHYS(max_pfn) - 1); > > @@ -375,7 +378,7 @@ static int __init dummy_numa_init(void) > return ret; > } > > - numa_off = 1; > + numa_off = true; > return 0; > } Reviewed-by: Hanjun Guo > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hanjun Guo Date: Tue, 31 May 2016 12:28:26 +0000 Subject: Re: [PATCH v7 07/15] arm64, numa: Cleanup NUMA disabled messages. Message-Id: <574D836A.2090905@linaro.org> List-Id: References: <1464129345-18985-1-git-send-email-ddaney.cavm@gmail.com> <1464129345-18985-8-git-send-email-ddaney.cavm@gmail.com> In-Reply-To: <1464129345-18985-8-git-send-email-ddaney.cavm@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: David Daney , Will Deacon , linux-arm-kernel@lists.infradead.org, Mark Rutland , Catalin Marinas , Tony Luck , Fenghua Yu , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, "Rafael J. Wysocki" , Len Brown , Rob Herring , Frank Rowand , Grant Likely , Robert Moore , Lv Zheng , Marc Zyngier , linux-ia64@vger.kernel.org, linux-acpi@vger.kernel.org, devel@acpica.org Cc: linux-kernel@vger.kernel.org, Robert Richter , David Daney On 2016/5/25 6:35, David Daney wrote: > From: David Daney > > As noted by Dennis Chen, we don't want to print "No NUMA configuration > found" if NUMA was forced off from the command line. > > Change the type of numa_off to bool, and clean up printing code. > Print "NUMA disabled" if forced off on command line and "No NUMA > configuration found" if there was no firmware NUMA information. > > Signed-off-by: David Daney > Acked-by: Catalin Marinas > --- > arch/arm64/mm/numa.c | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/mm/numa.c b/arch/arm64/mm/numa.c > index 6cb03f9..1def1de 100644 > --- a/arch/arm64/mm/numa.c > +++ b/arch/arm64/mm/numa.c > @@ -29,7 +29,7 @@ static int cpu_to_node_map[NR_CPUS] = { [0 ... NR_CPUS-1] = NUMA_NO_NODE }; > > static int numa_distance_cnt; > static u8 *numa_distance; > -static int numa_off; > +static bool numa_off; > > static __init int numa_parse_early_param(char *opt) > { > @@ -37,7 +37,7 @@ static __init int numa_parse_early_param(char *opt) > return -EINVAL; > if (!strncmp(opt, "off", 3)) { > pr_info("%s\n", "NUMA turned off"); > - numa_off = 1; > + numa_off = true; > } > return 0; > } > @@ -362,7 +362,10 @@ static int __init dummy_numa_init(void) > int ret; > struct memblock_region *mblk; > > - pr_info("%s\n", "No NUMA configuration found"); > + if (numa_off) > + pr_info("NUMA disabled\n"); /* Forced off on command line. */ > + else > + pr_info("No NUMA configuration found\n"); > pr_info("NUMA: Faking a node at [mem %#018Lx-%#018Lx]\n", > 0LLU, PFN_PHYS(max_pfn) - 1); > > @@ -375,7 +378,7 @@ static int __init dummy_numa_init(void) > return ret; > } > > - numa_off = 1; > + numa_off = true; > return 0; > } Reviewed-by: Hanjun Guo > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: hanjun.guo@linaro.org (Hanjun Guo) Date: Tue, 31 May 2016 20:28:26 +0800 Subject: [PATCH v7 07/15] arm64, numa: Cleanup NUMA disabled messages. In-Reply-To: <1464129345-18985-8-git-send-email-ddaney.cavm@gmail.com> References: <1464129345-18985-1-git-send-email-ddaney.cavm@gmail.com> <1464129345-18985-8-git-send-email-ddaney.cavm@gmail.com> Message-ID: <574D836A.2090905@linaro.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2016/5/25 6:35, David Daney wrote: > From: David Daney > > As noted by Dennis Chen, we don't want to print "No NUMA configuration > found" if NUMA was forced off from the command line. > > Change the type of numa_off to bool, and clean up printing code. > Print "NUMA disabled" if forced off on command line and "No NUMA > configuration found" if there was no firmware NUMA information. > > Signed-off-by: David Daney > Acked-by: Catalin Marinas > --- > arch/arm64/mm/numa.c | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/mm/numa.c b/arch/arm64/mm/numa.c > index 6cb03f9..1def1de 100644 > --- a/arch/arm64/mm/numa.c > +++ b/arch/arm64/mm/numa.c > @@ -29,7 +29,7 @@ static int cpu_to_node_map[NR_CPUS] = { [0 ... NR_CPUS-1] = NUMA_NO_NODE }; > > static int numa_distance_cnt; > static u8 *numa_distance; > -static int numa_off; > +static bool numa_off; > > static __init int numa_parse_early_param(char *opt) > { > @@ -37,7 +37,7 @@ static __init int numa_parse_early_param(char *opt) > return -EINVAL; > if (!strncmp(opt, "off", 3)) { > pr_info("%s\n", "NUMA turned off"); > - numa_off = 1; > + numa_off = true; > } > return 0; > } > @@ -362,7 +362,10 @@ static int __init dummy_numa_init(void) > int ret; > struct memblock_region *mblk; > > - pr_info("%s\n", "No NUMA configuration found"); > + if (numa_off) > + pr_info("NUMA disabled\n"); /* Forced off on command line. */ > + else > + pr_info("No NUMA configuration found\n"); > pr_info("NUMA: Faking a node at [mem %#018Lx-%#018Lx]\n", > 0LLU, PFN_PHYS(max_pfn) - 1); > > @@ -375,7 +378,7 @@ static int __init dummy_numa_init(void) > return ret; > } > > - numa_off = 1; > + numa_off = true; > return 0; > } Reviewed-by: Hanjun Guo > >