From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Huang, Tao" Subject: Re: [PATCH 3/5] clocksource: rockchip: add dynamic irq flag to the timer Date: Tue, 31 May 2016 21:45:51 +0800 Message-ID: <574D958F.9010707@rock-chips.com> References: <1464169802-6033-1-git-send-email-wxt@rock-chips.com> <1464169802-6033-4-git-send-email-wxt@rock-chips.com> <574CC9DE.1050501@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <574CC9DE.1050501-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Daniel Lezcano , Caesar Wang , Heiko Stuebner Cc: dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, smbarber-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, cf-TNX95d0MmH7DzftRWevZcw@public.gmane.org, briannorris-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, Thomas Gleixner , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: linux-rockchip.vger.kernel.org SGkgRGFuaWVsOgpPbiAyMDE25bm0MDXmnIgzMeaXpSAwNzoxNiwgRGFuaWVsIExlemNhbm8gd3Jv dGU6Cj4gT24gMDUvMjUvMjAxNiAxMTo1MCBBTSwgQ2Flc2FyIFdhbmcgd3JvdGU6Cj4+IEZyb206 IEh1YW5nIFRhbyA8aHVhbmd0YW9Acm9jay1jaGlwcy5jb20+Cj4+Cj4+IFRoZSByb2NrY2hpcCB0 aW1lciBpcyBicm9hZGNhc3QgdGltZXIuIEFkZCBDTE9DS19FVlRfRkVBVF9EWU5JUlEKPj4gZmxh ZyBhbmQgc2V0IGNwdW1hc2sgdG8gYWxsIGNwdSB0byBzYXZlIHBvd2VyIGJ5IGF2b2lkIHVubmVj ZXNzYXJ5Cj4+IHdha2V1cHMgYW5kIElQSXMuCj4+Cj4+IFNpZ25lZC1vZmYtYnk6IEh1YW5nIFRh byA8aHVhbmd0YW9Acm9jay1jaGlwcy5jb20+Cj4+IENjOiBEYW5pZWwgTGV6Y2FubyA8ZGFuaWVs LmxlemNhbm9AbGluYXJvLm9yZz4KPj4gQ2M6IFRob21hcyBHbGVpeG5lciA8dGdseEBsaW51dHJv bml4LmRlPgo+PiBDYzogSGVpa28gU3R1ZWJuZXIgPGhlaWtvQHNudGVjaC5kZT4KPj4gVGVzdGVk LWJ5OiBKaWFucXVuIFh1IDxqYXkueHVAcm9jay1jaGlwcy5jb20+Cj4+IFNpZ25lZC1vZmYtYnk6 IENhZXNhciBXYW5nIDx3eHRAcm9jay1jaGlwcy5jb20+Cj4+IC0tLQo+Pgo+PiAgIGRyaXZlcnMv Y2xvY2tzb3VyY2Uvcm9ja2NoaXBfdGltZXIuYyB8IDUgKysrLS0KPj4gICAxIGZpbGUgY2hhbmdl ZCwgMyBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQo+Pgo+PiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9jbG9ja3NvdXJjZS9yb2NrY2hpcF90aW1lci5jIGIvZHJpdmVycy9jbG9ja3NvdXJjZS9y b2NrY2hpcF90aW1lci5jCj4+IGluZGV4IGI5M2ZlZDYuLmYzZGZiMWEgMTAwNjQ0Cj4+IC0tLSBh L2RyaXZlcnMvY2xvY2tzb3VyY2Uvcm9ja2NoaXBfdGltZXIuYwo+PiArKysgYi9kcml2ZXJzL2Ns b2Nrc291cmNlL3JvY2tjaGlwX3RpbWVyLmMKPj4gQEAgLTE1MCwxMiArMTUwLDEzIEBAIHN0YXRp YyB2b2lkIF9faW5pdCBya190aW1lcl9pbml0KHN0cnVjdCBkZXZpY2Vfbm9kZSAqbnApCj4+ICAg CX0KPj4KPj4gICAJY2UtPm5hbWUgPSBUSU1FUl9OQU1FOwo+PiAtCWNlLT5mZWF0dXJlcyA9IENM T0NLX0VWVF9GRUFUX1BFUklPRElDIHwgQ0xPQ0tfRVZUX0ZFQVRfT05FU0hPVDsKPj4gKwljZS0+ ZmVhdHVyZXMgPSBDTE9DS19FVlRfRkVBVF9QRVJJT0RJQyB8IENMT0NLX0VWVF9GRUFUX09ORVNI T1QgfAo+PiArCQkgICAgICAgQ0xPQ0tfRVZUX0ZFQVRfRFlOSVJROwo+PiAgIAljZS0+c2V0X25l eHRfZXZlbnQgPSBya190aW1lcl9zZXRfbmV4dF9ldmVudDsKPj4gICAJY2UtPnNldF9zdGF0ZV9z aHV0ZG93biA9IHJrX3RpbWVyX3NodXRkb3duOwo+PiAgIAljZS0+c2V0X3N0YXRlX3BlcmlvZGlj ID0gcmtfdGltZXJfc2V0X3BlcmlvZGljOwo+PiAgIAljZS0+aXJxID0gaXJxOwo+PiAtCWNlLT5j cHVtYXNrID0gY3B1bWFza19vZigwKTsKPj4gKwljZS0+Y3B1bWFzayA9IGNwdV9hbGxfbWFzazsK PiAKPiBzL2NwdV9hbGxfbWFzay9jcHVfcG9zc2libGVfbWFzay8KCk9rYXkgZm9yIG1lLgpJdCBz ZWVtcyBkcml2ZXJzIGluIGRyaXZlcnMvY2xvY2tzb3VyY2UgYXJlIHZlcnkgY29uZnVzaW5nIGFi b3V0IHVzZQpjcHVfYWxsX21hc2sgb3IgY3B1X3Bvc3NpYmxlX21hc2suIEZvciBleGFtcGxlIGFy bV9hcmNoX3RpbWVyLmMgdXNlCmNwdV9hbGxfbWFzaywgd2hpbGUgbXRrX3RpbWVyLmMgdXNlIGNw dV9wb3NzaWJsZV9tYXNrLiBJIHRoaW5rIGFsbCBqdXN0CndvcmsuCgpUaGFua3MsCkh1YW5nLCBU YW8KCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51 eC1yb2NrY2hpcCBtYWlsaW5nIGxpc3QKTGludXgtcm9ja2NoaXBAbGlzdHMuaW5mcmFkZWFkLm9y ZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXJvY2tj aGlwCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: huangtao@rock-chips.com (Huang, Tao) Date: Tue, 31 May 2016 21:45:51 +0800 Subject: [PATCH 3/5] clocksource: rockchip: add dynamic irq flag to the timer In-Reply-To: <574CC9DE.1050501@linaro.org> References: <1464169802-6033-1-git-send-email-wxt@rock-chips.com> <1464169802-6033-4-git-send-email-wxt@rock-chips.com> <574CC9DE.1050501@linaro.org> Message-ID: <574D958F.9010707@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Daniel: On 2016?05?31? 07:16, Daniel Lezcano wrote: > On 05/25/2016 11:50 AM, Caesar Wang wrote: >> From: Huang Tao >> >> The rockchip timer is broadcast timer. Add CLOCK_EVT_FEAT_DYNIRQ >> flag and set cpumask to all cpu to save power by avoid unnecessary >> wakeups and IPIs. >> >> Signed-off-by: Huang Tao >> Cc: Daniel Lezcano >> Cc: Thomas Gleixner >> Cc: Heiko Stuebner >> Tested-by: Jianqun Xu >> Signed-off-by: Caesar Wang >> --- >> >> drivers/clocksource/rockchip_timer.c | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/clocksource/rockchip_timer.c b/drivers/clocksource/rockchip_timer.c >> index b93fed6..f3dfb1a 100644 >> --- a/drivers/clocksource/rockchip_timer.c >> +++ b/drivers/clocksource/rockchip_timer.c >> @@ -150,12 +150,13 @@ static void __init rk_timer_init(struct device_node *np) >> } >> >> ce->name = TIMER_NAME; >> - ce->features = CLOCK_EVT_FEAT_PERIODIC | CLOCK_EVT_FEAT_ONESHOT; >> + ce->features = CLOCK_EVT_FEAT_PERIODIC | CLOCK_EVT_FEAT_ONESHOT | >> + CLOCK_EVT_FEAT_DYNIRQ; >> ce->set_next_event = rk_timer_set_next_event; >> ce->set_state_shutdown = rk_timer_shutdown; >> ce->set_state_periodic = rk_timer_set_periodic; >> ce->irq = irq; >> - ce->cpumask = cpumask_of(0); >> + ce->cpumask = cpu_all_mask; > > s/cpu_all_mask/cpu_possible_mask/ Okay for me. It seems drivers in drivers/clocksource are very confusing about use cpu_all_mask or cpu_possible_mask. For example arm_arch_timer.c use cpu_all_mask, while mtk_timer.c use cpu_possible_mask. I think all just work. Thanks, Huang, Tao From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754433AbcEaNwV (ORCPT ); Tue, 31 May 2016 09:52:21 -0400 Received: from regular1.263xmail.com ([211.150.99.132]:45228 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754101AbcEaNwQ (ORCPT ); Tue, 31 May 2016 09:52:16 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: huangtao@rock-chips.com X-FST-TO: huangtao@rock-chips.com X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: huangtao@rock-chips.com X-UNIQUE-TAG: <16924e80f0f54b10b55489795a3069af> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH 3/5] clocksource: rockchip: add dynamic irq flag to the timer To: Daniel Lezcano , Caesar Wang , Heiko Stuebner References: <1464169802-6033-1-git-send-email-wxt@rock-chips.com> <1464169802-6033-4-git-send-email-wxt@rock-chips.com> <574CC9DE.1050501@linaro.org> Cc: dianders@chromium.org, briannorris@google.com, smbarber@google.com, linux-rockchip@lists.infradead.org, Thomas Gleixner , cf@rock-chips.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org From: "Huang, Tao" Message-ID: <574D958F.9010707@rock-chips.com> Date: Tue, 31 May 2016 21:45:51 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <574CC9DE.1050501@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Daniel: On 2016年05月31日 07:16, Daniel Lezcano wrote: > On 05/25/2016 11:50 AM, Caesar Wang wrote: >> From: Huang Tao >> >> The rockchip timer is broadcast timer. Add CLOCK_EVT_FEAT_DYNIRQ >> flag and set cpumask to all cpu to save power by avoid unnecessary >> wakeups and IPIs. >> >> Signed-off-by: Huang Tao >> Cc: Daniel Lezcano >> Cc: Thomas Gleixner >> Cc: Heiko Stuebner >> Tested-by: Jianqun Xu >> Signed-off-by: Caesar Wang >> --- >> >> drivers/clocksource/rockchip_timer.c | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/clocksource/rockchip_timer.c b/drivers/clocksource/rockchip_timer.c >> index b93fed6..f3dfb1a 100644 >> --- a/drivers/clocksource/rockchip_timer.c >> +++ b/drivers/clocksource/rockchip_timer.c >> @@ -150,12 +150,13 @@ static void __init rk_timer_init(struct device_node *np) >> } >> >> ce->name = TIMER_NAME; >> - ce->features = CLOCK_EVT_FEAT_PERIODIC | CLOCK_EVT_FEAT_ONESHOT; >> + ce->features = CLOCK_EVT_FEAT_PERIODIC | CLOCK_EVT_FEAT_ONESHOT | >> + CLOCK_EVT_FEAT_DYNIRQ; >> ce->set_next_event = rk_timer_set_next_event; >> ce->set_state_shutdown = rk_timer_shutdown; >> ce->set_state_periodic = rk_timer_set_periodic; >> ce->irq = irq; >> - ce->cpumask = cpumask_of(0); >> + ce->cpumask = cpu_all_mask; > > s/cpu_all_mask/cpu_possible_mask/ Okay for me. It seems drivers in drivers/clocksource are very confusing about use cpu_all_mask or cpu_possible_mask. For example arm_arch_timer.c use cpu_all_mask, while mtk_timer.c use cpu_possible_mask. I think all just work. Thanks, Huang, Tao