From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753943AbcEaQSS (ORCPT ); Tue, 31 May 2016 12:18:18 -0400 Received: from smtp.citrix.com ([66.165.176.89]:30807 "EHLO SMTP.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750730AbcEaQSR (ORCPT ); Tue, 31 May 2016 12:18:17 -0400 X-IronPort-AV: E=Sophos;i="5.26,396,1459814400"; d="scan'208";a="357571933" Subject: Re: [Xen-devel] [PATCH] xen: xenbus: Remove create_workqueue To: Bhaktipriya Shridhar , References: <20160527185002.GA19321@Karyakshetra> CC: , From: David Vrabel X-Enigmail-Draft-Status: N1110 Message-ID: <574DB946.1050609@citrix.com> Date: Tue, 31 May 2016 17:18:14 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.5.0 MIME-Version: 1.0 In-Reply-To: <20160527185002.GA19321@Karyakshetra> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-DLP: MIA1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27/05/16 19:50, Bhaktipriya Shridhar wrote: > With concurrency managed workqueues, use of dedicated workqueues can be > replaced by using system_wq. Drop xenbus_frontend_wq by using system_wq. > > Since there is only a single work item, increase of concurrency level by > switching to system_wq should not break anything. > > Since the work item could be pending and the code expects it to run > once scheduled, flush_work() has been used in xenbus_dev_suspend() This says flush_work() but... > > Signed-off-by: Bhaktipriya Shridhar > --- > drivers/xen/xenbus/xenbus_probe.c | 2 ++ > drivers/xen/xenbus/xenbus_probe_frontend.c | 15 +-------------- > 2 files changed, 3 insertions(+), 14 deletions(-) > > diff --git a/drivers/xen/xenbus/xenbus_probe.c b/drivers/xen/xenbus/xenbus_probe.c > index 33a31cf..bc97019 100644 > --- a/drivers/xen/xenbus/xenbus_probe.c > +++ b/drivers/xen/xenbus/xenbus_probe.c > @@ -592,6 +592,8 @@ int xenbus_dev_suspend(struct device *dev) > > DPRINTK("%s", xdev->nodename); > > + cancel_work_sync(&xdev->work); ...cancel_work_sync() is called here. David