All of lore.kernel.org
 help / color / mirror / Atom feed
From: Olivier MATZ <olivier.matz@6wind.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>, dev@dpdk.org
Cc: thomas.monjalon@6wind.com, helin.zhang@intel.com
Subject: Re: [PATCH] kni: fix use of undefined comma variable in makefile
Date: Tue, 31 May 2016 21:12:43 +0200	[thread overview]
Message-ID: <574DE22B.1010209@6wind.com> (raw)
In-Reply-To: <574D933C.2080507@intel.com>

Hi Ferruh,

On 05/31/2016 03:35 PM, Ferruh Yigit wrote:
> Error is related to the kernel version, in second call "comma"
> definition comes from kernel makefiles.
> 
> Following commit causes comma to be defined:
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=371fdc77af44f4cb32475fd499e1d912ccc30890
> 
> So this is valid issue for old kernels, and using "," directly looks OK.
> 
>> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> Acked-by Ferruh Yigit <ferruh.yigit@intel.com>

Thanks for investigating the issue!
Olivier

  reply	other threads:[~2016-05-31 19:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-30 11:56 [PATCH] kni: fix use of undefined comma variable in makefile Olivier Matz
2016-05-30 15:49 ` Ferruh Yigit
2016-05-30 16:21   ` Olivier Matz
2016-05-30 16:46     ` Ferruh Yigit
2016-05-31 13:35       ` Ferruh Yigit
2016-05-31 19:12         ` Olivier MATZ [this message]
2016-06-07  8:32         ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=574DE22B.1010209@6wind.com \
    --to=olivier.matz@6wind.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=helin.zhang@intel.com \
    --cc=thomas.monjalon@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.