From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark yao Subject: Re: [PATCH v2 08/10] drm/rockchip: analogix_dp: correct the connector display color format and bpc Date: Wed, 1 Jun 2016 11:52:04 +0800 Message-ID: <574E5BE4.7050003@rock-chips.com> References: <1464066086-21967-1-git-send-email-ykk@rock-chips.com> <1464066164-22863-1-git-send-email-ykk@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1464066164-22863-1-git-send-email-ykk@rock-chips.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Yakir Yang , David Airlie , Inki Dae , Mark Yao , Thierry Reding , Jingoo Han , Rob Herring Cc: Krzysztof Kozlowski , linux-samsung-soc@vger.kernel.org, Javier Martinez Canillas , Daniel Vetter , emil.l.velikov@gmail.com, Douglas Anderson , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Dan Carpenter List-Id: linux-rockchip.vger.kernel.org T24gMjAxNuW5tDA15pyIMjTml6UgMTM6MDIsIFlha2lyIFlhbmcgd3JvdGU6Cj4gUm9ja2NoaXAg Vk9QIGNvdWxkbid0IG91dHB1dCBZVVYgdmlkZW8gZm9ybWF0IGZvciBlRFAgY29udHJvbGxlciwg c28KPiB3aGVuIGRyaXZlciBkZXRlY3QgY29ubmVjdG9yIHN1cHBvcnQgWVVWIHZpZGVvIGZvcm1h dCwgd2UgbmVlZCB0byBoYWNrCj4gaXQgZG93biB0byBSR0I4ODguCj4KPiBTaWduZWQtb2ZmLWJ5 OiBZYWtpciBZYW5nIDx5a2tAcm9jay1jaGlwcy5jb20+Cj4gLS0tCj4gQ2hhbmdlcyBpbiB2Mjog Tm9uZQo+Cj4gICBkcml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAvYW5hbG9naXhfZHAtcm9ja2NoaXAu YyB8IDE5ICsrKysrKysrKysrKysrKysrKysKPiAgIDEgZmlsZSBjaGFuZ2VkLCAxOSBpbnNlcnRp b25zKCspCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlwL2FuYWxvZ2l4 X2RwLXJvY2tjaGlwLmMgYi9kcml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAvYW5hbG9naXhfZHAtcm9j a2NoaXAuYwo+IGluZGV4IGYyOWNhM2QuLjkxMGNjZWIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9n cHUvZHJtL3JvY2tjaGlwL2FuYWxvZ2l4X2RwLXJvY2tjaGlwLmMKPiArKysgYi9kcml2ZXJzL2dw dS9kcm0vcm9ja2NoaXAvYW5hbG9naXhfZHAtcm9ja2NoaXAuYwo+IEBAIC05Nyw2ICs5NywyNCBA QCBzdGF0aWMgaW50IHJvY2tjaGlwX2RwX3Bvd2VyZG93bihzdHJ1Y3QgYW5hbG9naXhfZHBfcGxh dF9kYXRhICpwbGF0X2RhdGEpCj4gICAJcmV0dXJuIDA7Cj4gICB9Cj4gICAKPiArc3RhdGljIGVu dW0gZHJtX21vZGVfc3RhdHVzCj4gK3JvY2tjaGlwX2RwX21vZGVfdmFsaWQoc3RydWN0IGFuYWxv Z2l4X2RwX3BsYXRfZGF0YSAqcGxhdF9kYXRhLAo+ICsJCSAgICAgICBzdHJ1Y3QgZHJtX2Nvbm5l Y3RvciAqY29ubmVjdG9yLAo+ICsJCSAgICAgICBzdHJ1Y3QgZHJtX2Rpc3BsYXlfbW9kZSAqbW9k ZSkKPiArewo+ICsJc3RydWN0IGRybV9kaXNwbGF5X2luZm8gKmRpID0gJmNvbm5lY3Rvci0+ZGlz cGxheV9pbmZvOwo+ICsKPiArCWlmIChkaS0+Y29sb3JfZm9ybWF0cyAmIERSTV9DT0xPUl9GT1JN QVRfWUNSQ0I0NDQgfHwKPiArCSAgICBkaS0+Y29sb3JfZm9ybWF0cyAmIERSTV9DT0xPUl9GT1JN QVRfWUNSQ0I0MjIpIHsKPiArCQlkaS0+Y29sb3JfZm9ybWF0cyAmPSB+KERSTV9DT0xPUl9GT1JN QVRfWUNSQ0I0MjIgfAo+ICsJCQkJICAgICAgIERSTV9DT0xPUl9GT1JNQVRfWUNSQ0I0NDQpOwo+ ICsJCWRpLT5jb2xvcl9mb3JtYXRzIHw9IERSTV9DT0xPUl9GT1JNQVRfUkdCNDQ0Owo+ICsJCWRp LT5icGMgPSA4Owo+ICsJfQo+ICsKPiArCXJldHVybiBNT0RFX09LOwo+ICt9Cj4gKwo+ICAgc3Rh dGljIGJvb2wKPiAgIHJvY2tjaGlwX2RwX2RybV9lbmNvZGVyX21vZGVfZml4dXAoc3RydWN0IGRy bV9lbmNvZGVyICplbmNvZGVyLAo+ICAgCQkJCSAgIGNvbnN0IHN0cnVjdCBkcm1fZGlzcGxheV9t b2RlICptb2RlLAo+IEBAIC0zMDYsNiArMzI0LDcgQEAgc3RhdGljIGludCByb2NrY2hpcF9kcF9i aW5kKHN0cnVjdCBkZXZpY2UgKmRldiwgc3RydWN0IGRldmljZSAqbWFzdGVyLAo+ICAgCWRwLT5w bGF0X2RhdGEuc3ViZGV2X3R5cGUgPSBkcF9kYXRhLT5jaGlwX3R5cGU7Cj4gICAJZHAtPnBsYXRf ZGF0YS5wb3dlcl9vbiA9IHJvY2tjaGlwX2RwX3Bvd2Vyb247Cj4gICAJZHAtPnBsYXRfZGF0YS5w b3dlcl9vZmYgPSByb2NrY2hpcF9kcF9wb3dlcmRvd247Cj4gKwlkcC0+cGxhdF9kYXRhLm1vZGVf dmFsaWQgPSByb2NrY2hpcF9kcF9tb2RlX3ZhbGlkOwo+ICAgCj4gICAJcmV0dXJuIGFuYWxvZ2l4 X2RwX2JpbmQoZGV2LCBkcC0+ZHJtX2RldiwgJmRwLT5wbGF0X2RhdGEpOwo+ICAgfQpMb29rcyBm b3IgbWUsIFNvOgoKQWNrZWQtYnk6IE1hcmsgWWFvIDxtYXJrLnlhb0Byb2NrLWNoaXBzLmNvbT4K Ci0tIArvvK1hcmsgWWFvCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJp LWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757249AbcFADwU (ORCPT ); Tue, 31 May 2016 23:52:20 -0400 Received: from regular1.263xmail.com ([211.150.99.130]:57276 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756726AbcFADwT (ORCPT ); Tue, 31 May 2016 23:52:19 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: mark.yao@rock-chips.com X-FST-TO: dan.carpenter@oracle.com X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: mark.yao@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH v2 08/10] drm/rockchip: analogix_dp: correct the connector display color format and bpc To: Yakir Yang , David Airlie , Inki Dae , Mark Yao , Thierry Reding , Jingoo Han , Rob Herring References: <1464066086-21967-1-git-send-email-ykk@rock-chips.com> <1464066164-22863-1-git-send-email-ykk@rock-chips.com> Cc: Krzysztof Kozlowski , linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, Daniel Vetter , emil.l.velikov@gmail.com, Douglas Anderson , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Javier Martinez Canillas , Dan Carpenter From: Mark yao Message-ID: <574E5BE4.7050003@rock-chips.com> Date: Wed, 1 Jun 2016 11:52:04 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1464066164-22863-1-git-send-email-ykk@rock-chips.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016年05月24日 13:02, Yakir Yang wrote: > Rockchip VOP couldn't output YUV video format for eDP controller, so > when driver detect connector support YUV video format, we need to hack > it down to RGB888. > > Signed-off-by: Yakir Yang > --- > Changes in v2: None > > drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c > index f29ca3d..910cceb 100644 > --- a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c > +++ b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c > @@ -97,6 +97,24 @@ static int rockchip_dp_powerdown(struct analogix_dp_plat_data *plat_data) > return 0; > } > > +static enum drm_mode_status > +rockchip_dp_mode_valid(struct analogix_dp_plat_data *plat_data, > + struct drm_connector *connector, > + struct drm_display_mode *mode) > +{ > + struct drm_display_info *di = &connector->display_info; > + > + if (di->color_formats & DRM_COLOR_FORMAT_YCRCB444 || > + di->color_formats & DRM_COLOR_FORMAT_YCRCB422) { > + di->color_formats &= ~(DRM_COLOR_FORMAT_YCRCB422 | > + DRM_COLOR_FORMAT_YCRCB444); > + di->color_formats |= DRM_COLOR_FORMAT_RGB444; > + di->bpc = 8; > + } > + > + return MODE_OK; > +} > + > static bool > rockchip_dp_drm_encoder_mode_fixup(struct drm_encoder *encoder, > const struct drm_display_mode *mode, > @@ -306,6 +324,7 @@ static int rockchip_dp_bind(struct device *dev, struct device *master, > dp->plat_data.subdev_type = dp_data->chip_type; > dp->plat_data.power_on = rockchip_dp_poweron; > dp->plat_data.power_off = rockchip_dp_powerdown; > + dp->plat_data.mode_valid = rockchip_dp_mode_valid; > > return analogix_dp_bind(dev, dp->drm_dev, &dp->plat_data); > } Looks for me, So: Acked-by: Mark Yao -- Ｍark Yao