From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41472)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <caoj.fnst@cn.fujitsu.com>) id 1b81WU-0005FY-MP
	for qemu-devel@nongnu.org; Wed, 01 Jun 2016 04:29:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <caoj.fnst@cn.fujitsu.com>) id 1b81WP-0001Xz-L6
	for qemu-devel@nongnu.org; Wed, 01 Jun 2016 04:29:05 -0400
Received: from [59.151.112.132] (port=30007 helo=heian.cn.fujitsu.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <caoj.fnst@cn.fujitsu.com>) id 1b81WO-0001Wm-Ta
	for qemu-devel@nongnu.org; Wed, 01 Jun 2016 04:29:01 -0400
References: <1464062689-32156-1-git-send-email-caoj.fnst@cn.fujitsu.com>
	<1464062689-32156-3-git-send-email-caoj.fnst@cn.fujitsu.com>
	<87mvn549f4.fsf@dusky.pond.sub.org>
From: Cao jin <caoj.fnst@cn.fujitsu.com>
Message-ID: <574E9DF5.2020301@cn.fujitsu.com>
Date: Wed, 1 Jun 2016 16:33:57 +0800
MIME-Version: 1.0
In-Reply-To: <87mvn549f4.fsf@dusky.pond.sub.org>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v6 02/11] fix some coding style problems
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, Dmitry Fleytman <dmitry@daynix.com>, Marcel Apfelbaum <marcel@redhat.com>, Jason Wang <jasowang@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>



On 06/01/2016 04:09 PM, Markus Armbruster wrote:
> Cao jin <caoj.fnst@cn.fujitsu.com> writes:
>
>> It has:
>> 1. More newlines make the code block well separated.
>> 2. Add more comments for msi_init.
>> 3. Fix a indentation in vmxnet3.c.
>> 4. ioh3420 & xio3130_downstream: put PCI Express capability init function
>>     together, make it more readable.
>>
>> cc: Dmitry Fleytman <dmitry@daynix.com>
>> cc: Jason Wang <jasowang@redhat.com>
>> cc: Michael S. Tsirkin <mst@redhat.com>
>> cc: Markus Armbruster <armbru@redhat.com>
>> cc: Marcel Apfelbaum <marcel@redhat.com>
>>
>> Reviewed-by: Marcel Apfelbaum <marcel@redhat.com>
>> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
> [...]
>> diff --git a/hw/pci/msi.c b/hw/pci/msi.c
>> index e0e64c2..97f35c0 100644
>> --- a/hw/pci/msi.c
>> +++ b/hw/pci/msi.c
>> @@ -165,6 +165,23 @@ bool msi_enabled(const PCIDevice *dev)
>>            PCI_MSI_FLAGS_ENABLE);
>>   }
>>
>> +/*
>> + * Make PCI device @dev MSI-capable.
>> + * Non-zero @offset puts capability MSI at that offset in PCI config
>> + * space.
>> + * @nr_vectors is the number of MSI vectors (1, 2, 4, 8, 16 or 32).
>> + * If @msi64bit, make the device capable of sending a 64-bit message
>> + * address.
>> + * If @msi_per_vector_mask, make the device support per-vector masking.
>> + * @errp is for returning errors.
>
> @errp only appears in PATCH 11.  The easiest fix is to add this comment
> only then.
>

eh...sorry for my carelessness...

-- 
Yours Sincerely,

Cao jin