From: Krzysztof Opasiak <k.opasiak@samsung.com>
To: Dave Jones <davej@codemonkey.org.uk>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Karol Kosik <karo9@interia.eu>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: usbip: vudc: Fix apparent cut-n-paste error
Date: Wed, 01 Jun 2016 12:21:06 +0200 [thread overview]
Message-ID: <574EB712.1020905@samsung.com> (raw)
In-Reply-To: <20160531152509.GA14338@codemonkey.org.uk>
On 05/31/2016 05:25 PM, Dave Jones wrote:
> Coverity picked up that this looks like a cut-n-paste from an almost
> identical sequence below that didn't get its variable renamed.
>
> Signed-off-by: Dave Jones <davej@codemonkey.org.uk>
>
> diff --git a/drivers/usb/usbip/vudc_dev.c b/drivers/usb/usbip/vudc_dev.c
> index 8994a13819ab..7091848df6c8 100644
> --- a/drivers/usb/usbip/vudc_dev.c
> +++ b/drivers/usb/usbip/vudc_dev.c
> @@ -450,7 +450,7 @@ static void vudc_shutdown(struct usbip_device *ud)
> if (ud->tcp_socket)
> kernel_sock_shutdown(ud->tcp_socket, SHUT_RDWR);
>
> - if (ud->tcp_tx) {
> + if (ud->tcp_rx) {
> kthread_stop_put(ud->tcp_rx);
> ud->tcp_rx = NULL;
> }
>
>
Reviewed-by: Krzysztof Opasiak <k.opasiak@samsung.com>
--
Krzysztof Opasiak
Samsung R&D Institute Poland
Samsung Electronics
prev parent reply other threads:[~2016-06-01 10:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-31 15:25 usbip: vudc: Fix apparent cut-n-paste error Dave Jones
2016-06-01 10:21 ` Krzysztof Opasiak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=574EB712.1020905@samsung.com \
--to=k.opasiak@samsung.com \
--cc=davej@codemonkey.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=karo9@interia.eu \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.