From: Julien Grall <julien.grall@arm.com>
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel@lists.xensource.com, wei.liu2@citrix.com
Subject: Re: [PATCH for-4.7] xen/arm: warn the user that we cannout route SPIs to Dom0
Date: Wed, 1 Jun 2016 11:45:51 +0100 [thread overview]
Message-ID: <574EBCDF.9050003@arm.com> (raw)
In-Reply-To: <alpine.DEB.2.10.1606011118210.16603@sstabellini-ThinkPad-X260>
Hi Stefano,
Title: s/cannout/cannot/
I would add ACPI in the title to avoid people been scared by "we cannot
route SPIs to DOM0" :).
On 01/06/16 11:19, Stefano Stabellini wrote:
> as a consequence of 9d77b3c01d1261ce17c10097a1b393f2893ca657 being
> reverted.
> Signed-off-by: Stefano Stabellini <sstabellini@kernel.org>
>
> diff --git a/xen/arch/arm/vgic.c b/xen/arch/arm/vgic.c
> index ee35683..babc822 100644
> --- a/xen/arch/arm/vgic.c
> +++ b/xen/arch/arm/vgic.c
> @@ -25,6 +25,8 @@
> #include <xen/irq.h>
> #include <xen/sched.h>
> #include <xen/perfc.h>
> +#include <xen/iocap.h>
> +#include <xen/acpi.h>
>
> #include <asm/current.h>
>
> @@ -342,9 +344,15 @@ void vgic_enable_irqs(struct vcpu *v, uint32_t r, int n)
> unsigned long flags;
> int i = 0;
> struct vcpu *v_target;
> + struct domain *d = v->domain;
>
> while ( (i = find_next_bit(&mask, 32, i)) < 32 ) {
> irq = i + (32 * n);
> + /* Set the irq type and route it to guest only for SPI and Dom0 */
> + if( irq_access_permitted(d, irq) && is_hardware_domain(d) &&
> + ( irq >= 32 ) && ( !acpi_disabled ) )
> + gprintk(XENLOG_WARNING, "Routing SPIs to Dom0 on ACPI systems is unimplemented.\n");
The log will likely be spammed with this message (i.e everytime an IRQ
is enabled). Should not we print this message only once?
Either way:
Acked-by: Julien Grall <julien.grall@arm.com>
Regards,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-06-01 10:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-01 10:19 [PATCH for-4.7] xen/arm: warn the user that we cannout route SPIs to Dom0 Stefano Stabellini
2016-06-01 10:45 ` Julien Grall [this message]
2016-06-01 10:47 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=574EBCDF.9050003@arm.com \
--to=julien.grall@arm.com \
--cc=sstabellini@kernel.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.