From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH] x86/cpuid: fix dom0 crash on skylake machine Date: Wed, 1 Jun 2016 12:27:29 +0100 Message-ID: <574EC6A1.9090307@citrix.com> References: <1464757092-13177-1-git-send-email-luwei.kang@intel.com> <574EA4F0.5030607@citrix.com> <574EC46202000078000F047F@prv-mh.provo.novell.com> <574EAC38.6020305@citrix.com> <574ECA5E02000078000F04C6@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <574ECA5E02000078000F04C6@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Jan Beulich Cc: huaitong.han@intel.com, Luwei Kang , yong.y.wang@intel.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org T24gMDEvMDYvMTYgMTA6NDMsIEphbiBCZXVsaWNoIHdyb3RlOgo+Pj4+IE9uIDAxLjA2LjE2IGF0 IDExOjM0LCA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4gd3JvdGU6Cj4+IE9uIDAxLzA2LzE2 IDEwOjE3LCBKYW4gQmV1bGljaCB3cm90ZToKPj4+Pj4+IE9uIDAxLjA2LjE2IGF0IDExOjAzLCA8 YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4gd3JvdGU6Cj4+Pj4gV2hpbGUgdGhpcyBkb2VzIHdv cmssIGl0IHVuZG9lcyBzb21lIG9mIHRoZSB3b3JrIEkgc3RhcnRlZCB3aXRoIG15IGNwdWlkCj4+ Pj4gaW1wcm92ZW1lbnRzIGluIDQuNwo+Pj4+Cj4+Pj4gRG9lcyB0aGUgYXR0YWNoZWQgcGF0Y2gg YWxzbyByZXNvbHZlIHlvdXIgaXNzdWU/Cj4+PiBXaGlsZSB0aGF0J3MgbXVjaCBiZXR0ZXIgdGhh biB0aGUgb3JpZ2luYWwsIEkgZG9uJ3QgdGhpbmsgaXQncyBxdWl0ZQo+Pj4gZW5vdWdoLiBUaGUg cmVzdCBvZiB0aGUgZG9tYWluIHBvbGljeSBzaG91bGQgYmUgdGFrZW4gaW50byBhY2NvdW50Cj4+ PiAoYW5kIEkgdGhpbmsgSSBoYWQgc3VnZ2VzdGVkIHRvIGRvIHNvIGR1cmluZyByZXZpZXcgb2Yg eW91ciBDUFVJRAo+Pj4gcmV3b3JrIHNlcmllcyksIGkuZS4gdGhpcyBjYW4ndCBiZSBjYWxjdWxh dGVkIG9uY2UgZm9yIGV2ZXJ5IGRvbWFpbi4KPj4gTGlrZSB0aGUgY3VycmVudCB1c2Ugb2Yge2h2 bSxwdn1fZmVhdHVyZXNldCwgYXMgYW4gdXBwZXIgYm91bmQsIHRoaXMgaXMKPj4ganVzdCBhIHN0 b3BnYXAgZml4Lgo+Pgo+PiBGaXhpbmcgdGhpcyBpbiBhIHByb3Blcmx5IHBlci1kb21haW4gd2F5 IGlzIHBhcnQgb2YgbXkgZnVydGhlciBwbGFucyBmb3IKPj4gY3B1aWQgaW1wcm92ZW1lbnRzLiAg VGhlIHJlYXNvbiBpdCBpc24ndCBkb25lIGxpa2UgdGhpcyB5ZXQgaXMgYmVjYXVzZQo+PiB0aGVy ZSBpcyBhIHN1YnN0YW50aWFsIHF1YW50aXR5IG9mIHdvcmsgcmVxdWlyZWQgdG8gbWFrZSB0aGlz IGZ1bmN0aW9uLgo+IFdoYXQgc3Vic3RhbnRpYWwgd29yayBvdGhlciB0aGFuIFhTVEFURSBsZWFm IGhhbmRsaW5nIGlucXVpcmluZwo+IG90aGVyIGxlYXZlcyBkbyB5b3Ugc2VlPwoKSSB3YW50IHRv IGFkanVzdCB0aGUgcmVwcmVzZW50YXRpb24gb2YgY3B1aWQgaW5mb3JtYXRpb24gaW4gc3RydWN0 CmRvbWFpbi4gVGhlIGN1cnJlbnQgbG9vcCBpbiBkb21haW5fY3B1aWQoKSBjYXVzZXMgYW4gTyhO KSBvdmVyaGVhZCBmb3IKZXZlcnkgcXVlcnksIHdoaWNoIGlzIHZlcnkgcG9vciBmb3IgYWN0aW9u cyB3aGljaCByZWFsbHkgc2hvdWxkIGJlIGEKc2luZ2xlIGJpdCB0ZXN0IGF0IGEgZml4ZWQgb2Zm c2V0LgoKVGhpcyBuZWVkcyB0byBiZSBjb21iaW5lZCB3aXRoIHByb3Blcmx5IHNwbGl0dGluZyB0 aGUgcGVyLWRvbWFpbiBhbmQKcGVyLXZjcHUgaW5mb3JtYXRpb24sIHdoaWNoIHJlcXVpcmVzIGtu b3dpbmcgdGhlIGV4cGVjdGVkIHZjcHUgdG9wb2xvZ3kKZHVyaW5nIGRvbWFpbiBjcmVhdGlvbi4K Ck9uIHRvcCBvZiB0aGF0LCB0aGVyZSBuZWVkcyB0byBiZSB2ZXJpZmljYXRpb24gbG9naWMgdG8g Y2hlY2sgdGhlCmNvcnJlY3RuZXNzIG9mIGluZm9ybWF0aW9uIHBhc3NlZCBmcm9tIHRoZSB0b29s c3RhY2suCgpBbGwgb2YgdGhlc2UgYXJlYXMgYXJlIGNvdmVyZWQgaW4gdGhlICJrbm93biBpc3N1 ZXMiIHNlY3Rpb24gb2YgdGhlCmZlYXR1cmUgZG9jLCBhbmQgSSBkbyBwbGFuIHRvIGZpeCB0aGVt IGFsbC4gIEhvd2V2ZXIsIGl0IGlzbid0IGEgY291cGxlCm9mIGhvdXJzIHdvcnRoIG9mIHdvcmsu Cgo+Cj4+PiBBbmQgdGhlbiwgYXMgc2FpZCBpbiByZXBseSB0byB0aGUgb3JpZ2luYWwgcGF0Y2gs IGhhbmRsZV94c2V0YnYoKSdzCj4+PiBjaGVja2luZyBzaG91bGQgYmUgZ2VuZXJhbGl6ZWQgZnJv bSB0aGUgc3BlY2lhbCBjYXNpbmcgb2YgUEtSVSAob3IKPj4+IGlmIHdlIGRvbid0IHdhbnQgdGhh dCwgdGhlbiB0aGF0IHNwZWNpYWwgY2FzZSB3b3VsZCBiZXR0ZXIgZ2V0Cj4+PiByZW1vdmVkIGZv ciBjb25zaXN0ZW5jeSByZWFzb25zKS4KPj4gT2ggLSBJIGhhZG4ndCBldmVuIG5vdGljZWQgdGhh dC4gIEhvdyBhYm91dCB0aGlzIGluY3JlbWVudGFsIGNoYW5nZT8KPj4KPj4gZGlmZiAtLWdpdCBh L3hlbi9hcmNoL3g4Ni94c3RhdGUuYyBiL3hlbi9hcmNoL3g4Ni94c3RhdGUuYwo+PiBpbmRleCBh MGNmY2MyLi42N2MwZTRiIDEwMDY0NAo+PiAtLS0gYS94ZW4vYXJjaC94ODYveHN0YXRlLmMKPj4g KysrIGIveGVuL2FyY2gveDg2L3hzdGF0ZS5jCj4+IEBAIC02NTgsOCArNjU4LDggQEAgaW50IGhh bmRsZV94c2V0YnYodTMyIGluZGV4LCB1NjQgbmV3X2J2KQo+PiAgICAgIGlmICggKG5ld19idiAm IH54ZmVhdHVyZV9tYXNrKSB8fCAhdmFsaWRfeGNyMChuZXdfYnYpICkKPj4gICAgICAgICAgcmV0 dXJuIC1FSU5WQUw7Cj4+ICAKPj4gLSAgICAvKiBYQ1IwLlBLUlUgaXMgZGlzYWJsZWQgb24gUFYg bW9kZS4gKi8KPj4gLSAgICBpZiAoIGlzX3B2X3ZjcHUoY3VycikgJiYgKG5ld19idiAmIFhTVEFU RV9QS1JVKSApCj4+ICsgICAgLyogU2FuaXR5IGNoZWNrIGFnYWluc3QgZG9tYWluIG1heGltdW0u ICovCj4+ICsgICAgaWYgKCBuZXdfYnYgJiB+KGlzX3B2X3ZjcHUoY3VycikgPyBwdl94ZmVhdHVy ZV9tYXNrIDogaHZtX3hmZWF0dXJlX21hc2spICkKPj4gICAgICAgICAgcmV0dXJuIC1FT1BOT1RT VVBQOwo+IExvb2tzIGdvb2QuCj4KPiBCdXQgb25lIG90aGVyIGFzcGVjdDogTVBYIGlzIHRhZ2dl ZCBTLCB3aGlsZSBQS1UgaXMgdGFnZ2VkIEguIERvCj4gd2UgcGVyaGFwcyBuZWVkIHRocmVlIG1h c2tzIHRvIGdldCB0aGUgYWJvdmUgcmlnaHQgYXQgbGVhc3Qgd2l0aAo+IGp1c3QgdGhlIGdsb2Jh bCBtYXNraW5nPwoKU28gaXQgaXMuICBJIHdvbmRlciB3aHkuICAoSXQgd2FzIHByZXZpb3VzbHkg bGlrZSB0aGF0LCBhbmQgSSBkaWRuJ3QKYWx0ZXIgaXQgYXMgcGFydCBvZiBteSBjcHVpZCB3b3Jr KS4gIEkgY2FuJ3Qgc2VlIGFueXRoaW5nIGluIE1QWCB3aGljaAptYWtlcyBpdCB1bnNhZmUgdG8g dXNlIHdpdGggc2hhZG93LiAgQWxsIGNvbnRyb2wgc3RhdGUgd29ya3Mgb24gbGluZWFyCmFkZHJl c3NlcyByYXRoZXIgdGhhbiBwaHlzaWNhbCBhZGRyZXNzZXMuCgpGb3Igbm93LCBJIHdpbGwgaW1w bGVtZW50IHRoZSBzYW1lIGtpbmQgb2YgcnVudGltZSBjaGVjayBhcyBoaWRlcyBNUFgKZnJvbSBz aGFkb3cgZ3Vlc3RzIGluIGh2bV9jcHVpZCgpLiAgVGhpcyBhZ2FpbiB3aWxsIGV2ZW50dWFsbHkg YmUKc3Vic3VtZWQgYnkgdGhlIGZ1cnRoZXIgd29yay4KCkkgYW0gYWxzbyB3b25kZXJpbmcgd2hl dGhlciB3ZSBzaG91bGQgZGlzYWJsZSBNUFggYnkgZGVmYXVsdCBmb3IKZG9tYWlucy4gIFdlIGtu b3cgaXQgd29uJ3Qgd29yayBwcm9wZXJseSBmb3IgYW55dGhpbmcgd2hpY2ggZW5kcyB1cApiZWlu ZyBlbXVsYXRlZC4gIFVzZXJzIHdobyBzcGVjaWZpY2FsbHkgd2FudCB0byB0cnkgaXQgc2hvdWxk IGJlIGFibGUgdG8KdHVybiBpdCBvbiBpbiB0aGVpciBkb21haW4gY29uZmlndXJhdGlvbiBmaWxl LCBidXQgaXQgcmVhbGx5IHNob3VsZG4ndApiZSBvbiBteSBkZWZhdWx0LgoKfkFuZHJldwoKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1h aWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9yZy94 ZW4tZGV2ZWwK