Re: [PATCH] thermal: cpu_cooling: fix improper order during initialization

[Lukasz Luba <lukasz.luba@arm.com>]

On 01/06/16 12:10, Viresh Kumar wrote:
> On 31-05-16, 11:32, Lukasz Luba wrote:
>> The freq_table array is not populated before calling
>> thermal_of_cooling_register. The code which populates the freq table was
>> introduced in commit f6859014.
>> This should be done before registering new thermal cooling device.
>> The log shows effects of this wrong decision.
>> [    2.172614] cpu cpu1: Failed to get voltage for frequency 1984518656000: -34
>> [    2.220863] cpu cpu0: Failed to get voltage for frequency 1984524416000: -34
>>
>
> You should have added this as well:
>
> Cc: 4.19+ <stable@vger.kernel.org> # 4.19+

You mean 3.19+
Cc: <stable@vger.kernel.org> # 3.19+

> Fixes: f6859014c7e7 ("thermal: cpu_cooling: Store frequencies in descending order")
>
>> Signed-off-by: Lukasz Luba <lukasz.luba@arm.com>
>> ---
>>   drivers/thermal/cpu_cooling.c | 16 ++++++++--------
>>   1 file changed, 8 insertions(+), 8 deletions(-)
>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
>
Eduardo can you pick these tags when you merge it?

Thanks,
Lukasz