From: Timur Tabi <timur@codeaurora.org>
To: Florian Fainelli <f.fainelli@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
sdharia@codeaurora.org,
Shanker Donthineni <shankerd@codeaurora.org>,
Greg Kroah-Hartman <greg@kroah.com>,
vikrams@codeaurora.org, cov@codeaurora.org,
gavidov@codeaurora.org, Rob Herring <robh+dt@kernel.org>,
andrew@lunn.ch, bjorn.andersson@linaro.org,
Mark Langsdorf <mlangsdo@redhat.com>,
Jon Masters <jcm@redhat.com>, Andy Gross <agross@codeaurora.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH 1/2] [v4] net: emac: emac gigabit ethernet controller driver
Date: Wed, 1 Jun 2016 17:27:52 -0500 [thread overview]
Message-ID: <574F6168.3020802@codeaurora.org> (raw)
In-Reply-To: <570EC541.6080603@gmail.com>
Florian Fainelli wrote:
>> +/* Transmit the packet */
>> >+static int emac_start_xmit(struct sk_buff *skb, struct net_device *netdev)
>> >+{
>> >+ struct emac_adapter *adpt = netdev_priv(netdev);
>> >+
>> >+ return emac_mac_tx_buf_send(adpt, &adpt->tx_q, skb);
> I would inline emac_mac_tx_buf_send()'s body here to make it much easier
> to read and audit...
I'm close to submitting a v5 of this patchset. The change to phylib has
resulted in significant other changes. I'm sure it's still not quite
right, so I ask your patience in reviewing it.
However, I'm not sure inlining emac_mac_tx_buf_send() into
emac_start_xmit() is good idea. That would result in moving several
functions from emac-mac.c into emac.c. I'm concerned about maintaining
the functional split between the two files.
--
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
Forum, a Linux Foundation collaborative project.
next prev parent reply other threads:[~2016-06-01 22:27 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-13 17:59 [PATCH 1/2] [v4] net: emac: emac gigabit ethernet controller driver Timur Tabi
2016-04-13 17:59 ` [PATCH 2/2] MAINTAINERS: add Qualcomm EMAC network driver maintainer Timur Tabi
2016-04-13 19:22 ` [PATCH 1/2] [v4] net: emac: emac gigabit ethernet controller driver kbuild test robot
2016-04-13 19:31 ` Timur Tabi
2016-04-13 19:40 ` Shanker Donthineni
2016-04-13 19:55 ` Timur Tabi
2016-04-13 20:07 ` Bjørn Mork
2016-04-14 16:24 ` Rob Herring
2016-04-13 22:16 ` Florian Fainelli
2016-04-14 20:19 ` Timur Tabi
2016-04-14 21:19 ` Florian Fainelli
2016-04-14 22:00 ` Vikram Sethi
2016-04-14 23:34 ` Timur Tabi
2016-04-15 12:35 ` Rob Herring
2016-04-15 15:44 ` Timur Tabi
2016-04-15 15:59 ` Rob Herring
2016-04-15 17:23 ` Timur Tabi
[not found] ` <57102920.7000104-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-04-15 16:44 ` Bjorn Andersson
2016-04-15 16:44 ` Bjorn Andersson
2016-04-15 17:00 ` Timur Tabi
2016-04-15 17:35 ` Bjorn Andersson
2016-04-15 18:22 ` Timur Tabi
2016-04-21 18:03 ` Timur Tabi
2016-04-22 19:45 ` Timur Tabi
2016-04-22 19:56 ` Florian Fainelli
2016-05-10 23:18 ` Timur Tabi
2016-05-10 23:26 ` Florian Fainelli
2016-05-11 2:24 ` Timur Tabi
2016-05-11 20:27 ` Timur Tabi
2016-04-25 13:16 ` Andrew Lunn
2016-06-01 22:27 ` Timur Tabi [this message]
[not found] ` <1460570393-19838-1-git-send-email-timur-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-04-14 3:27 ` kbuild test robot
2016-04-14 3:27 ` kbuild test robot
2016-04-14 16:32 ` Rob Herring
2016-04-14 16:47 ` Timur Tabi
2016-04-14 17:18 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=574F6168.3020802@codeaurora.org \
--to=timur@codeaurora.org \
--cc=agross@codeaurora.org \
--cc=andrew@lunn.ch \
--cc=bjorn.andersson@linaro.org \
--cc=cov@codeaurora.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=gavidov@codeaurora.org \
--cc=greg@kroah.com \
--cc=jcm@redhat.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mlangsdo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sdharia@codeaurora.org \
--cc=shankerd@codeaurora.org \
--cc=vikrams@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.