All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wei Fang <fangwei1@huawei.com>
To: Kevin Groeneveld <KGroeneveld@lenbrook.com>,
	"tj@kernel.org" <tj@kernel.org>,
	"jejb@linux.vnet.ibm.com" <jejb@linux.vnet.ibm.com>,
	"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
	"corbet@lwn.net" <corbet@lwn.net>
Cc: "hch@infradead.org" <hch@infradead.org>,
	"dan.j.williams@intel.com" <dan.j.williams@intel.com>,
	"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] scsi: fix race between simultaneous decrements of ->host_failed
Date: Thu, 2 Jun 2016 10:37:24 +0800	[thread overview]
Message-ID: <574F9BE4.4020405@huawei.com> (raw)
In-Reply-To: <BF6B9AADDDF11740967545E971C7C0DE6B861A22@MAIL1.pickering.lenbrook.com>

Hi, Kevin,

On 2016/6/1 22:36, Kevin Groeneveld wrote:
>> Subject: [PATCH v2 1/2] scsi: fix race between simultaneous decrements of ->host_failed
> 
> I wonder if this could be related to http://www.spinics.net/lists/linux-scsi/msg86808.html?
> 
> I never did get to the bottom of that.  If I have time I hope to retest my scsi hang issue with this patch.
> 

The concurrently decrements of host_failed only lead to abnormal
of host_failed, host_busy will be zero after error handler, and
the result may be host_failed > host_busy forever. But in your
case, host_busy > host_failed, so I think it's not the same
case. I'm afraid that this patch can't fix your scsi hang issue.

Thanks,
Wei


  parent reply	other threads:[~2016-06-02  2:38 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-31  8:38 [PATCH v2 1/2] scsi: fix race between simultaneous decrements of ->host_failed Wei Fang
2016-05-31  8:38 ` [PATCH v2 2/2] Documentation/scsi: update scsi_eh.txt about ->host_failed Wei Fang
2016-05-31 14:33 ` [PATCH v2 1/2] scsi: fix race between simultaneous decrements of ->host_failed Tejun Heo
2016-06-01  1:20   ` Wei Fang
2016-06-01  3:21 ` Dan Williams
2016-06-01  3:30   ` Dan Williams
2016-06-01 14:06 ` James Bottomley
2016-06-02  1:58   ` Wei Fang
2016-06-01 14:36 ` Kevin Groeneveld
2016-06-01 15:29   ` Bart Van Assche
2016-06-01 15:38     ` James Bottomley
2016-06-02  2:37   ` Wei Fang [this message]
2016-06-02  3:09     ` Wei Fang
2016-06-06 12:48     ` Kevin Groeneveld

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=574F9BE4.4020405@huawei.com \
    --to=fangwei1@huawei.com \
    --cc=KGroeneveld@lenbrook.com \
    --cc=corbet@lwn.net \
    --cc=dan.j.williams@intel.com \
    --cc=hch@infradead.org \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.