From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH 02/11] dma-buf/fence: add fence_array fences v6 Date: Thu, 2 Jun 2016 09:20:15 +0200 Message-ID: <574FDE2F.1060401@vodafone.de> References: <1464786612-5010-1-git-send-email-deathsimple@vodafone.de> <1464786612-5010-3-git-send-email-deathsimple@vodafone.de> <20160601152519.GF11486@joana> <20160601224450.GD7231@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from pegasos-out.vodafone.de (pegasos-out.vodafone.de [80.84.1.38]) by gabe.freedesktop.org (Postfix) with ESMTP id 7DE116EB18 for ; Thu, 2 Jun 2016 07:20:21 +0000 (UTC) In-Reply-To: <20160601224450.GD7231@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Sumit Semwal , Gustavo Padovan , DRI mailing list , LKML , Chris Wilson List-Id: dri-devel@lists.freedesktop.org QW0gMDIuMDYuMjAxNiB1bSAwMDo0NCBzY2hyaWViIERhbmllbCBWZXR0ZXI6Cj4gT24gV2VkLCBK dW4gMDEsIDIwMTYgYXQgMDk6NTQ6MDRQTSArMDUzMCwgU3VtaXQgU2Vtd2FsIHdyb3RlOgo+PiBI aSBDaHJpc3RpYW4sIEd1c3Rhdm8sCj4+Cj4+IFRoYW5rcyBmb3IgdGhlc2UgcGF0Y2hlcy4KPj4K Pj4gT24gMSBKdW5lIDIwMTYgYXQgMjA6NTUsIEd1c3Rhdm8gUGFkb3ZhbiA8Z3VzdGF2b0BwYWRv dmFuLm9yZz4gd3JvdGU6Cj4+PiAyMDE2LTA2LTAxIENocmlzdGlhbiBLw7ZuaWcgPGRlYXRoc2lt cGxlQHZvZGFmb25lLmRlPjoKPj4+Cj4+Pj4gRnJvbTogR3VzdGF2byBQYWRvdmFuIDxndXN0YXZv LnBhZG92YW5AY29sbGFib3JhLmNvLnVrPgo+Pj4+Cj4+Pj4gc3RydWN0IGZlbmNlX2NvbGxlY3Rp b24gaW5oZXJpdHMgZnJvbSBzdHJ1Y3QgZmVuY2UgYW5kIGNhcnJpZXMgYQo+Pj4+IGNvbGxlY3Rp b24gb2YgZmVuY2VzIHRoYXQgbmVlZHMgdG8gYmUgd2FpdGVkIHRvZ2V0aGVyLgo+Pj4+Cj4+Pj4g SXQgaXMgdXNlZnVsIHRvIHRyYW5zbGF0ZSBhIHN5bmNfZmlsZSB0byBhIGZlbmNlIHRvIHJlbW92 ZSB0aGUgY29tcGxleGl0eQo+Pj4+IG9mIGRlYWxpbmcgd2l0aCBzeW5jX2ZpbGVzIG9uIERSTSBk cml2ZXJzLiBTbyBldmVuIGlmIHRoZXJlIGFyZSBtYW55Cj4+Pj4gZmVuY2VzIGluIHRoZSBzeW5j X2ZpbGUgdGhhdCBuZWVkcyB0byB3YWl0ZWQgZm9yIGEgY29tbWl0IHRvIGhhcHBlbiwKPj4+PiB0 aGV5IGFsbCBnZXQgYWRkZWQgdG8gdGhlIGZlbmNlX2NvbGxlY3Rpb24gYW5kIHBhc3NlZCBmb3Ig RFJNIHVzZSBhcwo+Pj4+IGEgc3RhbmRhcmQgc3RydWN0IGZlbmNlLgo+Pj4+Cj4+Pj4gVGhhdCBt ZWFucyB0aGF0IG5vIGNoYW5nZXMgbmVlZGVkIHRvIGFueSBkcml2ZXIgYmVzaWRlcyBzdXBwb3J0 aW5nIGZlbmNlcy4KPj4+Pgo+Pj4+IGZlbmNlX2NvbGxlY3Rpb24ncyBmZW5jZSBkb2Vzbid0IGJl bG9uZyB0byBhbnkgdGltZWxpbmUgY29udGV4dCwgc28KPj4+PiBmZW5jZV9pc19sYXRlcigpIGFu ZCBmZW5jZV9sYXRlcigpIGFyZSBub3QgbWVhbnQgdG8gYmUgY2FsbGVkIHdpdGgKPj4+PiBmZW5j ZV9jb2xsZWN0aW9ucyBmZW5jZXMuCj4+Pj4KPj4+PiB2MjogQ29tbWVudHMgYnkgRGFuaWVsIFZl dHRlcjoKPj4+PiAgICAgICAgLSBtZXJnZSBmZW5jZV9jb2xsZWN0aW9uX2luaXQoKSBhbmQgZmVu Y2VfY29sbGVjdGlvbl9hZGQoKQo+Pj4+ICAgICAgICAtIG9ubHkgYWRkIGNhbGxiYWNrcyBhdCAt PmVuYWJsZV9zaWduYWxsaW5nKCkKPj4+PiAgICAgICAgLSByZW1vdmUgZmVuY2VfY29sbGVjdGlv bl9wdXQoKQo+Pj4+ICAgICAgICAtIGNoZWNrIGZvciB0eXBlIG9uIHRvX2ZlbmNlX2NvbGxlY3Rp b24oKQo+Pj4+ICAgICAgICAtIGFkanVzdCBmZW5jZV9pc19sYXRlcigpIGFuZCBmZW5jZV9sYXRl cigpIHRvIFdBUk5fT04oKSBpZiB0aGV5Cj4+Pj4gICAgICAgIGFyZSB1c2VkIHdpdGggY29sbGVj dGlvbiBmZW5jZXMuCj4+Pj4KPj4+PiB2MzogLSBJbml0aWFsaXplIGZlbmNlX2NiLm5vZGUgYXQg ZmVuY2UgaW5pdC4KPj4+Pgo+Pj4+ICAgICAgQ29tbWVudHMgYnkgQ2hyaXMgV2lsc29uOgo+Pj4+ ICAgICAgICAtIHJldHVybiAidW5ib3VuZCIgb24gZmVuY2VfY29sbGVjdGlvbl9nZXRfdGltZWxp bmVfbmFtZSgpCj4+Pj4gICAgICAgIC0gZG9uJ3Qgc3RvcCBhZGRpbmcgY2FsbGJhY2tzIGlmIG9u ZSBmYWlscwo+Pj4+ICAgICAgICAtIHJlbW92ZSByZWR1bmRhbnQgISEgb24gZmVuY2VfY29sbGVj dGlvbl9lbmFibGVfc2lnbmFsaW5nKCkKPj4+PiAgICAgICAgLSByZW1vdmUgcmVkdW5kYW50ICgp IG9uIGZlbmNlX2NvbGxlY3Rpb25fc2lnbmFsZWQKPj4+PiAgICAgICAgLSB1c2UgZmVuY2VfZGVm YXVsdF93YWl0KCkgaW5zdGVhZAo+Pj4+Cj4+Pj4gdjQgKGNoayk6IFJld29yaywgc2ltcGxpZmlj YXRpb24gYW5kIGNsZWFudXA6Cj4+Pj4gICAgICAgIC0gRHJvcCBGRU5DRV9OT19DT05URVhUIGhh bmRsaW5nLCBhbHdheXMgYWxsb2NhdGUgYSBjb250ZXh0Lgo+Pj4+ICAgICAgICAtIFJlbmFtZSB0 byBmZW5jZV9hcnJheS4KPj4+PiAgICAgICAgLSBSZXR1cm4gZml4ZWQgZHJpdmVyIG5hbWUuCj4+ Pj4gICAgICAgIC0gUmVnaXN0ZXIgb25seSBvbmUgY2FsbGJhY2sgYXQgYSB0aW1lLgo+Pj4+ICAg ICAgICAtIERvY3VtZW50IHRoYXQgY3JlYXRlIGZ1bmN0aW9uIHRha2VzIG93bmVyc2hpcCBvZiBh cnJheS4KPj4+Pgo+Pj4+IHY1IChjaGspOiBNb3JlIHdvcmsgYW5kIGZpeGVzOgo+Pj4+ICAgICAg ICAtIEF2b2lkIGRlYWRsb2NrcyBieSBhZGRpbmcgYWxsIGNhbGxiYWNrcyBhdCBvbmNlIGFnYWlu Lgo+Pj4+ICAgICAgICAtIFN0b3AgdHJ5aW5nIHRvIHJlbW92ZSB0aGUgY2FsbGJhY2tzLgo+Pj4+ ICAgICAgICAtIFByb3ZpZGUgY29udGV4dCBhbmQgc2VxdWVuY2UgbnVtYmVyIGZvciB0aGUgYXJy YXkgZmVuY2UuCj4+Pj4KPj4+PiB2NiAoY2hrKTogRml4ZXMgZm91bmQgZHVyaW5nIHRlc3RpbmcK Pj4+PiAgICAgICAgLSBGaXggc3R1cGlkIHR5cG8gaW4gX2VuYWJsZV9zaWduYWxpbmcoKS4KPj4+ Pgo+Pj4+IFNpZ25lZC1vZmYtYnk6IEd1c3Rhdm8gUGFkb3ZhbiA8Z3VzdGF2by5wYWRvdmFuQGNv bGxhYm9yYS5jby51az4KPj4+PiBTaWduZWQtb2ZmLWJ5OiBDaHJpc3RpYW4gS8O2bmlnIDxjaHJp c3RpYW4ua29lbmlnQGFtZC5jb20+Cj4+Pj4gLS0tCj4+Pj4gICBkcml2ZXJzL2RtYS1idWYvTWFr ZWZpbGUgICAgICB8ICAgMiArLQo+Pj4+ICAgZHJpdmVycy9kbWEtYnVmL2ZlbmNlLWFycmF5LmMg fCAxMjcgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCj4+Pj4gICBp bmNsdWRlL2xpbnV4L2ZlbmNlLWFycmF5LmggICB8ICA3MiArKysrKysrKysrKysrKysrKysrKysr KysKPj4+PiAgIDMgZmlsZXMgY2hhbmdlZCwgMjAwIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24o LSkKPj4+PiAgIGNyZWF0ZSBtb2RlIDEwMDY0NCBkcml2ZXJzL2RtYS1idWYvZmVuY2UtYXJyYXku Ywo+Pj4+ICAgY3JlYXRlIG1vZGUgMTAwNjQ0IGluY2x1ZGUvbGludXgvZmVuY2UtYXJyYXkuaAo+ Pj4gVGhpcyBpcyB3b3JraW5nIGZpbmUgdG8gbWUuIE9uY2UgdGhlIGNvbW1pdCBtZXNzYWdlIGlz IGZpeGVkOgo+Pj4KPj4+IFJldmlld2VkLWJ5OiBHdXN0YXZvIFBhZG92YW4gPGd1c3Rhdm8ucGFk b3ZhbkBjb2xsYWJvcmEuY28udWs+Cj4+Pgo+Pj4gWW91IG5lZWQgdG8gQ2MgU3VtaXQgaGVyZSB0 byBkZWNpZGUgd2hvIGlzIHBpY2tpbmcgdGhlc2UgcGF0Y2hlcy4KPj4+IEl0IHdvdWxkIGJlIGJl dHRlciB0byBnZXQgdGhlbSB0aHJvdWdoIHRoZSBkcm0gdHJlZXMgc28gd2Ugd291bGQgbmVlZAo+ Pj4gaGlzIEFjayBhdCBsZWFzdC4KPj4+Cj4+ICsxIG9uIHRoZSBjb21taXQgbWVzc2FnZSBjb25z aXN0ZW5jeSBjaGFuZ2U7IHBvc3QgdGhhdCwgcGxlYXNlIGZlZWwKPj4gZnJlZSB0byBhZGQgbXkK Pj4gQWNrZWQtYnk6IFN1bWl0IFNlbXdhbCA8c3VtaXQuc2Vtd2FsQGxpbmFyby5vcmc+Cj4+Cj4+ IGZvciB0aGUgMyBkbWEtYnVmL2ZlbmNlcyBwYXRjaGVzIGFuZCByZXF1ZXN0IHRvIHRha2UgdGhl bSB2aWEgRFJNIHRyZWUKPj4gYXMgcmlnaHRseSBzdWdnZXN0ZWQgYnkgR3VzdGF2by4KPiBDb21t aXQgbWVzc2FnZSBpbXByb3ZlZCBhbmQgYWxsIDMgcXVldWVkIHVwIGZvciBkcm0tbWlzYy4gSSBo YXZlbid0IHB1c2hlZAo+IG91dCB0aGUgbmV3IGJyYW5jaCB5ZXQgdGhvdWdoLCBzaW5jZSBJJ20g d2FpdGluZyBmb3IgRGF2ZSB0byBvcGVuIGRybS1uZXh0Cj4gYW5kIHB1bGwgaW4gYSBmZXcgb3Ro ZXIgYml0cyBmaXJzdCBzbyB0aGF0IEkgY2FuIHJlYmFzZS4KClRoYW5rcyBhbmQgc29ycnkgZm9y IG1pc3NpbmcgdGhlIGNvbW1pdCBtZXNzYWdlLiBJIHdhcyBhIGJpdCB0byAKY29uY2VudHJhdGVk IG9uIGZpeGluZyB0aGUgY29kZS4KCkxlYXZlIG1lIGEgbm90ZSB3aGVuIHRoZSBicmFuY2ggaXMg cHVibGljIGF2YWlsYWJsZSwgY2F1c2UgSSB0aGVuIHdhbnQgCnRvIHJlYmFzZSB0aGUgYW1kZ3B1 IGNoYW5nZXMgb24gdG9wIGFuZCBzZW5kIGEgcHVsbCByZXF1ZXN0IHRvIEFsZXguCgpDaHJpc3Rp YW4uCgo+Cj4gVGhhbmtzLCBEYW5pZWwKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752084AbcFBHU0 (ORCPT ); Thu, 2 Jun 2016 03:20:26 -0400 Received: from pegasos-out.vodafone.de ([80.84.1.38]:57528 "EHLO pegasos-out.vodafone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750931AbcFBHUY (ORCPT ); Thu, 2 Jun 2016 03:20:24 -0400 X-Spam-Flag: NO X-Spam-Score: 0.2 Authentication-Results: rohrpostix2.prod.vfnet.de (amavisd-new); dkim=pass header.i=@vodafone.de X-DKIM: OpenDKIM Filter v2.6.8 pegasos-out.vodafone.de 8B66E5E013C Subject: Re: [PATCH 02/11] dma-buf/fence: add fence_array fences v6 To: Sumit Semwal , Gustavo Padovan , DRI mailing list , LKML , Chris Wilson References: <1464786612-5010-1-git-send-email-deathsimple@vodafone.de> <1464786612-5010-3-git-send-email-deathsimple@vodafone.de> <20160601152519.GF11486@joana> <20160601224450.GD7231@phenom.ffwll.local> From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: <574FDE2F.1060401@vodafone.de> Date: Thu, 2 Jun 2016 09:20:15 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <20160601224450.GD7231@phenom.ffwll.local> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 02.06.2016 um 00:44 schrieb Daniel Vetter: > On Wed, Jun 01, 2016 at 09:54:04PM +0530, Sumit Semwal wrote: >> Hi Christian, Gustavo, >> >> Thanks for these patches. >> >> On 1 June 2016 at 20:55, Gustavo Padovan wrote: >>> 2016-06-01 Christian König : >>> >>>> From: Gustavo Padovan >>>> >>>> struct fence_collection inherits from struct fence and carries a >>>> collection of fences that needs to be waited together. >>>> >>>> It is useful to translate a sync_file to a fence to remove the complexity >>>> of dealing with sync_files on DRM drivers. So even if there are many >>>> fences in the sync_file that needs to waited for a commit to happen, >>>> they all get added to the fence_collection and passed for DRM use as >>>> a standard struct fence. >>>> >>>> That means that no changes needed to any driver besides supporting fences. >>>> >>>> fence_collection's fence doesn't belong to any timeline context, so >>>> fence_is_later() and fence_later() are not meant to be called with >>>> fence_collections fences. >>>> >>>> v2: Comments by Daniel Vetter: >>>> - merge fence_collection_init() and fence_collection_add() >>>> - only add callbacks at ->enable_signalling() >>>> - remove fence_collection_put() >>>> - check for type on to_fence_collection() >>>> - adjust fence_is_later() and fence_later() to WARN_ON() if they >>>> are used with collection fences. >>>> >>>> v3: - Initialize fence_cb.node at fence init. >>>> >>>> Comments by Chris Wilson: >>>> - return "unbound" on fence_collection_get_timeline_name() >>>> - don't stop adding callbacks if one fails >>>> - remove redundant !! on fence_collection_enable_signaling() >>>> - remove redundant () on fence_collection_signaled >>>> - use fence_default_wait() instead >>>> >>>> v4 (chk): Rework, simplification and cleanup: >>>> - Drop FENCE_NO_CONTEXT handling, always allocate a context. >>>> - Rename to fence_array. >>>> - Return fixed driver name. >>>> - Register only one callback at a time. >>>> - Document that create function takes ownership of array. >>>> >>>> v5 (chk): More work and fixes: >>>> - Avoid deadlocks by adding all callbacks at once again. >>>> - Stop trying to remove the callbacks. >>>> - Provide context and sequence number for the array fence. >>>> >>>> v6 (chk): Fixes found during testing >>>> - Fix stupid typo in _enable_signaling(). >>>> >>>> Signed-off-by: Gustavo Padovan >>>> Signed-off-by: Christian König >>>> --- >>>> drivers/dma-buf/Makefile | 2 +- >>>> drivers/dma-buf/fence-array.c | 127 ++++++++++++++++++++++++++++++++++++++++++ >>>> include/linux/fence-array.h | 72 ++++++++++++++++++++++++ >>>> 3 files changed, 200 insertions(+), 1 deletion(-) >>>> create mode 100644 drivers/dma-buf/fence-array.c >>>> create mode 100644 include/linux/fence-array.h >>> This is working fine to me. Once the commit message is fixed: >>> >>> Reviewed-by: Gustavo Padovan >>> >>> You need to Cc Sumit here to decide who is picking these patches. >>> It would be better to get them through the drm trees so we would need >>> his Ack at least. >>> >> +1 on the commit message consistency change; post that, please feel >> free to add my >> Acked-by: Sumit Semwal >> >> for the 3 dma-buf/fences patches and request to take them via DRM tree >> as rightly suggested by Gustavo. > Commit message improved and all 3 queued up for drm-misc. I haven't pushed > out the new branch yet though, since I'm waiting for Dave to open drm-next > and pull in a few other bits first so that I can rebase. Thanks and sorry for missing the commit message. I was a bit to concentrated on fixing the code. Leave me a note when the branch is public available, cause I then want to rebase the amdgpu changes on top and send a pull request to Alex. Christian. > > Thanks, Daniel