From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Hunt, David" Subject: Re: [PATCH v6 1/5] mempool: support external handler Date: Thu, 2 Jun 2016 10:11:38 +0100 Message-ID: <574FF84A.4030906@intel.com> References: <1463665501-18325-1-git-send-email-david.hunt@intel.com> <1464797998-76690-1-git-send-email-david.hunt@intel.com> <1464797998-76690-2-git-send-email-david.hunt@intel.com> <20160601195456.47ac2a7c@pcviktorin.fit.vutbr.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, olivier.matz@6wind.com, jerin.jacob@caviumnetworks.com To: Jan Viktorin Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 3E7522C72 for ; Thu, 2 Jun 2016 11:11:41 +0200 (CEST) In-Reply-To: <20160601195456.47ac2a7c@pcviktorin.fit.vutbr.cz> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 6/1/2016 6:54 PM, Jan Viktorin wrote: > Hello David, > > the rename s/handler/ops/ has a lot of residues. Sorry for that :). I tried to > mark most of them. Otherwise, I couldn't see many more serious issues for now. Ah, I had assumed that we were just talking about the rte_mempool_handler_ops structure, not a global replace of 'handler' with 'ops'. It does make sense to change it to ops, so we don't have two words describing the same entity. I'll change to ops. Just, note the s/pool/priv/ rename suggestion. I prefer your suggestion of pdata rather than priv, how about "pool_data"? Again, thanks for the comprehensive review. Regards, Dave. [...]