From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Thu, 02 Jun 2016 11:21:48 +0200 (CEST) Received: from smtpout.microchip.com ([198.175.253.82]:19079 "EHLO email.microchip.com" rhost-flags-OK-OK-OK-FAIL) by eddie.linux-mips.org with ESMTP id S27033337AbcFBJVqhgvQu (ORCPT ); Thu, 2 Jun 2016 11:21:46 +0200 Received: from [10.41.20.11] (10.10.76.4) by chn-sv-exch05.mchp-main.com (10.10.76.106) with Microsoft SMTP Server id 14.3.181.6; Thu, 2 Jun 2016 02:21:38 -0700 Subject: Re: [PATCH] MIPS: pic32mzda: fix linker error for pic32_get_pbclk(). To: Harvey Hunt , References: <1464844821-1581-1-git-send-email-purna.mandal@microchip.com> <9f53c6f4-735a-1a76-9c62-a4f5f127b1e9@imgtec.com> CC: , Ralf Baechle , Joshua Henderson , Joshua Henderson From: Purna Chandra Mandal Message-ID: <574FFA30.1000507@microchip.com> Date: Thu, 2 Jun 2016 14:49:44 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <9f53c6f4-735a-1a76-9c62-a4f5f127b1e9@imgtec.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 53721 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: purna.mandal@microchip.com Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On 06/02/2016 02:45 PM, Harvey Hunt wrote: > Hi Purna, > > On 02/06/16 06:20, Purna Chandra Mandal wrote: >> Early clock API pic32_get_pbclk() is defined in early_clk.c and >> used by time.c and early_console.c. When CONFIG_EARLY_PRINTK isn't >> set, early_clk.c isn't compiled and so a linker error is reported >> while referring the API from time.c. > > Maybe "early_clk.c isn't compiled and so time.c fails to link"? > ack. >> >> Fix it by compiling early_clk.c always. Also sort files in >> alphabetical order. >> >> Cc: Harvey Hunt >> Cc: Ralf Baechle >> Cc: linux-mips@linux-mips.org >> Cc: Joshua Henderson >> >> Signed-off-by: Purna Chandra Mandal >> >> --- >> >> arch/mips/pic32/pic32mzda/Makefile | 5 ++--- >> 1 file changed, 2 insertions(+), 3 deletions(-) >> >> diff --git a/arch/mips/pic32/pic32mzda/Makefile b/arch/mips/pic32/pic32mzda/Makefile >> index 4a4c272..c286496 100644 >> --- a/arch/mips/pic32/pic32mzda/Makefile >> +++ b/arch/mips/pic32/pic32mzda/Makefile >> @@ -2,8 +2,7 @@ >> # Joshua Henderson, >> # Copyright (C) 2015 Microchip Technology, Inc. All rights reserved. >> # >> -obj-y := init.o time.o config.o >> +obj-y := config.o early_clk.o init.o time.o >> >> obj-$(CONFIG_EARLY_PRINTK) += early_console.o \ >> - early_pin.o \ >> - early_clk.o >> + early_pin.o >> > > Perhaps add: > > Reported-by: Harvey Hunt > > Thanks for fixing this, > > Reviewed-by: Harvey Hunt > Thanks Harvey. > Thanks, > > Harvey From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout.microchip.com ([198.175.253.82]:19079 "EHLO email.microchip.com" rhost-flags-OK-OK-OK-FAIL) by eddie.linux-mips.org with ESMTP id S27033337AbcFBJVqhgvQu (ORCPT ); Thu, 2 Jun 2016 11:21:46 +0200 Subject: Re: [PATCH] MIPS: pic32mzda: fix linker error for pic32_get_pbclk(). References: <1464844821-1581-1-git-send-email-purna.mandal@microchip.com> <9f53c6f4-735a-1a76-9c62-a4f5f127b1e9@imgtec.com> From: Purna Chandra Mandal Message-ID: <574FFA30.1000507@microchip.com> Date: Thu, 2 Jun 2016 14:49:44 +0530 MIME-Version: 1.0 In-Reply-To: <9f53c6f4-735a-1a76-9c62-a4f5f127b1e9@imgtec.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-Path: Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: To: Harvey Hunt , linux-kernel@vger.kernel.org Cc: linux-mips@linux-mips.org, Ralf Baechle , Joshua Henderson , Joshua Henderson Message-ID: <20160602091944.gWwW0V4MQfRZda_0OGXA39Vr-HJgKyygSgg_7FTKKRA@z> On 06/02/2016 02:45 PM, Harvey Hunt wrote: > Hi Purna, > > On 02/06/16 06:20, Purna Chandra Mandal wrote: >> Early clock API pic32_get_pbclk() is defined in early_clk.c and >> used by time.c and early_console.c. When CONFIG_EARLY_PRINTK isn't >> set, early_clk.c isn't compiled and so a linker error is reported >> while referring the API from time.c. > > Maybe "early_clk.c isn't compiled and so time.c fails to link"? > ack. >> >> Fix it by compiling early_clk.c always. Also sort files in >> alphabetical order. >> >> Cc: Harvey Hunt >> Cc: Ralf Baechle >> Cc: linux-mips@linux-mips.org >> Cc: Joshua Henderson >> >> Signed-off-by: Purna Chandra Mandal >> >> --- >> >> arch/mips/pic32/pic32mzda/Makefile | 5 ++--- >> 1 file changed, 2 insertions(+), 3 deletions(-) >> >> diff --git a/arch/mips/pic32/pic32mzda/Makefile b/arch/mips/pic32/pic32mzda/Makefile >> index 4a4c272..c286496 100644 >> --- a/arch/mips/pic32/pic32mzda/Makefile >> +++ b/arch/mips/pic32/pic32mzda/Makefile >> @@ -2,8 +2,7 @@ >> # Joshua Henderson, >> # Copyright (C) 2015 Microchip Technology, Inc. All rights reserved. >> # >> -obj-y := init.o time.o config.o >> +obj-y := config.o early_clk.o init.o time.o >> >> obj-$(CONFIG_EARLY_PRINTK) += early_console.o \ >> - early_pin.o \ >> - early_clk.o >> + early_pin.o >> > > Perhaps add: > > Reported-by: Harvey Hunt > > Thanks for fixing this, > > Reviewed-by: Harvey Hunt > Thanks Harvey. > Thanks, > > Harvey