Re: [PATCH 3/3] arm64: dts: qcom: msm8916: Add RPM sleep stats

[Maulik Shah <mkshah@codeaurora.org>]

Hi,

Reviewed-by: Maulik Shah <mkshah@codeaurora.org>

Thanks,
Maulik

On 10/18/2021 4:38 PM, Stephan Gerhold wrote:
> MSM8916 is similar to the other SoCs that had the RPM stats node added
> in commit 290bc6846547 ("arm64: dts: qcom: Enable RPM Sleep stats").
> However, the dynamic offset readable at 0x14 seems only available on
> some of the newer firmware versions. To be absolutely sure, make use
> of the new qcom,rpm-legacy-stats compatible that reads the sleep stats
> from a fixed offset of 0xdba0.
> 
> Statistics are available for a "vmin" and "xosd" low power mode:
> 
> $ cat /sys/kernel/debug/qcom_stats/vmin
> Count: 0
> Last Entered At: 0
> Last Exited At: 0
> Accumulated Duration: 0
> Client Votes: 0x0
> $ cat /sys/kernel/debug/qcom_stats/xosd
> Count: 0
> Last Entered At: 0
> Last Exited At: 0
> Accumulated Duration: 0
> Client Votes: 0x0
> 
> Cc: Maulik Shah <mkshah@codeaurora.org>
> Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
> ---
>   arch/arm64/boot/dts/qcom/msm8916.dtsi | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi
> index 43464ac64f3e..99f7999aad2d 100644
> --- a/arch/arm64/boot/dts/qcom/msm8916.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi
> @@ -445,6 +445,11 @@ rpm_msg_ram: sram@60000 {
>   			reg = <0x00060000 0x8000>;
>   		};
>   
> +		sram@290000 {
> +			compatible = "qcom,rpm-legacy-stats";
> +			reg = <0x00290000 0x10000>;
> +		};
> +
>   		bimc: interconnect@400000 {
>   			compatible = "qcom,msm8916-bimc";
>   			reg = <0x00400000 0x62000>;
> 

-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a 
member of Code Aurora Forum, hosted by The Linux Foundation