From: Vineet Gupta <Vineet.Gupta1@synopsys.com>
To: David Miller <davem@davemloft.net>, <eladkan@mellanox.com>
Cc: <noamca@mellanox.com>, <linux-kernel@vger.kernel.org>,
<Alexey.Brodkin@synopsys.com>, <netdev@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH 1/1] net: nps_enet: Disable interrupts before napi reschedule
Date: Thu, 2 Jun 2016 15:43:30 +0530 [thread overview]
Message-ID: <575006CA.6070705@synopsys.com> (raw)
In-Reply-To: <20160529.223542.1386340561946869732.davem@davemloft.net>
On Monday 30 May 2016 11:05 AM, David Miller wrote:
> From: Elad Kanfi <eladkan@mellanox.com>
> Date: Thu, 26 May 2016 15:00:06 +0300
>
>> From: Elad Kanfi <eladkan@mellanox.com>
>>
>> Since NAPI works by shutting down event interrupts when theres
>> work and turning them on when theres none, the net driver must
>> make sure that interrupts are disabled when it reschedules polling.
>> By calling napi_reschedule, the driver switches to polling mode,
>> therefor there should be no interrupt interference.
>> Any received packets will be handled in nps_enet_poll by polling the HW
>> indication of received packet until all packets are handled.
>>
>> Signed-off-by: Elad Kanfi <eladkan@mellanox.com>
>> Acked-by: Noam Camus <noamca@mellanox.com>
>
> Applied.
>
ARC osci platform in 4.6 currently have broken networking. This needs a stable
backport to 4.6
Upstream 86651650d16a359e4 ("net: nps_enet: Disable interrupts before napi
reschedule")
Thx,
-Vineet
prev parent reply other threads:[~2016-06-02 10:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-26 12:00 [PATCH 1/1] net: nps_enet: Disable interrupts before napi reschedule Elad Kanfi
2016-05-26 17:53 ` Alexey Brodkin
2016-05-26 17:53 ` Alexey Brodkin
2016-05-27 4:07 ` Vineet Gupta
2016-05-27 4:07 ` Vineet Gupta
2016-05-30 5:35 ` David Miller
2016-06-02 10:13 ` Vineet Gupta [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=575006CA.6070705@synopsys.com \
--to=vineet.gupta1@synopsys.com \
--cc=Alexey.Brodkin@synopsys.com \
--cc=davem@davemloft.net \
--cc=eladkan@mellanox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=noamca@mellanox.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.