From: Sagi Grimberg <sagi@grimberg.me>
To: Max Gurtovoy <maxg@mellanox.com>, Christoph Hellwig <hch@infradead.org>
Cc: matanb@mellanox.com, leon@leon.nu, linux-rdma@vger.kernel.org,
stable@vger.kernel.org, robert@leblancnet.us
Subject: Re: [PATCH] IB/core: Fix bit curruption in ib_device_cap_flags structure
Date: Thu, 2 Jun 2016 14:56:52 +0300 [thread overview]
Message-ID: <57501F04.4010001@grimberg.me> (raw)
In-Reply-To: <57501D0C.9020607@mellanox.com>
>>> IB_DEVICE_CROSS_CHANNEL = (1 << 27),
>>> IB_DEVICE_MANAGED_FLOW_STEERING = (1 << 29),
>>> IB_DEVICE_SIGNATURE_HANDOVER = (1 << 30),
>>> - IB_DEVICE_ON_DEMAND_PAGING = (1 << 31),
>>> + IB_DEVICE_ON_DEMAND_PAGING = (1ULL << 31),
>>> IB_DEVICE_SG_GAPS_REG = (1ULL << 32),
>>> IB_DEVICE_VIRTUAL_FUNCTION = ((u64)1 << 33),
>>> IB_DEVICE_RAW_SCATTER_FCS = ((u64)1 << 34),
>>
>> So now we've got three different styles to define the constants.
>
> My next patch will align casting of IB_DEVICE_VIRTUAL_FUNCTION and
> IB_DEVICE_RAW_SCATTER_FCS to ULL.
>
>>
>> I'd really prefer to move all of them over to the 1ULL << offset style.
>
> me too :)
Sounds good to me too...
Max, give it a day or two before resending (trying to save you the
multi-respin overhead).
Also, please next time when you submit a patch make sure to document
the patch version and what was changed from the last version.
Cheers,
Sagi.
next prev parent reply other threads:[~2016-06-02 11:56 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-02 9:28 [PATCH] IB/core: Fix bit curruption in ib_device_cap_flags structure Max Gurtovoy
2016-06-02 9:28 ` Max Gurtovoy
2016-06-02 11:33 ` Christoph Hellwig
[not found] ` <20160602113353.GA18494-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2016-06-02 11:48 ` Max Gurtovoy
2016-06-02 11:48 ` Max Gurtovoy
2016-06-02 11:56 ` Sagi Grimberg [this message]
2016-06-02 16:51 ` Jason Gunthorpe
2016-06-02 16:52 ` Jason Gunthorpe
[not found] ` <1464859685-18666-1-git-send-email-maxg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2016-06-02 16:24 ` Greg KH
2016-06-02 16:24 ` Greg KH
2016-06-02 16:41 ` Max Gurtovoy
2016-06-02 16:41 ` Max Gurtovoy
[not found] ` <575061A6.1060302-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2016-06-02 16:52 ` Greg KH
2016-06-02 16:52 ` Greg KH
[not found] ` <20160602162426.GC26699-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2016-06-02 16:41 ` Bart Van Assche
2016-06-02 16:41 ` Bart Van Assche
[not found] ` <c72fac21-0a3d-fc40-ec82-e156f29c2fab-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-06-02 16:52 ` Greg KH
2016-06-02 16:52 ` Greg KH
2016-06-02 16:48 ` Christoph Lameter
2016-06-02 16:48 ` Christoph Lameter
2016-06-03 10:47 ` Leon Romanovsky
2016-06-03 10:47 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57501F04.4010001@grimberg.me \
--to=sagi@grimberg.me \
--cc=hch@infradead.org \
--cc=leon@leon.nu \
--cc=linux-rdma@vger.kernel.org \
--cc=matanb@mellanox.com \
--cc=maxg@mellanox.com \
--cc=robert@leblancnet.us \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.