From: Helmut Buchsbaum <helmut.buchsbaum@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>,
Helmut Grohne <h.grohne@intenta.de>
Cc: "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"Alexandre Courbot" <gnurou@gmail.com>,
"Michal Simek" <michal.simek@xilinx.com>,
"Sören Brinkmann" <soren.brinkmann@xilinx.com>
Subject: Re: [PATCH] gpio: zynq: initialize clock even without CONFIG_PM
Date: Thu, 2 Jun 2016 18:43:57 +0200 [thread overview]
Message-ID: <5750624D.8010506@gmail.com> (raw)
In-Reply-To: <CACRpkdYeRn7oxOnYv44R8+FMG4CdMrFQ9sjyZC6SDT-OY4Yezg@mail.gmail.com>
On 06/02/2016 02:30 PM, Linus Walleij wrote:
> On Wed, Jun 1, 2016 at 1:03 PM, Helmut Grohne <h.grohne@intenta.de> wrote:
>
>> When the PM initialization was moved in the commit referenced below, the
>> code enabling the clock was removed from the probe function. On
>> CONFIG_PM=y kernels, this is not a problem as the pm resume hook enables
>> the clock, but when power management is disabled, all those pm_*
>> functions are noops and the clock is never enabled resulting in a
>> dysfunctional gpio controller.
>>
>> Put the clock initialization back to support CONFIG_PM=n.
>>
>> Signed-off-by: Helmut Grohne <h.grohne@intenta.de>
>> Fixes: 3773c195d387 ("gpio: zynq: Do PM initialization earlier to support gpio hogs")
>
> This does not apply to my kernel tree, can you rebase it on
> v4.7-rc1?
>
> Sould it be tagged for stable and sent to fixes?
>
> Yours,
> Linus Walleij
> --
> To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
I just ran into that problem when using v4.7-rc1 for our Zynq-7015 based
custom board running without CONFIG_PM. It relies on MIO based GPIO for
hardware identification, which immediately ceased to work.
Rebasing Helmut's patch for v4.7-rc1 fixes this issue, so I can confirm
it works!
Regards,
Helmut Buchsbaum
prev parent reply other threads:[~2016-06-02 16:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-01 11:03 [PATCH] gpio: zynq: initialize clock even without CONFIG_PM Helmut Grohne
2016-06-02 12:30 ` Linus Walleij
2016-06-02 16:43 ` Helmut Buchsbaum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5750624D.8010506@gmail.com \
--to=helmut.buchsbaum@gmail.com \
--cc=gnurou@gmail.com \
--cc=h.grohne@intenta.de \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=soren.brinkmann@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.