All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Omar Sandoval <osandov@osandov.com>, Jens Axboe <axboe@fb.com>
Cc: Jeff Moyer <jmoyer@redhat.com>,
	linux-block@vger.kernel.org, kernel-team@fb.com,
	Omar Sandoval <osandov@fb.com>
Subject: Re: [PATCH] blk-mq: really fix plug list flushing for nomerge queues
Date: Thu, 2 Jun 2016 11:47:50 -0600	[thread overview]
Message-ID: <57507146.5080809@kernel.dk> (raw)
In-Reply-To: <cb7c4181478c6483fa3d5fe499f53cb9dc937f44.1464844522.git.osandov@fb.com>

On 06/01/2016 11:18 PM, Omar Sandoval wrote:
> From: Omar Sandoval <osandov@fb.com>
>
> Commit 0809e3ac6231 ("block: fix plug list flushing for nomerge queues")
> updated blk_mq_make_request() to set request_count even when
> blk_queue_nomerges() returns true. However, blk_mq_make_request() only
> does limited plugging and doesn't use request_count;
> blk_sq_make_request() is the one that should have been fixed. Do that
> and get rid of the unnecessary work in the mq version.

Thanks Omar, applied for this series.

-- 
Jens Axboe

      parent reply	other threads:[~2016-06-02 17:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-02  5:18 [PATCH] blk-mq: really fix plug list flushing for nomerge queues Omar Sandoval
2016-06-02  8:30 ` Ming Lei
2016-06-02 14:57 ` Jeff Moyer
2016-06-02 17:47 ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57507146.5080809@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=axboe@fb.com \
    --cc=jmoyer@redhat.com \
    --cc=kernel-team@fb.com \
    --cc=linux-block@vger.kernel.org \
    --cc=osandov@fb.com \
    --cc=osandov@osandov.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.