From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rick Jones Subject: Re: [PATCH -next 2/2] virtio_net: Read the advised MTU Date: Thu, 2 Jun 2016 11:02:43 -0700 Message-ID: <575074C3.8040908@hpe.com> References: <1464882211-18723-1-git-send-email-aconole@redhat.com> <1464882211-18723-3-git-send-email-aconole@redhat.com> <5750578E.4040406@hpe.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Aaron Conole Cc: netdev@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, "Michael S. Tsirkin" List-Id: virtualization@lists.linuxfoundation.org On 06/02/2016 10:06 AM, Aaron Conole wrote: > Rick Jones writes: >> One of the things I've been doing has been setting-up a cluster >> (OpenStack) with JumboFrames, and then setting MTUs on instance vNICs >> by hand to measure different MTU sizes. It would be a shame if such a >> thing were not possible in the future. Keeping a warning if shrinking >> the MTU would be good, leave the error (perhaps) to if an attempt is >> made to go beyond the advised value. > > This was cut because it didn't make sense for such a warning to > be issued, but it seems like perhaps you may want such a feature? I > agree with Michael, after thinking about it, that I don't know what sort > of use the warning would serve. After all, if you're changing the MTU, > you must have wanted such a change to occur? I don't need a warning, was simply willing to live with one when shrinking the MTU. Didn't want an error. happy benchmarking, rick jones From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161519AbcFBSK2 (ORCPT ); Thu, 2 Jun 2016 14:10:28 -0400 Received: from g9t1613g.houston.hpe.com ([15.241.32.99]:41078 "EHLO g9t1613g.houston.hpe.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932188AbcFBSK0 (ORCPT ); Thu, 2 Jun 2016 14:10:26 -0400 X-Greylist: delayed 449 seconds by postgrey-1.27 at vger.kernel.org; Thu, 02 Jun 2016 14:10:26 EDT Subject: Re: [PATCH -next 2/2] virtio_net: Read the advised MTU To: Aaron Conole References: <1464882211-18723-1-git-send-email-aconole@redhat.com> <1464882211-18723-3-git-send-email-aconole@redhat.com> <5750578E.4040406@hpe.com> Cc: "Michael S. Tsirkin" , virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org From: Rick Jones Message-ID: <575074C3.8040908@hpe.com> Date: Thu, 2 Jun 2016 11:02:43 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/02/2016 10:06 AM, Aaron Conole wrote: > Rick Jones writes: >> One of the things I've been doing has been setting-up a cluster >> (OpenStack) with JumboFrames, and then setting MTUs on instance vNICs >> by hand to measure different MTU sizes. It would be a shame if such a >> thing were not possible in the future. Keeping a warning if shrinking >> the MTU would be good, leave the error (perhaps) to if an attempt is >> made to go beyond the advised value. > > This was cut because it didn't make sense for such a warning to > be issued, but it seems like perhaps you may want such a feature? I > agree with Michael, after thinking about it, that I don't know what sort > of use the warning would serve. After all, if you're changing the MTU, > you must have wanted such a change to occur? I don't need a warning, was simply willing to live with one when shrinking the MTU. Didn't want an error. happy benchmarking, rick jones