All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] clk: convert API to match reset/mailbox style
Date: Thu, 2 Jun 2016 16:02:50 -0600	[thread overview]
Message-ID: <5750AD0A.30309@wwwdotorg.org> (raw)
In-Reply-To: <5750A933.9000606@gmail.com>

On 06/02/2016 03:46 PM, Daniel Schwierzeck wrote:
>
>
> Am 02.06.2016 um 22:03 schrieb Stephen Warren:
>>> could you rebase the patch to current mainline?. I couldn't apply it
>>> some days ago. Thanks.
>>
>> It seems to work fine for me; see log below. What problem are you seeing?
>>
>> [swarren at swarren-lx1 u-boot]$ git checkout u-boot/master
>> HEAD is now at 8b528709c5bb... spl: fit: Fix load address of fit header
>>
>> [swarren at swarren-lx1 u-boot]$ git am -3 -s ~/\[U-Boot\]\ \[PATCH\]\
>> clk\:\ convert\ API\ to\ match\ reset_mailbox\ style.eml
>> Applying: clk: convert API to match reset/mailbox style
>> Using index info to reconstruct a base tree...
>> M    arch/sandbox/dts/test.dts
>> M    drivers/clk/clk_rk3288.c
>> M    drivers/clk/uniphier/clk-uniphier-mio.c
>> M    drivers/gpio/rk_gpio.c
>> M    drivers/mmc/rockchip_dw_mmc.c
>> M    drivers/mmc/uniphier-sd.c
>> M    drivers/video/rockchip/rk_vop.c
>> Falling back to patching base and 3-way merge...
>> Removing include/clk.h
>> Auto-merging drivers/video/rockchip/rk_vop.c
>> Auto-merging drivers/mmc/uniphier-sd.c
>> Auto-merging drivers/mmc/rockchip_dw_mmc.c
>> Auto-merging drivers/gpio/rk_gpio.c
>> Auto-merging drivers/clk/uniphier/clk-uniphier-mio.c
>> Auto-merging drivers/clk/clk_rk3288.c
>> Auto-merging arch/sandbox/dts/test.dts
>>
>
> I always get this:
>
> daniel at workstation:/work/u-boot$ pwclient get 625342
> Saved patch to U-Boot-clk-convert-API-to-match-reset-mailbox-style.patch
>
> daniel at workstation:/work/u-boot$ git am -3 U-Boot-clk-convert-API-to-match-reset-mailbox-style.patch
> Applying: clk: convert API to match reset/mailbox style
> fatal: sha1 information is lacking or useless (arch/sandbox/dts/test.dts).
> error: could not build fake ancestor
> Patch failed at 0001 clk: convert API to match reset/mailbox style
> The copy of the patch that failed is found in: .git/rebase-apply/patch
> When you have resolved this problem, run "git am --continue".
> If you prefer to skip this patch, run "git am --skip" instead.
> To restore the original branch and stop patching, run "git am --abort".
>
> I'm seeing the same error with "[PATCH] clk: convert API to match reset_mailbox style.eml".
>
> I've tried with git 2.7.4 and 2.8.3 and also with a fresh git clone but nothing helps.

Oh right, it looks like "-3" is required to make the commit apply 
correctly since there have been some minor context changes since I 
created the patch, and that option uses the file SHA information in the 
patch, and when I ran "git format-patch" the commit wasn't based 
directly on upstream (I had some irrelevant intervening commits) so the 
file SHAs in the patch don't exist outside my local repo, and hence the 
messages you see.

You can resolve this by:

git fetch git://github.com/swarren/u-boot.git tmp
git cherry-pick d0b430a197317dd843a09e33359c251ea5f41e6c

It's probably not worth my reposting the patch until it has comments.

  reply	other threads:[~2016-06-02 22:02 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-23 17:47 [U-Boot] [PATCH] clk: convert API to match reset/mailbox style Stephen Warren
2016-06-02 17:00 ` Stephen Warren
2016-06-02 17:48   ` Daniel Schwierzeck
2016-06-02 20:03     ` Stephen Warren
2016-06-02 21:46       ` Daniel Schwierzeck
2016-06-02 22:02         ` Stephen Warren [this message]
2016-06-02 22:08           ` Daniel Schwierzeck
2016-06-02 21:20   ` Simon Glass
2016-06-08  2:43 ` Simon Glass
2016-06-08  4:42   ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5750AD0A.30309@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.