From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42671) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b8iJg-000454-Hi for qemu-devel@nongnu.org; Fri, 03 Jun 2016 02:10:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b8iJf-0003vn-Ic for qemu-devel@nongnu.org; Fri, 03 Jun 2016 02:10:44 -0400 References: <1464931021-25117-1-git-send-email-mark.cave-ayland@ilande.co.uk> From: xiaoqiang zhao Message-ID: <57511F4B.8050200@163.com> Date: Fri, 3 Jun 2016 14:10:19 +0800 MIME-Version: 1.0 In-Reply-To: <1464931021-25117-1-git-send-email-mark.cave-ayland@ilande.co.uk> Content-Type: text/plain; charset=gbk; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH] scsi-disk: fix reads from scsi-disk devices List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mark Cave-Ayland , qemu-devel@nongnu.org, qemu-block@nongnu.org, pbonzini@redhat.com 在 2016年06月03日 13:17, Mark Cave-Ayland 写道: > Commit fcaafb1001b9c42817714dd3b2aadcfdb997b53d accidentally broke reads from > scsi-disk devices when being updated from its original form to use the new > byte-based block functions. Add the extra missing sector to offset conversion > in order to restore read functionality. > > Signed-off-by: Mark Cave-Ayland > --- > hw/scsi/scsi-disk.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c > index ace65e0..ab7cf9c 100644 > --- a/hw/scsi/scsi-disk.c > +++ b/hw/scsi/scsi-disk.c > @@ -347,7 +347,7 @@ static void scsi_do_read(SCSIDiskReq *r, int ret) > scsi_init_iovec(r, SCSI_DMA_BUF_SIZE); > block_acct_start(blk_get_stats(s->qdev.conf.blk), &r->acct, > r->qiov.size, BLOCK_ACCT_READ); > - r->req.aiocb = sdc->dma_readv(r->sector, &r->qiov, > + r->req.aiocb = sdc->dma_readv(r->sector << BDRV_SECTOR_BITS, &r->qiov, > scsi_read_complete, r, r); > } > This patch fix the qemu-system-arm booting issue. Tested-by: xiaoqiang zhao