From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [RFC v3 02/45] dma-mapping: Use unsigned long for dma_attrs Date: Fri, 03 Jun 2016 09:50:40 +0200 Message-ID: <575136D0.6000101@samsung.com> References: <1464881987-13203-1-git-send-email-k.kozlowski@samsung.com> <1464881987-13203-3-git-send-email-k.kozlowski@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-reply-to: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Geert Uytterhoeven Cc: Linux MIPS Mailing List , Aurelien Jacquiot , Benjamin Herrenschmidt , Will Deacon , DRI Development , Paul Mackerras , "linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Michael Ellerman , Linux-sh list , "James E.J. Bottomley" , Christoph Hellwig , Catalin Marinas , xen-devel-GuqFBffKawtpuQazS67q72D2FQJk+8+b@public.gmane.org, Matt Turner , uclinux-h8-devel-5NWGOfrQmneRv+LV9MX5uooqe+aC9MnS@public.gmane.org, James Hogan , "adi-buildroot-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org" , Thomas Gleixner , "linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" On 06/03/2016 09:17 AM, Geert Uytterhoeven wrote: > Hi Krzysztof, > > On Thu, Jun 2, 2016 at 5:39 PM, Krzysztof Kozlowski > wrote: >> --- a/include/linux/dma-mapping.h >> +++ b/include/linux/dma-mapping.h >> @@ -5,13 +5,25 @@ > >> +/** >> + * List of possible attributes associated with a DMA mapping. The semantics >> + * of each attribute should be defined in Documentation/DMA-attributes.txt. >> + */ >> +#define DMA_ATTR_WRITE_BARRIER (1UL << 1) > > Any particular reason they start at 2, not 1? No reason. I'll fix this in next version (and trim Cc-list). Anyway the values of constants won't match old ones but that should not be problem (unless they are hard-coded somewhere). Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Fri, 03 Jun 2016 09:50:54 +0200 (CEST) Received: from mailout1.w1.samsung.com ([210.118.77.11]:10269 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S27039906AbcFCHuwY3yqm (ORCPT ); Fri, 3 Jun 2016 09:50:52 +0200 Received: from eucpsbgm1.samsung.com (unknown [203.254.199.244]) by mailout1.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0O8600HAGR4LX5A0@mailout1.w1.samsung.com>; Fri, 03 Jun 2016 08:50:45 +0100 (BST) X-AuditID: cbfec7f4-f796c6d000001486-57-575136d4a4ca Received: from eusync3.samsung.com ( [203.254.199.213]) by eucpsbgm1.samsung.com (EUCPMTA) with SMTP id 4C.49.05254.4D631575; Fri, 3 Jun 2016 08:50:44 +0100 (BST) Received: from [106.120.53.17] by eusync3.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0O860013ER4HYX40@eusync3.samsung.com>; Fri, 03 Jun 2016 08:50:44 +0100 (BST) Subject: Re: [RFC v3 02/45] dma-mapping: Use unsigned long for dma_attrs To: Geert Uytterhoeven References: <1464881987-13203-1-git-send-email-k.kozlowski@samsung.com> <1464881987-13203-3-git-send-email-k.kozlowski@samsung.com> Cc: Richard Henderson , Ivan Kokshaysky , Matt Turner , Vineet Gupta , Russell King , Stefano Stabellini , Catalin Marinas , Will Deacon , Haavard Skinnemoen , Hans-Christian Egtvedt , Steven Miao , Mark Salter , Aurelien Jacquiot , Mikael Starvik , Jesper Nilsson , Yoshinori Sato , Richard Kuo , Tony Luck , Fenghua Yu , Konrad Rzeszutek Wilk , James Hogan , Michal Simek , Ralf Baechle , David Howells , Ley Foon Tan , Jonas Bonn , "James E.J. Bottomley" , Helge Deller , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Arnd Bergmann , Olof Johansson , Geoff Levand , Martin Schwidefsky , Guan Xuetao , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , the arch/x86 maintainers , Boris Ostrovsky , David Vrabel , Juergen Gross , Bjorn Helgaas , David Airlie , Joerg Roedel , David Woodhouse , Andrew Morton , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , alpha , arcml , "linux-arm-kernel@lists.infradead.org" , xen-devel@lists.xenproject.org, "adi-buildroot-devel@lists.sourceforge.net" , linux-c6x-dev@linux-c6x.org, Cris , uclinux-h8-devel@lists.sourceforge.jp, "open list:QUALCOMM HEXAGON..." , "linux-ia64@vger.kernel.org" , linux-m68k , "open list:METAG ARCHITECTURE" , Linux MIPS Mailing List , "moderated list:PANASONIC MN10300..." , nios2-dev@lists.rocketboards.org, Parisc List , "linuxppc-dev@lists.ozlabs.org" , linux-s390 , Linux-sh list , sparclinux , discuss@x86-64.org, linux-pci , "linux-xtensa@linux-xtensa.org" , DRI Development , "linux-samsung-soc@vger.kernel.org" , linux-mediatek@lists.infradead.org, "linux-arm-msm@vger.kernel.org" , freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org, "open list:ARM/Rockchip SoC..." , linux-rdma , iommu@lists.linux-foundation.org, Linux Media Mailing List , "linux-omap@vger.kernel.org" , Linux Fbdev development list , Christoph Hellwig , Bartlomiej Zolnierkiewicz From: Krzysztof Kozlowski X-Enigmail-Draft-Status: N1110 Message-id: <575136D0.6000101@samsung.com> Date: Fri, 03 Jun 2016 09:50:40 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-version: 1.0 In-reply-to: Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA02SfUxbZRTGfe97e28hq1462F6nmUmNLjYZgwnLiZplc0u8cXFjcQnOzLkO bmBKGWlXdCZLGj6qsHaUAhNKZaUtUGZLC0SFZYzQEarbqpCNiQ4Y4sZgDFqZKFpktjTG/fc8 5/yenJOTI8ZSD7NBfCz/hKDKV+TJmHj66op/ePONbfszU76uSIGy7jALfq+WAcP331Fg8bgY +Mc0wEJ7rUcEoaJSDI6iXBj6vJSGYLMeQYvzLbi9cAvBfFGYhpW5BxhuLAYZqGytwnC6bZIF 3dmdYLkXQDD1cw8Fjpnt0DfyBwtXjTYKzravh6XF4kjwSjsGa++rMN8wjeF223kR3POZMVh+ 2grLdSEKyuq9LMxOp0Kz/S6Cu8ZRBubH+hGYe8do6Pj1pggqewMs9NcbKXB+2YahUeeg4dsz IREES7oYCH02L4LrFywMtNxxY9B7v4rY4qHoVp/SYKwxsVDvqKBh8sogBYEGPwNTPgMNCxOP MBgbizHU/nApco/lagylo24KWgNuFnw1PQjCf66Idhzk7/Q1UHxpj5HhXQ0uxF+/OYT58N8m xP/YlsHPVhkjpTMGiu+b9DG8bUZL893mMZYP/XaYt3ZoeH33NcR3OuW8/eIMlZH+bvxr2ULe sUJBtWX7kfjcpsllUYGO+fjyw3NIi6bpciQWEy6N2JqeKkdxEbmODI57mHIUL5ZyTYgM/rKI YmYKkdmSESZKreV4YhipxtFwIreZWP6iYsw1RPSVo6sGc70bSfdScDXAcC+TzhYHExuxkRhO m+iolnByYjOFUVTT3Avkkd6GozqJe4eYv1miYkwCWaoaX+XjuLdJbY0XRQdjbhOprlZGy5h7 jnS65rARJZgfS5j/p8yPUVaEz6MkQZNVoD6ao0xNViuUak1+TnLWcWUHir3x713IPvCKD3Fi JFsjcVozMqUiRaH6pNKHiBjLEiVZ8v2ZUkm24uQngur4+ypNnqD2oWfEtGy95IsLwQNSLkdx QvhQEAoE1X9dShy3QYsON+88tNAlfX1f4e4jwZaiF7c8ePqJdY0lruRToeGFrQ/96uGEXdnW dO2zY5pzOucOz5qJuL1peK9cdn+uYvyjPP8teQV7v1FQmC5X7aqr0xW7BxT2njcmDtCnypa3 eXI79qS/92aSLRxQJcmwLK1MHv4gUfvk7pTnD71k72917/HKaHWuIlWOVWrFv9wlq5/CAwAA Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 53773 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: k.kozlowski@samsung.com Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On 06/03/2016 09:17 AM, Geert Uytterhoeven wrote: > Hi Krzysztof, > > On Thu, Jun 2, 2016 at 5:39 PM, Krzysztof Kozlowski > wrote: >> --- a/include/linux/dma-mapping.h >> +++ b/include/linux/dma-mapping.h >> @@ -5,13 +5,25 @@ > >> +/** >> + * List of possible attributes associated with a DMA mapping. The semantics >> + * of each attribute should be defined in Documentation/DMA-attributes.txt. >> + */ >> +#define DMA_ATTR_WRITE_BARRIER (1UL << 1) > > Any particular reason they start at 2, not 1? No reason. I'll fix this in next version (and trim Cc-list). Anyway the values of constants won't match old ones but that should not be problem (unless they are hard-coded somewhere). Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [RFC v3 02/45] dma-mapping: Use unsigned long for dma_attrs Date: Fri, 03 Jun 2016 09:50:40 +0200 Message-ID: <575136D0.6000101@samsung.com> References: <1464881987-13203-1-git-send-email-k.kozlowski@samsung.com> <1464881987-13203-3-git-send-email-k.kozlowski@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Cc: Linux MIPS Mailing List , Aurelien Jacquiot , Benjamin Herrenschmidt , Will Deacon , DRI Development , Paul Mackerras , "linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Michael Ellerman , Linux-sh list , "James E.J. Bottomley" , Christoph Hellwig , Catalin Marinas , xen-devel-GuqFBffKawtpuQazS67q72D2FQJk+8+b@public.gmane.org, Matt Turner , uclinux-h8-devel-5NWGOfrQmneRv+LV9MX5uooqe+aC9MnS@public.gmane.org, James Hogan , "adi-buildroot-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org" , Thomas Gleixner , "linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , To: Geert Uytterhoeven Return-path: In-reply-to: List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org On 06/03/2016 09:17 AM, Geert Uytterhoeven wrote: > Hi Krzysztof, > > On Thu, Jun 2, 2016 at 5:39 PM, Krzysztof Kozlowski > wrote: >> --- a/include/linux/dma-mapping.h >> +++ b/include/linux/dma-mapping.h >> @@ -5,13 +5,25 @@ > >> +/** >> + * List of possible attributes associated with a DMA mapping. The semantics >> + * of each attribute should be defined in Documentation/DMA-attributes.txt. >> + */ >> +#define DMA_ATTR_WRITE_BARRIER (1UL << 1) > > Any particular reason they start at 2, not 1? No reason. I'll fix this in next version (and trim Cc-list). Anyway the values of constants won't match old ones but that should not be problem (unless they are hard-coded somewhere). Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 From: k.kozlowski@samsung.com (Krzysztof Kozlowski) Date: Fri, 03 Jun 2016 09:50:40 +0200 Subject: [RFC v3 02/45] dma-mapping: Use unsigned long for dma_attrs In-Reply-To: References: <1464881987-13203-1-git-send-email-k.kozlowski@samsung.com> <1464881987-13203-3-git-send-email-k.kozlowski@samsung.com> List-ID: Message-ID: <575136D0.6000101@samsung.com> To: linux-snps-arc@lists.infradead.org On 06/03/2016 09:17 AM, Geert Uytterhoeven wrote: > Hi Krzysztof, > > On Thu, Jun 2, 2016 at 5:39 PM, Krzysztof Kozlowski > wrote: >> --- a/include/linux/dma-mapping.h >> +++ b/include/linux/dma-mapping.h >> @@ -5,13 +5,25 @@ > >> +/** >> + * List of possible attributes associated with a DMA mapping. The semantics >> + * of each attribute should be defined in Documentation/DMA-attributes.txt. >> + */ >> +#define DMA_ATTR_WRITE_BARRIER (1UL << 1) > > Any particular reason they start at 2, not 1? No reason. I'll fix this in next version (and trim Cc-list). Anyway the values of constants won't match old ones but that should not be problem (unless they are hard-coded somewhere). Best regards, Krzysztof